Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 729280

Summary: app-emacs/ebuild-mode: add BDEPEND to new ebuilds
Product: Gentoo Linux Reporter: Joonas Niilola <juippis>
Component: Current packagesAssignee: Emacs project <emacs>
Status: RESOLVED FIXED    
Severity: normal CC: sam
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard: InVCS
Package list:
Runtime testing required: ---

Description Joonas Niilola gentoo-dev 2020-06-23 09:27:20 UTC
When using 'ebuild-mode-skeleton' to create a completely new ebuild from scratch, it leaves out BDEPEND variable. It already suggests EAPI-7 to be used, so I feel like BDEPEND should be there.

From what I could tell, simple patch like this was enough: 

diff -Naur ebuild-mode-1.50/ebuild-mode.el ebuild-mode-1.50.1/ebuild-mode.el
--- ebuild-mode-1.50/ebuild-mode.el	2020-03-08 00:36:27.000000000 +0200
+++ ebuild-mode-1.50.1/ebuild-mode.el	2020-06-23 12:18:45.096162213 +0300
@@ -555,7 +555,8 @@
   "\n"
   ;; dependencies
   "RDEPEND=\"\"\n"
-  "DEPEND=\"\$\{RDEPEND\}\"\n")
+  "DEPEND=\"\$\{RDEPEND\}\"\n"
+  "BDEPEND=\"\"\n")
 
 
 ;;; Keybindings.
Comment 1 Ulrich Müller gentoo-dev 2020-06-23 10:57:49 UTC
Omitting BDEPEND was deliberate, because (at least in my understanding) policy still allows listing all build-time dependencies in DEPEND. See the Council log where EAPI 7 features have been approved: https://projects.gentoo.org/council/meeting-logs/20171112.txt

[20:26:22] <mgorny> the relevant policy would be that developers are free to ignore BDEPEND and let people who care about cross fix it
[20:26:48] <mgorny> (like they don't have to be 100% prefix safe right now)
[20:26:54] <dilfridge> "fix it" = distribute things between BDEPEND and DEPEND
[20:27:00] <ulm> yep
Comment 2 Larry the Git Cow gentoo-dev 2023-09-01 14:53:59 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/ebuild-mode.git/commit/?id=ed4630fb422b61c45638986e7cb7c7bf684f4707

commit ed4630fb422b61c45638986e7cb7c7bf684f4707
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-09-01 14:53:46 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-09-01 14:53:46 +0000

    Add S and BDEPEND to ebuild skeleton
    
    * ebuild-mode.el (ebuild-mode-insert-skeleton): Add S and BDEPEND.
    Bug 729280.
    
    Bug: https://bugs.gentoo.org/729280
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 ChangeLog      | 5 +++++
 ebuild-mode.el | 7 ++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-09-01 14:54:56 UTC
Thank you, I've been wanting this for a while.
Comment 4 Larry the Git Cow gentoo-dev 2023-09-01 15:01:00 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/ebuild-mode.git/commit/?id=b748af297194138c13af08fa79a1e51f71c7e5ed

commit b748af297194138c13af08fa79a1e51f71c7e5ed
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-09-01 14:53:46 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-09-01 15:00:32 +0000

    Add S and BDEPEND to ebuild skeleton
    
    * ebuild-mode.el (ebuild-mode-insert-skeleton): Add S and BDEPEND.
    Bug 729280.
    
    Bug: https://bugs.gentoo.org/729280
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 ChangeLog      | 5 +++++
 ebuild-mode.el | 7 ++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)
Comment 5 Larry the Git Cow gentoo-dev 2023-09-01 15:02:18 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/ebuild-mode.git/commit/?id=3e0b1c8aa981f8e57e52e3467c11954c22f7c8a4

commit 3e0b1c8aa981f8e57e52e3467c11954c22f7c8a4
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-09-01 14:53:46 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-09-01 15:02:07 +0000

    Add S and BDEPEND to ebuild skeleton
    
    * ebuild-mode.el (ebuild-mode-insert-skeleton): Add S and BDEPEND.
    Bug 729280.
    
    Bug: https://bugs.gentoo.org/729280
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 ChangeLog      | 5 +++++
 ebuild-mode.el | 7 ++++++-
 2 files changed, 11 insertions(+), 1 deletion(-)
Comment 6 Larry the Git Cow gentoo-dev 2023-09-12 17:01:00 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=33aeb925d15a2bb65a7dd7057f9f2d93ba5f1f8c

commit 33aeb925d15a2bb65a7dd7057f9f2d93ba5f1f8c
Author:     Ulrich Müller <ulm@gentoo.org>
AuthorDate: 2023-09-12 16:57:07 +0000
Commit:     Ulrich Müller <ulm@gentoo.org>
CommitDate: 2023-09-12 17:00:44 +0000

    app-emacs/ebuild-mode: add 1.67
    
    Closes: https://bugs.gentoo.org/729280
    Signed-off-by: Ulrich Müller <ulm@gentoo.org>

 app-emacs/ebuild-mode/Manifest                |  1 +
 app-emacs/ebuild-mode/ebuild-mode-1.67.ebuild | 28 +++++++++++++++++++++++++++
 2 files changed, 29 insertions(+)