Summary: | app-editors/levee-3.5a fails to build when SIZE is set | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Agostino Sarubbo <ago> |
Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
Status: | RESOLVED FIXED | ||
Severity: | normal | Keywords: | PullRequest |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://github.com/gentoo/gentoo/pull/28040 https://github.com/gentoo/gentoo/pull/28196 |
||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | 878905 | ||
Bug Blocks: | 243502 | ||
Attachments: | build.log |
Description
Agostino Sarubbo
2020-06-23 06:37:17 UTC
Created attachment 645818 [details]
build.log
build log and emerge --info
Build system uses SIZE variable in non-standard way, so it fails with e.g. SIZE="x86_64-pc-linux-gnu-size" or SIZE="llvm-size". configure.sh contains: ... case Z$1 in ... Z--size=*) SIZE=$(echo Z$1 | sed -e 's/^Z--size=//') ;; ... # validate --size= # case X"${SIZE}" in X[0-9][0-9]*) ;; X[0-9][0-9]*[Ll]);; X) ;; X*) AC_FAIL "--size=$SIZE is not a valid number" ;; esac ... if [ "$OS_DOS" ]; then AC_DEFINE SIZE ${SIZE:-32000} AC_DEFINE PROC _fastcall AC_DEFINE TTY_ANSI 1 AC_CHECK_FUNCS basename elif [ "$OS_ATARI" ]; then AC_DEFINE SIZE ${SIZE:-32000} AC_DEFINE TTY_VT52 1 AC_DEFINE HAVE_BLKFILL 1 AC_CHECK_FUNCS basename elif [ "$OS_FLEXOS" ]; then AC_DEFINE SIZE ${SIZE:-256000} AC_CHECK_FUNCS basename else AC_DEFINE SIZE ${SIZE:-256000} AC_DEFINE OS_UNIX 1 ... So ebuild should probably call ./configure.sh with --size=256000 option. tinderbox has reproduced this issue with version 3.5a - Updating summary. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c61735c200d5a256705d2c3e8243eeb122dc390d commit c61735c200d5a256705d2c3e8243eeb122dc390d Author: Pascal Jäger <pascal.jaeger@leimstift.de> AuthorDate: 2022-10-30 12:36:46 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-10-31 17:43:19 +0000 app-editors/levee: version bump to 4.0, fix clang16 build - wrote patch to remove all old implicit function declarations, implicit ins, etc (also sent it upstream) - patch build system to look for libtinfo (bug was also present in 3.5a, but wasn't filed in b.g.o) - call ./configure.sh with --size=256000 because configure script is using it an a non-standard way (sam: fix -Wimplicit-int, prestripping) Closes: https://bugs.gentoo.org/875740 Closes: https://bugs.gentoo.org/870889 Closes: https://bugs.gentoo.org/729264 Closes: https://bugs.gentoo.org/690168 Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de> Closes: https://github.com/gentoo/gentoo/pull/28040 Signed-off-by: Sam James <sam@gentoo.org> app-editors/levee/Manifest | 2 ++ app-editors/levee/levee-4.0.ebuild | 48 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 50 insertions(+) |