| Summary: | app-editors/kakoune-2020.01.16_p20200601 overrides CFLAGS and hardcodes -O3 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | sirvertalot |
| Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | juippis, sam |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/20606 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 59506 | ||
| Attachments: |
command used to compile kakoune source files
emerge --info ebuild patch to sed the makefile, found in contrib/ in the kakoune repo |
||
Created attachment 643996 [details]
emerge --info
I saw this when I was testing for the keywording bug. Thanks for reporting it. I saw it too, but because I didn't receive any QA notice about non-respecting CFLAGS, just figured it's only noise. However I guess the QA notice is triggered when your CFLAGS are replaced, not when something's appended to them. Should be an easy patch nevertheless for the next release/snapshot. Created attachment 644094 [details, diff]
ebuild patch to sed the makefile, found in contrib/ in the kakoune repo
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=60d821c5d1cb49b5dca0e4869240dfa742b08209 commit 60d821c5d1cb49b5dca0e4869240dfa742b08209 Author: Jakov Smolic <jakov.smolic@sartura.hr> AuthorDate: 2021-04-30 16:08:13 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2021-05-04 22:17:01 +0000 app-editors/kakoune: Respect CFLAGS, fix gcc-11 compilation Closes: https://bugs.gentoo.org/727558 Closes: https://bugs.gentoo.org/787029 Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr> Signed-off-by: Sam James <sam@gentoo.org> .../kakoune/files/kakoune-2020.01.16-gcc-11.patch | 11 +++++++++ .../kakoune/kakoune-2020.01.16_p20200601.ebuild | 28 ++++++++++++++-------- 2 files changed, 29 insertions(+), 10 deletions(-) |
Created attachment 643994 [details] command used to compile kakoune source files In the attachment, the command has -O3 after the -O2 that is set in CFLAGS.