Bug 727406 – net-vpn/tor-0.4.3.5 - enhance USE flag handling

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Toralf Förster 2020-06-07 09:30:35 UTC]

IMO "coverage" does not need to be enabled at all. For FEATURES=test "unittests" is enough.

And with "zstd" set the "zstd-advanced-apis" should be enabled.

I do run a modified ebuild [1] at 2 relays and 1 client with that modification w/o any issues so far.


[1] https://github.com/toralf/tgro/blob/master/net-vpn/tor/tor-0.4.3.5.ebuild

[Comment 1 Sam James 2023-02-03 12:30:44 UTC]

(In reply to Toralf Förster from comment #0)
> IMO "coverage" does not need to be enabled at all. For FEATURES=test
> "unittests" is enough.

Agreed.

> 
> And with "zstd" set the "zstd-advanced-apis" should be enabled.
> 

This imposes an annoying constraint on the zstd version we can use:
  o Minor features (compression, zstd):
    - When running with zstd, Tor now considers using advanced functions
      that the zstd maintainers have labeled as potentially unstable. To
      prevent breakage, Tor will only use this functionality when the
      runtime version of the zstd library matches the version with which
      Tor was compiled. Closes ticket 25162.

It would mean we had to rebuild on every new zstd version, even if ABI didn't otherwise change. I don't think we want to do this.

[Comment 2 Larry the Git Cow 2023-02-03 12:33:24 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=acb3a7cd0b4814b72991ec8ca1acd64e6b4e6160

commit acb3a7cd0b4814b72991ec8ca1acd64e6b4e6160
Author:     Sam James <[e-mail]>
AuthorDate: 2023-02-03 12:31:14 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-02-03 12:32:38 +0000

    net-vpn/tor: enable py3.11
    
    Also cleanup the ebuild a bit.
    
    Closes: https://bugs.gentoo.org/727406
    Signed-off-by: Sam James <[e-mail]>

 net-vpn/tor/tor-0.4.7.13.ebuild | 83 +++++++++++++++++++++++------------------
 1 file changed, 46 insertions(+), 37 deletions(-)

[Comment 3 Larry the Git Cow 2023-05-05 07:29:52 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=23026087ef73829b1554ce1a8ac35e3652df870f

commit 23026087ef73829b1554ce1a8ac35e3652df870f
Author:     Sam James <[e-mail]>
AuthorDate: 2023-05-05 07:28:40 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-05-05 07:29:40 +0000

    net-vpn/tor: add commentary wrt --disable-zstd-advanced-apis
    
    Bug: https://bugs.gentoo.org/727406
    Bug: https://bugs.gentoo.org/905708
    Signed-off-by: Sam James <[e-mail]>

 net-vpn/tor/tor-0.4.7.13-r1.ebuild | 8 ++++++++
 net-vpn/tor/tor-9999.ebuild        | 8 ++++++++
 2 files changed, 16 insertions(+)

[Comment 4 Larry the Git Cow 2023-09-19 09:24:02 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2c24abe3c96312a18be71666f9fb6b3bbb986514

commit 2c24abe3c96312a18be71666f9fb6b3bbb986514
Author:     Sam James <[e-mail]>
AuthorDate: 2023-09-19 09:18:21 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2023-09-19 09:18:21 +0000

    net-vpn/tor: add 0.4.8.6
    
    Drop setting --disable-zstd-advanced-apis per https://gitlab.torproject.org/tpo/core/tor/-/issues/40815
    as it's been downgraded to a far less scary message.
    
    Bug: https://gitlab.torproject.org/tpo/core/tor/-/issues/40815
    Closes: https://bugs.gentoo.org/727406
    Closes: https://bugs.gentoo.org/905708
    Signed-off-by: Sam James <[e-mail]>

 net-vpn/tor/Manifest           |   3 +
 net-vpn/tor/tor-0.4.8.6.ebuild | 177 +++++++++++++++++++++++++++++++++++++++++
 net-vpn/tor/tor-9999.ebuild    |  10 +--
 3 files changed, 181 insertions(+), 9 deletions(-)