Bug 726298

Summary:	app-text/texlive-core-2020-r4 fails to build: error: 'make_unique' is not a member of 'std'
Product:	Gentoo Linux	Reporter:	Rafał Mużyło <galtgendo>
Component:	Current packages	Assignee:	Alexis Ballier <aballier>
Status:	RESOLVED INVALID
Severity:	normal	CC:	tex
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Attachments:	build log

Description Rafał Mużyło 2020-05-30 12:06:39 UTC

Given the error, I suspect the current patch relies on headers that were previously included by poppler.
It seems as of poppler-0.88, this no longer holds.
The error says adding '#include <memory>' to both files in texlive-core-2020-poppler087.patch should make things work, but that's not true - I'm not sure if the problem is '-std=' or if there's another header using the name.

Though, there's a problem ahead.

It seems that the mail one of the devs here sent early April has resulted in the upstream doing the "adult" thing and removing support support for poppler.

Well, for a definition of "adult"...

Comment 1 Mikle Kolyada (RETIRED) archtester

2020-05-30 13:29:59 UTC

please attach te buildlog.

Comment 2 Rafał Mużyło 2020-05-30 14:01:15 UTC

Created attachment 642768 [details]
build log

...just so we're on the same page: this build log is already after I've added '#include <memory>' lines to the patch.

Comment 3 Mikle Kolyada (RETIRED) archtester

2020-05-30 17:06:29 UTC

I am unable to reproduce this.

Comment 4 Mikle Kolyada (RETIRED) archtester

2020-05-30 17:14:56 UTC

Oh you refer to this probably?

https://github.com/TeX-Live/texlive-source/commit/5cc2db7d41d50988edda4656379a39953ca0bd6c#diff-140124e08da4b2ab89d542d25e16e505

Comment 5 Rafał Mużyło 2020-05-30 19:44:58 UTC

well, if if matters:

app-text/poppler-0.88.0-r1
sys-libs/glibc-2.30-r8
sys-devel/gcc-8.3.0-r1

most suspicious seems to be gcc - I'll check it out.

And obviously I was referring to that commit.

Comment 6 Rafał Mużyło 2020-05-30 19:52:35 UTC

I mean I'm not sure how genuine was the offer of cooperation some of the poppler team repeated on January (on the mailing list) - reading it gives me a bad feeling about it, still it doesn't seem texlive team made any real attempt to reach out either.

Comment 7 Rafał Mużyło 2020-05-30 21:41:01 UTC

OK, I've figured it out: it seems I've had an old workaround from the time c++14 wasn't the default for gcc.

My bad.


Still, at least a note about the poppler situation has been passed.