Bug 725930 – media-gfx/flameshot-0.6.0 w/ Qt 5.15: error: aggregate ‘QPainterPath clip’ has incomplete type and cannot be defined

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Jonas Stein 2020-05-28 22:16:59 UTC]

Created attachment 642384 [details]
build.log

Portage 2.3.100 (python 3.7.7-final-0, default/linux/amd64/17.1/systemd, gcc-9.3.0, glibc-2.31-r3, 5.6.14-gentoo-gf090c5b-dirty x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-5.6.14-gentoo-gf090c5b-dirty-x86_64-AMD_Ryzen_9_3950X_16-Core_Processor-with-gentoo-2.7
KiB Mem:    65801752 total,  49276644 free
KiB Swap:     524284 total,    524284 free
Head commit of repository jstein-overlay: 6ea7237a5afee6a9ef9920d650f0f351736c11cd

Timestamp of repository gentoo: Thu, 28 May 2020 20:30:01 +0000
Head commit of repository gentoo: b530601c28b6aba0ab4932d1a04dcedbf011eb6c
sh bash 5.0_p17
ld GNU ld (Gentoo 2.34 p4) 2.34.0
app-shells/bash:          5.0_p17::gentoo
dev-java/java-config:     2.2.0-r4::gentoo
dev-lang/perl:            5.30.2-r2::gentoo
dev-lang/python:          2.7.18::gentoo, 3.7.7-r2::gentoo, 3.8.3::gentoo
dev-util/cmake:           3.17.2::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.7::gentoo
sys-apps/sandbox:         2.18::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
sys-devel/automake:       1.16.2::gentoo
sys-devel/binutils:       2.34-r1::gentoo
sys-devel/gcc:            9.3.0::gentoo
sys-devel/gcc-config:     2.3::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.6::gentoo (virtual/os-headers)
sys-libs/glibc:           2.31-r3::gentoo
Repositories:

jstein-overlay
    location: /usr/local/overlays/jstein-overlay
    sync-type: git
    sync-uri: https://github.com/jonasstein/jstein-overlay
    masters: gentoo
    priority: -1001

gentoo
    location: /var/db/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-max-age: 24
    sync-rsync-extra-opts: 
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-jobs: 1

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="@FREE bh-luxi"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=native -O2 -pipe"
DISTDIR="/var/db/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://mirror.netcologne.de/gentoo/"
LANG="en_GB.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en"
MAKEOPTS="-j28"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X acl alsa amd64 bash-completion berkdb bzip2 cdda cdr cli corefonts crypt cups dbus dbusudev dri dvd dvdr encode flac fortran gdbm gif git gles2-only iconv ipv6 jpeg latex libtirpc mad mp3 mp4 mpeg mpx multilib ncurses nls nptl ogg opengl openmp pam pcre pdf pm-utils png popcnt pulseaudio qt5 readline seccomp smp sna split-usr ssl svg systemd tcpd tiff truetype udev udisks unicode utf8 vim vim-syntax vorbis xattr zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2 aes avx avx2 f16c fma3 pclmul popcnt sha sse3 sse4_1 sse4_2 sse4a ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="evdev keyboard mouse" KERNEL="linux" L10N="en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_7" PYTHON_TARGETS="python2_7 python3_7" RUBY_TARGETS="ruby24 ruby25" USERLAND="GNU" VIDEO_CARDS="amdgpu radeonsi" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 1 Andreas Sturmlechner 2020-05-28 22:35:27 UTC]

Trivial missing include issue with >=Qt 5.15.0.

[Comment 2 Pavel Kalugin 2020-05-29 08:46:40 UTC]

https://github.com/gentoo/gentoo/pull/16001

[Comment 3 Andreas Sturmlechner 2020-05-29 18:38:18 UTC]

Fix is not complete:

src/third-party/Qt-Color-Widgets/src/color_wheel.cpp:350:22: error: aggregate ‘QPainterPath clip’ has incomplete type and cannot be defined
  350 |         QPainterPath clip;

[Comment 4 Maxim Koltsov (RETIRED) 2020-05-29 19:51:48 UTC]

(In reply to Andreas Sturmlechner from comment #3)
> Fix is not complete:
> 
> src/third-party/Qt-Color-Widgets/src/color_wheel.cpp:350:22: error:
> aggregate ‘QPainterPath clip’ has incomplete type and cannot be defined
>   350 |         QPainterPath clip;

Hm, maybe it makes sense to unbundle this one as well? To use the latest upstream (https://gitlab.com/mattia.basaglia/Qt-Color-Widgets) version.

However upstream doesn't have any tags and bundled version is fairly old...

[Comment 5 Pavel Kalugin 2020-05-29 20:14:04 UTC]

(In reply to Andreas Sturmlechner from comment #3)
> Fix is not complete:
> 
> src/third-party/Qt-Color-Widgets/src/color_wheel.cpp:350:22: error:
> aggregate ‘QPainterPath clip’ has incomplete type and cannot be defined
>   350 |         QPainterPath clip;

Thank you, updated the pull

[Comment 6 Mattia Basaglia 2020-05-30 05:49:07 UTC]

(In reply to Maxim Koltsov from comment #4)
> Hm, maybe it makes sense to unbundle this one as well? To use the latest
> upstream (https://gitlab.com/mattia.basaglia/Qt-Color-Widgets) version.
> 
> However upstream doesn't have any tags and bundled version is fairly old...

I'm the upstream maintainer for Qt-Color-Widgets. If you need anything from me feel free to ask

[Comment 7 Andreas Sturmlechner 2020-05-30 22:16:44 UTC]

(In reply to Mattia Basaglia from comment #6)
> (In reply to Maxim Koltsov from comment #4)
> > Hm, maybe it makes sense to unbundle this one as well? To use the latest
> > upstream (https://gitlab.com/mattia.basaglia/Qt-Color-Widgets) version.
> > 
> > However upstream doesn't have any tags and bundled version is fairly old...
> 
> I'm the upstream maintainer for Qt-Color-Widgets. If you need anything from
> me feel free to ask

In that case the linked PR would be yours to include, because it fixes build with Qt 5.15 now properly. ;)

And also, distributions never like bundled libraries, so a release here and there that would make it possible for flameshot upstream to not ship with a copy of it would be nice. Ideally, the amount of subdirectories in any given 3rdparty dir would be zero.

[Comment 8 Larry the Git Cow 2020-05-30 22:24:16 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e21afcf5a4083064234f4d4d1906164986a85bdc

commit e21afcf5a4083064234f4d4d1906164986a85bdc
Author:     Pavel Kalugin <[e-mail]>
AuthorDate: 2020-05-29 08:41:32 +0000
Commit:     Andreas Sturmlechner <[e-mail]>
CommitDate: 2020-05-30 22:22:48 +0000

    media-gfx/flameshot: Fix build with Qt 5.15
    
    Closes: https://bugs.gentoo.org/725930
    Signed-off-by: Pavel Kalugin <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/16001
    Signed-off-by: Andreas Sturmlechner <[e-mail]>

 .../flameshot-0.6.0-missing-include-fix.patch      | 22 ++++++++++++++++++++++
 media-gfx/flameshot/flameshot-0.6.0.ebuild         |  5 ++++-
 2 files changed, 26 insertions(+), 1 deletion(-)

[Comment 9 Mattia Basaglia 2020-05-31 15:55:20 UTC]

(In reply to Andreas Sturmlechner from comment #7)
> In that case the linked PR would be yours to include, because it fixes build
> with Qt 5.15 now properly. ;)
> 
> And also, distributions never like bundled libraries, so a release here and
> there that would make it possible for flameshot upstream to not ship with a
> copy of it would be nice. Ideally, the amount of subdirectories in any given
> 3rdparty dir would be zero.

I merged a pull request that added the missing include.
Tagged the latest version as v2.2.0

It was mentioned the current version being used is quite old. I had a look at flameshot and I don't think there should be compatibility issues but in case I can help fix them.

[Comment 10 Pavel Kalugin 2020-05-31 16:04:48 UTC]

Should I open another bug for unbundling?