Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 723946

Summary: media-gfx/opentoonz-1.4.0 : /.../twain.h: error: extended character is not valid in an identifier
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: Current packagesAssignee: otakuto.gentoo
Status: RESOLVED FIXED    
Severity: normal CC: gentoo, jaak, proxy-maint, sam, silvio.gerli, treecleaner, unhappy-ending
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://bugs.gentoo.org/show_bug.cgi?id=707736
https://bugs.gentoo.org/show_bug.cgi?id=704626
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: emerge-info.txt
emerge-history.txt
environment
etc.portage.tbz2
logs.tbz2
media-gfx:opentoonz-1.4.0:20200519-053112.log
temp.tbz2
patch to fix weird character error in twain.h
Patch for QPainterPath

Description Toralf Förster gentoo-dev 2020-05-19 07:18:16 UTC
                 from /var/tmp/portage/media-gfx/opentoonz-1.4.0/work/opentoonz-1.4.0/toonz/sources/tnzbase/../common/twain/ttwain_util.h:6,
                 from /var/tmp/portage/media-gfx/opentoonz-1.4.0/work/opentoonz-1.4.0/toonz/sources/tnzbase/tscanner/tscanner.cpp:15:
/var/tmp/portage/media-gfx/opentoonz-1.4.0/work/opentoonz-1.4.0/toonz/sources/tnzbase/../common/twain/twain.h:2212:16: error: extended character  is not valid in an identifier
 2212 | #pragma option a.
      |                ^
make[2]: *** [tnzbase/CMakeFiles/tnzbase.dir/build.make:793: tnzbase/CMakeFiles/tnzbase.dir/tscanner/tscanner.cpp.o] Error 1

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_plasma_systemd-20200513-151505

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-10.1.0 *
clang version 10.0.0 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/10/bin
/usr/lib/llvm/10
10.0.0
Available Python interpreters, in order of preference:
  [1]   python3.8
  [2]   python3.7 (fallback)
  [3]   python3.6 (fallback)
  [4]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems)
  [2]   ruby25 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.43.1 *
The following VMs are available for generation-2:
*)	IcedTea JDK 3.15.0 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm

The Glorious Glasgow Haskell Compilation System, version 8.0.2

  timestamp(s) of HEAD at this tinderbox image:
/var/db/repos/gentoo	Tue 19 May 2020 04:05:25 AM UTC

emerge -qpvO media-gfx/opentoonz
[ebuild  N    ] media-gfx/opentoonz-1.4.0
Comment 1 Toralf Förster gentoo-dev 2020-05-19 07:18:19 UTC
Created attachment 640324 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-05-19 07:18:23 UTC
Created attachment 640326 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2020-05-19 07:18:26 UTC
Created attachment 640328 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2020-05-19 07:18:29 UTC
Created attachment 640330 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2020-05-19 07:18:32 UTC
Created attachment 640332 [details]
logs.tbz2
Comment 6 Toralf Förster gentoo-dev 2020-05-19 07:18:35 UTC
Created attachment 640334 [details]
media-gfx:opentoonz-1.4.0:20200519-053112.log
Comment 7 Toralf Förster gentoo-dev 2020-05-19 07:18:38 UTC
Created attachment 640336 [details]
temp.tbz2
Comment 8 unhappy-ending 2020-06-01 10:52:21 UTC
Created attachment 643008 [details, diff]
patch to fix weird character error in twain.h

Hi Toralf, can you test this patch please? I corrected a seeming typo in the twain.h file that was causing the compilation error. I can get opentoonz to compile further, but still get an error between 52% and 59% in functionpanel.cpp instead of 15% in twain.h.
Comment 9 Collin Day 2020-06-22 02:04:49 UTC
Created attachment 645590 [details, diff]
Patch for QPainterPath

This adds headers for QPainterPath that are left out of some of the .cpp files.  this and patch to remove character allows build with qt-5.15
Comment 10 Toralf Förster gentoo-dev 2022-09-19 12:23:27 UTC
*** Bug 871696 has been marked as a duplicate of this bug. ***
Comment 11 Agostino Sarubbo gentoo-dev 2023-02-04 08:38:02 UTC
Dear treecleaner@:

libarchive_tinderbox reproduced this issue right now.

Since it has not been fixed for a long time, I'd suggest to evaluate if it is the case to remove this package from the tree. Thanks
Comment 12 Larry the Git Cow gentoo-dev 2023-02-04 22:50:10 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d2ca547e88fab4cffb9a2d70a7e85f194d164995

commit d2ca547e88fab4cffb9a2d70a7e85f194d164995
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2023-02-04 22:16:28 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2023-02-04 22:49:36 +0000

    media-gfx/opentoonz: add build fixes
    
    Closes: https://bugs.gentoo.org/723946
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/opentoonz-1.4.0-fix-header.patch         | 13 ++++
 .../opentoonz/files/opentoonz-1.4.0-qt-5.15.patch  | 22 ++++++
 media-gfx/opentoonz/opentoonz-1.4.0-r1.ebuild      | 91 ++++++++++++++++++++++
 3 files changed, 126 insertions(+)