Bug 723130

Summary:	dev-libs/liborcus-0.15.4 configure error when /bin/sh != bash
Product:	Gentoo Linux	Reporter:	Matt Whitlock <gentoo>
Component:	Current packages	Assignee:	Gentoo Office Team <office>
Status:	RESOLVED FIXED
Severity:	normal	CC:	alexander
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://gitlab.com/orcus/orcus/-/commit/7d2ae0b6e47aa0c1fc43a91300d82c5394420162
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	526268

Description Matt Whitlock 2020-05-15 05:32:49 UTC

liborcus's configure.ac contains a Bashism (use of == operator with test built-in). Thus, configure emits an error when /bin/sh is not Bash. This doesn't cause the build to fail outright, but it may be causing misdetection of features.

AS_IF([test x"$enable_werror" == "xyes"], [

./configure: 21090: test: xno: unexpected operator

Suggest setting CONFIG_SHELL=/bin/bash when running configure. The "unexpected operator" message above is not present when CONFIG_SHELL=/bin/bash.

Comment 1 Andreas Sturmlechner gentoo-dev

2020-05-15 07:03:16 UTC

Upstream patch welcome.

Comment 2 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev

2020-05-15 10:33:52 UTC

(In reply to Andreas Sturmlechner from comment #1)
> Upstream patch welcome.

Here you are...

Comment 3 Larry the Git Cow gentoo-dev

2020-05-28 17:09:32 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d131fa2acad53017e0374759dd5f2f0766ecabeb

commit d131fa2acad53017e0374759dd5f2f0766ecabeb
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2020-05-28 16:52:15 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2020-05-28 17:09:02 +0000

    dev-libs/liborcus: Fix bashisms in configure.ac, --disable-static
    
    Reported-by: Matt Whitlock <gentoo@mattwhitlock.name>
    Closes: https://bugs.gentoo.org/723130
    Package-Manager: Portage-2.3.100, Repoman-2.3.22
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../liborcus/files/liborcus-0.15.4-bashism.patch   | 26 ++++++++++++++++++++++
 dev-libs/liborcus/liborcus-0.15.4.ebuild           | 14 +++++++-----
 dev-libs/liborcus/liborcus-9999.ebuild             |  8 +++----
 3 files changed, 38 insertions(+), 10 deletions(-)