Bug 721618

Summary:	mail-client/alpine-2.22: multiple definition of `pith_smime_enter_password' with gcc-10
Product:	Gentoo Linux	Reporter:	Holger Hoffstätte <holger>
Component:	Current packages	Assignee:	Robert G. Siebeck <gentoo.2019>
Status:	RESOLVED FIXED
Severity:	normal	CC:	jstein, proxy-maint
Priority:	Normal	Keywords:	PATCH, PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/15753
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	705764

Description Holger Hoffstätte 2020-05-08 10:42:47 UTC

Rebuilding alpine with gcc-10 fails due to -fno-common.

Reproducible: Always

Steps to Reproduce:
1. rebuild alpine-2.22 with gcc-10
2. oh noes!
Actual Results:  
/usr/lib/gcc/x86_64-pc-linux-gnu/10.1.0/../../../../x86_64-pc-linux-gnu/bin/ld: ../pith/libpith.a(smime.o):/tmp/alpine-2.22/pith/smime.c:90: multiple definition of `pith_smime_enter_password'; ../pith/libpith.a(smkeys.o):/tmp/alpine-2.22/pith/smkeys.c:53: first defined here


Expected Results:  
Correct build.


Upstream has a patch in git:
https://repo.or.cz/alpine.git/commit/d7838fd7545719029474fea04a51332a542e978a

Only the hunk for pith/smkeys.c is needed; the first is just a version bump.
Dropping https://repo.or.cz/alpine.git/blobdiff_plain/6288c67a92b37eba8f74305e5bb9d076a0c53e4b..d7838fd7545719029474fea04a51332a542e978a:/pith/smkeys.c into /etc/portage/patches fixes the problem: alpine builds & works fine again.

Comment 1 Holger Hoffstätte 2020-05-09 11:04:15 UTC

Obviously just adding -fcommon to CFLAGS also works, if that's easier.

Comment 2 Larry the Git Cow gentoo-dev

2020-05-14 22:19:43 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=99d8545796e75d781dfedbae9d4f26b1cb5a52b4

commit 99d8545796e75d781dfedbae9d4f26b1cb5a52b4
Author:     Robert Siebeck <gentoo.2019@r123.de>
AuthorDate: 2020-05-11 17:09:43 +0000
Commit:     Aaron Bauman <bman@gentoo.org>
CommitDate: 2020-05-14 22:19:21 +0000

    mail-client/alpine: fix compilation with gcc-10
    
    Closes: https://bugs.gentoo.org/721618
    Signed-off-by: Robert Siebeck <gentoo.2019@r123.de>
    Closes: https://github.com/gentoo/gentoo/pull/15753
    Signed-off-by: Aaron Bauman <bman@gentoo.org>

 mail-client/alpine/alpine-2.22-r1.ebuild              |  1 +
 mail-client/alpine/files/alpine-2.22-fno-common.patch | 19 +++++++++++++++++++
 2 files changed, 20 insertions(+)