Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 721516

Summary: ecompress complains about compressed files that have been excluded
Product: Portage Development Reporter: Michael Orlitzky <mjo>
Component: CoreAssignee: Portage team <dev-portage>
Status: RESOLVED FIXED    
Severity: normal Keywords: InVCS
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 733180    

Description Michael Orlitzky gentoo-dev 2020-05-07 16:30:12 UTC
For example,

 * One or more compressed files were found in docompress-ed directories.
 * Please fix the ebuild not to install compressed files (manpages,
 * documentation) when automatic compression is used:
 * 
 *   /usr/share/doc/coinor-vol-1.5.4/examples/Volume-LP/data.mps.gz
 *   /usr/share/doc/coinor-vol-1.5.4/examples/VolUfl/data.gz

The Volume-LP and VolUfl directories contain code samples, and I've used "docompress -x" on them anyway.

At a glance, it looks like this is because "ecompress --queue" creates the .ecompress_had_precompressed file immediately, before "ecompress --ignore" rules them out.
Comment 2 Larry the Git Cow gentoo-dev 2020-05-24 23:49:11 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=5508bf7a6db59149bbc9ad2ff45fb0329fb83644

commit 5508bf7a6db59149bbc9ad2ff45fb0329fb83644
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2020-05-24 21:02:06 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2020-05-24 23:43:01 +0000

    ecompress: ignore docompress -x files in precompressed QA check (bug 721516)
    
    Ignore files passed to docompress -x in the QA check for
    precompressed files.
    
    Bug: https://bugs.gentoo.org/721516
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 bin/ecompress | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2020-05-25 00:24:14 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=77960c6cf984530dbcab9fe507e170e7a2fe7dcf

commit 77960c6cf984530dbcab9fe507e170e7a2fe7dcf
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2020-05-25 00:20:07 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2020-05-25 00:20:58 +0000

    sys-apps/portage: Bump to version 2.3.100
    
     #715108 Change default BINPKG_COMPRESS to zstd
     #719456 Add dependency on app-arch/zstd
     #720866 Do not set PKG_CONFIG_PATH
     #721402 Hostname UnicodeEncodeError surrogates not allowed
     #721516 Suppress precompressed QA notice for docompress -x
    
    Bug: https://bugs.gentoo.org/721152
    Bug: https://bugs.gentoo.org/715108
    Bug: https://bugs.gentoo.org/719456
    Bug: https://bugs.gentoo.org/720866
    Bug: https://bugs.gentoo.org/721402
    Bug: https://bugs.gentoo.org/721516
    Package-Manager: Portage-2.3.100, Repoman-2.3.22
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 sys-apps/portage/Manifest               |   1 +
 sys-apps/portage/portage-2.3.100.ebuild | 261 ++++++++++++++++++++++++++++++++
 2 files changed, 262 insertions(+)
Comment 4 Larry the Git Cow gentoo-dev 2020-06-24 23:09:22 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=03d4c33f48eb5e98c9fdc8bf49ee239489229b8e

commit 03d4c33f48eb5e98c9fdc8bf49ee239489229b8e
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2020-06-24 22:58:44 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2020-06-24 23:06:46 +0000

    ecompress: fix precompressed false positive for docompress -x <directory>
    
    Use ${REPLY%.ecompress} to correctly strip the .ecompress suffix.
    
    Fixes: 5508bf7a6db5 ("ecompress: ignore docompress -x files in precompressed QA check (bug 721516)")
    Bug: https://bugs.gentoo.org/721516
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 bin/ecompress | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 6 Larry the Git Cow gentoo-dev 2020-07-02 17:35:38 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=aef49531a084eb39c7e1cde16fc1a22c060135fd

commit aef49531a084eb39c7e1cde16fc1a22c060135fd
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2020-06-28 19:30:10 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2020-07-02 17:11:25 +0000

    ecompress: optimize docompress -x precompressed comparison
    
    Use sort and comm with temporary files in order to compare lists
    of docompress -x and precompressed files, since the file lists
    can be extremely large. Also strip ${D%/} from paths in order to
    reduce length.
    
    Bug: https://bugs.gentoo.org/721516
    Suggested-by: Robin H. Johnson <robbat2@gentoo.org>
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 bin/ecompress                                    | 27 ++++++++++++------------
 lib/portage/tests/resolver/ResolverPlayground.py |  1 +
 2 files changed, 15 insertions(+), 13 deletions(-)
Comment 7 Zac Medico gentoo-dev 2020-07-18 23:01:16 UTC
(In reply to Larry the Git Cow from comment #4)
> The bug has been referenced in the following commit(s):
> 
> https://gitweb.gentoo.org/proj/portage.git/commit/?id=03d4c33f48eb5e98c9fdc8bf49ee239489229b8e
> 
> commit 03d4c33f48eb5e98c9fdc8bf49ee239489229b8e
> Author:     Zac Medico <zmedico@gentoo.org>
> AuthorDate: 2020-06-24 22:58:44 +0000
> Commit:     Zac Medico <zmedico@gentoo.org>
> CommitDate: 2020-06-24 23:06:46 +0000
> 
>     ecompress: fix precompressed false positive for docompress -x <directory>
>     
>     Use ${REPLY%.ecompress} to correctly strip the .ecompress suffix.
>     
>     Fixes: 5508bf7a6db5 ("ecompress: ignore docompress -x files in precompressed QA check (bug 721516)")
>     Bug: https://bugs.gentoo.org/721516
>     Signed-off-by: Zac Medico <zmedico@gentoo.org>
> 
>  bin/ecompress | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This remaining fix will be in the next release.
Comment 8 Larry the Git Cow gentoo-dev 2020-07-19 05:45:32 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=bb3180edb5d310d5382bb3c0772c06be0b354806

commit bb3180edb5d310d5382bb3c0772c06be0b354806
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2020-07-19 05:18:41 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2020-07-19 05:37:48 +0000

    sys-apps/portage: Bump to version 3.0.0
    
     #703698 Improve repos.conf handling of boolean settings
     #721516 ecompress complains about compressed files that have
             been excluded by docompress -x
     #729852 Set XTerm titles for konsole
     #731114 Drop support for python2.7
     #731246 man ebuild(5) has incorrect example of $P and $PN
     #732378 Use lru_cache for use_reduce, vercmp, and catpkgsplit
     #733154 List of ignored warnings in .desktop files should be
             updated for compatibility with >=desktop-file-utils-0.25
    
    Bug: https://bugs.gentoo.org/733180
    Bug: https://bugs.gentoo.org/703698
    Bug: https://bugs.gentoo.org/721516
    Bug: https://bugs.gentoo.org/729852
    Bug: https://bugs.gentoo.org/731114
    Bug: https://bugs.gentoo.org/731246
    Bug: https://bugs.gentoo.org/732378
    Bug: https://bugs.gentoo.org/733154
    Package-Manager: Portage-3.0.0, Repoman-2.3.23
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 sys-apps/portage/Manifest             |   1 +
 sys-apps/portage/portage-3.0.0.ebuild | 263 ++++++++++++++++++++++++++++++++++
 2 files changed, 264 insertions(+)