| Summary: | sys-apps/portage: use scanelf -B, --nobanner instead of -q, --quiet | ||
|---|---|---|---|
| Product: | Portage Development | Reporter: | Zac Medico <zmedico> |
| Component: | Core | Assignee: | Portage team <dev-portage> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | gentoo, kumba |
| Priority: | Normal | Keywords: | InVCS |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.gentoo.org/show_bug.cgi?id=711244 https://github.com/gentoo/pax-utils/pull/3 |
||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 715162, 721152 | ||
|
Description
Zac Medico
2020-05-06 23:04:51 UTC
The scanelf -q call actually behaves as intended. It doesn't output anything for musl's /usr/lib/libc.so because the file has no DT_NEEDED or DT_SONAME settings. For the particular scanelf command that's used to generate NEEDED.ELF.2, we can safely omit the scanelf -q option as long as we account for the fact the this will cause the scanelf_file_rpath function to output " - " when there are no DT_NEEDED settings. Patch posted for review: https://archives.gentoo.org/gentoo-portage-dev/message/64bbae4ae7623e90d6659e18175d726f https://github.com/gentoo/portage/pull/548 The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/proj/portage.git/commit/?id=0bd5b693ef12c266000aafeb9557c1437fdfc1b2 commit 0bd5b693ef12c266000aafeb9557c1437fdfc1b2 Author: Zac Medico <zmedico@gentoo.org> AuthorDate: 2020-05-09 22:07:17 +0000 Commit: Zac Medico <zmedico@gentoo.org> CommitDate: 2020-05-24 22:15:24 +0000 NeededEntry: don't use scanelf -q (bug 721336) We don't use scanelf -q, since that would omit libraries like musl's /usr/lib/libc.so which do not have any DT_NEEDED or DT_SONAME settings. Since we don't use scanelf -q, we have to handle the special rpath value " - ". Bug: https://bugs.gentoo.org/721336 Fixes: 25fbe7bc1a92 ("NeededEntry: infer implicit soname from file basename (bug 715162)") Signed-off-by: Zac Medico <zmedico@gentoo.org> bin/misc-functions.sh | 6 +++++- lib/portage/util/_dyn_libs/LinkageMapELF.py | 5 ++++- lib/portage/util/_dyn_libs/NeededEntry.py | 5 +++++ 3 files changed, 14 insertions(+), 2 deletions(-) |