Summary: | mail-client/mailx-8.1.2.20180807 with musl : /.../tty.c:351: undefined reference to CCEQ | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | musl, sam |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 430702 | ||
Attachments: |
emerge-info.txt
emerge-history.txt environment etc.portage.tbz2 mail-client:mailx-8.1.2.20180807:20200425-225502.log temp.tbz2 adds the CCEQ macro definition to tty.c |
Description
Toralf Förster
2020-04-26 08:45:18 UTC
Created attachment 634596 [details]
emerge-info.txt
Created attachment 634598 [details]
emerge-history.txt
Created attachment 634600 [details]
environment
Created attachment 634602 [details]
etc.portage.tbz2
Created attachment 634604 [details]
mail-client:mailx-8.1.2.20180807:20200425-225502.log
Created attachment 634606 [details]
temp.tbz2
FWIW the rbeakage was introduced by the last rev bump, meanign the -fno-common patch. A (untested) fix might be: - CCEQ(tio.c_cc[keys[i].tio], *buf)) + tio.c_cc[keys[i].tio] == *buf && + tio.c_cc[keys[i].tio] != _POSIX_VDISABLE) (In reply to Toralf Förster from comment #7) > FWIW the rbeakage was introduced by the last rev bump, meanign the > -fno-common patch. Could you elaborate on that? I don't see how the missing macro definition could be introduced in a file that isn't touched at all by the -fno-common patch. As far as I can tell, the problem was either introduced by one of the Debian patches or it must have existed in the previous version as well. > A (untested) fix might be: > > - CCEQ(tio.c_cc[keys[i].tio], *buf)) > + tio.c_cc[keys[i].tio] == *buf && > + tio.c_cc[keys[i].tio] != _POSIX_VDISABLE) Seems to be musl specific: [11:34:03 pm] <+toralf> is bug 719512 musl specific or gcc-10 specific ? [11:34:06 pm] <willikins> https://bugs.gentoo.org/719512 "mail-client/mailx-8.1.2.20180807 : /.../tty.c:351: undefined reference to CCEQ"; Gentoo Linux, Current packages; CONF; toralf:musl [11:35:54 pm] <sam_c> musl if I recall right from when we last discussed [11:36:16 pm] <sam_c> will checki n a bit if nobody else does [11:41:05 pm] <+Anarchy> it is musl specific [12:00:00 am] - {Day changed to Thursday, May 21, 2020} [1:16:33 am] <veremitz> ah I Was gonna look into where CCEQ gets defined, but seems you guys got it :D [1:21:31 am] <[Arfrever]> /usr/include/termios.h:# define CCEQ(val, c) ((c) == (val) && (val) != _POSIX_VDISABLE) [2:19:38 am] <veremitz> aha its one of those .. BSD libc and glibc define CCEQ in termios.h but musl does not. Adding that definition in tty.c would be trivial. Created attachment 787109 [details, diff]
adds the CCEQ macro definition to tty.c
Macro definition copied from glibc /usr/include/termios.h
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5dd27f1032275822f8303e9c5f48919a7e80bd6f commit 5dd27f1032275822f8303e9c5f48919a7e80bd6f Author: Sam James <sam@gentoo.org> AuthorDate: 2022-06-24 01:58:55 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-06-24 03:13:49 +0000 mail-client/mailx: fix build on musl Thanks-to: CFuga <cfuga@cfuga.mx> Closes: https://bugs.gentoo.org/719512 Signed-off-by: Sam James <sam@gentoo.org> .../mailx/files/mailx-8.1.2-20180807-musl-CCEQ.patch | 17 +++++++++++++++++ mail-client/mailx/mailx-8.1.2.20180807.ebuild | 1 + 2 files changed, 18 insertions(+) |