Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 718974

Summary: app-misc/goobook: still uses dev-python/oauth2client
Product: Gentoo Linux Reporter: Michał Górny <mgorny>
Component: Current packagesAssignee: Kalin KOZHUHAROV <kalin>
Status: RESOLVED FIXED    
Severity: normal CC: jsmolic, kalin, proxy-maint, treecleaner
Priority: Normal Keywords: PMASKED
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 718972    
Deadline: 2020-10-09   

Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2020-04-23 06:36:48 UTC
oauth2client has been discontinued upstream and grows technical debt.  Please look into replacing it.
Comment 1 Kalin KOZHUHAROV 2020-05-19 20:39:43 UTC
Yes indeed: https://google-auth.readthedocs.io/en/latest/oauth2client-deprecation.html

Also goobook itself is really lacking dev leadership :-/
Comment 2 Larry the Git Cow gentoo-dev 2021-02-26 14:26:31 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a2a81415b3fdf44680a83011727f8937c239fec7

commit a2a81415b3fdf44680a83011727f8937c239fec7
Author:     Jakov Smolic <jakov.smolic@sartura.hr>
AuthorDate: 2021-02-25 17:57:12 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-02-26 14:25:53 +0000

    app-misc/goobook: Bump to 3.5.1
    
    Closes: https://bugs.gentoo.org/746308
    Bug: https://bugs.gentoo.org/718974
    Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>
    Signed-off-by: Sam James <sam@gentoo.org>

 app-misc/goobook/Manifest             |  1 +
 app-misc/goobook/goobook-3.5.1.ebuild | 44 +++++++++++++++++++++++++++++++++++
 2 files changed, 45 insertions(+)
Comment 3 Kalin KOZHUHAROV 2021-02-27 02:39:27 UTC
Hmm...  While that compiles, it doesn't run at least by me...

Traceback (most recent call last):
  File "/usr/lib/python-exec/python3.7/goobook", line 33, in <module>
    sys.exit(load_entry_point('goobook==3.5.1', 'console_scripts', 'goobook')())
  File "/usr/lib/python-exec/python3.7/goobook", line 25, in importlib_load_entry_point
    return next(matches).load()
  File "/usr/lib/python3.7/site-packages/importlib_metadata/__init__.py", line 96, in load
    module = import_module(match.group('module'))
  File "/usr/lib/python3.7/importlib/__init__.py", line 127, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1006, in _gcd_import
  File "<frozen importlib._bootstrap>", line 983, in _find_and_load
  File "<frozen importlib._bootstrap>", line 967, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 677, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 728, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/usr/lib/python3.7/site-packages/goobook/application.py", line 18, in <module>
    import pkg_resources
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 3242, in <module>
    @_call_aside
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 3226, in _call_aside
    f(*args, **kwargs)
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 3255, in _initialize_master_working_set
    working_set = WorkingSet._build_master()
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 568, in _build_master
    ws.require(__requires__)
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 886, in require
    needed = self.resolve(parse_requirements(requirements))
  File "/usr/lib/python3.7/site-packages/pkg_resources/__init__.py", line 772, in resolve
    raise DistributionNotFound(req, requirers)
pkg_resources.DistributionNotFound: The 'xdg>=4.0.1' distribution was not found and is required by goobook


Apparently it depends on https://github.com/srstevenson/xdg which is not in portage yet (and it is not pyxdg).
Comment 4 Jakov Smolić archtester gentoo-dev 2021-02-27 09:36:18 UTC
> Apparently it depends on https://github.com/srstevenson/xdg which is not in
> portage yet (and it is not pyxdg).


Thanks, I'll fix it now, please see https://bugs.gentoo.org/773250
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-12-25 09:09:04 UTC
Ping.
Comment 6 Kalin KOZHUHAROV 2022-12-29 22:23:57 UTC
There is new upstream maintainer and a new release 3.5.2 that still uses oauth2client though :-/

I just made a new ebuild for it, and after some version twisting it is working now. I will test a bit more and create PR for gentoo next week.

For now it is available in pkalin[1] overlay.

[1] https://github.com/thinrope/pkalin/tree/master/app-misc/goobook
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-01-11 04:30:58 UTC
Final ping.  We're one stabilization round away from lastriting dev-python/oauth2client.
Comment 8 Larry the Git Cow gentoo-dev 2023-03-18 16:44:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=09d570d51ada6ebee46c441b9516258a99701719

commit 09d570d51ada6ebee46c441b9516258a99701719
Author:     David Seifert <soap@gentoo.org>
AuthorDate: 2023-03-18 16:42:46 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2023-03-18 16:42:46 +0000

    app-misc/goobook: treeclean
    
    Closes: https://bugs.gentoo.org/718974
    Signed-off-by: David Seifert <soap@gentoo.org>

 app-misc/goobook/Manifest                        |   1 -
 app-misc/goobook/files/goobook-3.5.1-pyxdg.patch | 105 -----------------------
 app-misc/goobook/goobook-3.5.1-r3.ebuild         |  48 -----------
 app-misc/goobook/metadata.xml                    |  16 ----
 profiles/package.mask                            |   1 -
 5 files changed, 171 deletions(-)