| Summary: | net-vpn/protonvpn-cli: need py3.7, 3.8 port | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Michał Górny <mgorny> |
| Component: | Current packages | Assignee: | Amel Hodzic <ilmostro7> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | ilmostro7, proxy-maint |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/15744 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | 719498 | ||
| Bug Blocks: | 695996 | ||
|
Description
Michał Górny
2020-04-19 20:05:24 UTC
Pardon me chiming in from the sidelines, and pardon if it's already obvious. The restriction on python-3.6 is only due to the pythondialog dependency. pythondialog-3.5 supports python-3.7 at least, but is not in-tree yet, though I don't understand why. Also, the dependency on pythondialog is optional, so the ebuild _could_ grow a u se-dependency for cl-interactive mode. That would be straightfowward except for the name of the use flag... I can't find a good match in the existing set. The ebuld could also drop the pythondialog completely, if the pythondialog depen dency can't be resolved. Before the protonvpn-cli was merged upstream (and I migrated back to python-3.6 because of it), I used a local buld of the protonvpn-cli with the native python-3.7 install. I built and used versions with and without tying in pythondialog-3.5 as the python-3.7-compliant dependency. Upstream is fully fine with python-3.7 as well. Thank you, Andre. I was about to point this out. I'm glad you beat me to it, as I need to make sure I don't overlook these messages from gentoo bugzilla.
Ideally, pythondialog will be ported to support python3_{7,8} and this will be fixed by a pull-request on which I'm already working. However, since pythondialog seems to be only an optional dependency for interactive sessions with protonvpn-cli, I am also working on fixing the ebuild to reflect that; perhaps with a USE flag.
I hope that clears up any issues regarding this bug, as I noticed this package listed as "up for grabs".
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b5e2a0d680b109a2a42393772eb9eafddaaa2bae commit b5e2a0d680b109a2a42393772eb9eafddaaa2bae Author: Amel Hodzic <ilmostro7@gmail.com> AuthorDate: 2020-06-08 07:51:39 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2020-06-08 07:52:35 +0000 net-vpn/protonvpn-cli: enable python-3.7, 3.8 Closes: https://bugs.gentoo.org/718460 Package-Manager: Portage-2.3.99, Repoman-2.3.22 Signed-off-by: Amel Hodzic <ilmostro7@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/15744 Signed-off-by: Joonas Niilola <juippis@gentoo.org> net-vpn/protonvpn-cli/protonvpn-cli-2.2.2.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) |