| Summary: | [kde overlay] kde-misc/latte-dock-9999: app/settings/dialogs/settingsdialog.cpp:35:10: fatal error: ../../liblatte2/types.h: No such file or directory | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | FlyingWaffle <flyingwaffle> |
| Component: | Current packages | Assignee: | Gentoo KDE team <kde> |
| Status: | RESOLVED UPSTREAM | ||
| Severity: | normal | Keywords: | UPSTREAM |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
live ebuild for latte-dock
failed build's log diff for fix reduced diff |
||
Live ebuilds of KDE Proj packages are maintained in KDE overlay. (In reply to FlyingWaffle from comment #0) > Created attachment 633418 [details] > live ebuild for latte-dock > > Hello, > > I noticed that there is no live ebuild for kde-misc/latte-dock on the > official overlay, and the one on the 'kde' overlay is broken, so I made my > own! If you want to report a bug, then fine, please attach a build.log and submit a *unified* diff to fix the issue. Created attachment 633422 [details]
failed build's log
'kde' overlay live build for latte-dock doesn't take into acount a hard coded reference to a file relative to the build directory
Created attachment 633424 [details]
diff for fix
Here is diff with my fix
That is an upstream out-of-source build issue that should be reported exactly there, upstream. We don't change our ebuild whenever there is a temporary upstream issue. Your fix is just a workaround and contains wholly unrelated changes that are unacceptable for use. Created attachment 633426 [details] reduced diff (In reply to Andreas Sturmlechner from comment #4) > That is an upstream out-of-source build issue that should be reported > exactly there, upstream. We don't change our ebuild whenever there is a > temporary upstream issue. > > Your fix is just a workaround and contains wholly unrelated changes that are > unacceptable for use. Could you please clarify? Ebuild documentation is sparse and not centrally located, so I would appreciate if you could point out what unrelated changes you are referring to. I also don't see how this is an upstream issue; the upstream build instructions specify that the build directory be placed in the source directory and when doing so manually and when using my ebuild (which also follows these instructions) I encounter no issues. If there is a different way to relocate the build directory that I should be using please let me know. I've attached a reduced diff that complies with the upstream build instructions. (In reply to FlyingWaffle from comment #5) > Could you please clarify? Ebuild documentation is sparse and not centrally > located, so I would appreciate if you could point out what unrelated changes > you are referring to. It doesn't seem I need to clarify as you reduced the diff already yourself. src_configure() still looks redundant though. (In reply to FlyingWaffle from comment #5) > I also don't see how this is an upstream issue; If their build system relies on the exact directory placement one level below source dir then it is broken. It usually does not, as the ebuild has worked like that until very recently, as does *any* other kde.org hosted ECM based package. So the correct fix is to identify the breaking change, fix cmake, and submit it to upstream. Filed an upstream bug report; bug confirmed and fixed; tested emerge again with ebuild from 'kde' overlay, issue has been resolved! (Should I mark this as 'resolved fixed' or 'resolved upstream'?) (In reply to FlyingWaffle from comment #7) > Filed an upstream bug report; bug confirmed and fixed; tested emerge again > with ebuild from 'kde' overlay, issue has been resolved! Thank you very much! (In reply to FlyingWaffle from comment #7) > (Should I mark this as ... 'resolved upstream'?) Perfect. |
Created attachment 633418 [details] live ebuild for latte-dock Hello, I noticed that there is no live ebuild for kde-misc/latte-dock on the official overlay, and the one on the 'kde' overlay is broken, so I made my own! You can find the new ebuild attached. Let me know if I need to make any changes to it! -FlyingWaffle