| Summary: | app-emulation/virt-manager-2.2.1-r2 fails to build since recent distutils-r1.eclass change | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Candy Gumdrop <candy> |
| Component: | Current packages | Assignee: | Virtualization Team <virtualization> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | alexander, gentoo, gentoobugzilla, grknight, hubert.kromer, martin, vivo75 |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://bugs.gentoo.org/show_bug.cgi?id=717502 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
app-emulation/virt-manager-2.2.1-r2 build.log
Use "esetup.py install" instead of "esetup.py --skip-build install" |
||
|
Description
Candy Gumdrop
2020-04-17 11:42:15 UTC
Created attachment 633378 [details]
app-emulation/virt-manager-2.2.1-r2 build.log
Can confirm this behaviour also occurs on my system. Reverting the eclass file fixes the problem. I have just filed an additional bug for numpy that seems to have the same cause. bug 717906 Thanks for your research btw, Candy Gumdrop, it helped that you had already figured out the eclass file change triggered this bug. (and gave me a workaround for now) I'm also getting the same error. +1 thanks to Candy Gumdrop for research. Can confirm also having the same issue. Also confirmed that removing --skip-build from distutils-r1.eclass fixes the bug and allows it to build :) thanks @Candy Gumdrop (In reply to Bas Weelinck from comment #2) > Can confirm this behaviour also occurs on my system. Reverting the eclass > file fixes the problem. While it may revert to the old behavior, the package still needs to be updated to deal with it. 'esetup.py build' should happen at the right time and the log is showing is not currently. Same problem and solution (remove --skip-build) here. I believe the real solution is to change distutils-r1_python_compile to say python_configure. Is there a good reason why an 'esetup.py configure' step is in compile? This looks to be preventing virt-manager from building properly. diff --git a/app-emulation/virt-manager/virt-manager-2.2.1-r2.ebuild b/app-emulation/virt-manager/virt-manager-2.2.1-r2.ebuild
index ee09a0d573f..33a193d02c5 100644
--- a/app-emulation/virt-manager/virt-manager-2.2.1-r2.ebuild
+++ b/app-emulation/virt-manager/virt-manager-2.2.1-r2.ebuild
@@ -59,7 +59,7 @@ src_prepare() {
distutils-r1_src_prepare
}
-distutils-r1_python_compile() {
+python_configure() {
local defgraphics=
esetup.py configure \
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5ece5e2f1feb1b4ebafcb393af328662f0b9b051 commit 5ece5e2f1feb1b4ebafcb393af328662f0b9b051 Author: Matthias Maier <tamiko@gentoo.org> AuthorDate: 2020-04-18 21:54:52 +0000 Commit: Matthias Maier <tamiko@gentoo.org> CommitDate: 2020-04-18 22:05:43 +0000 app-emulation/qemu: stabilize amd64 and x86 wrt bug #717886 Bug: https://bugs.gentoo.org/717886 Package-Manager: Portage-2.3.99, Repoman-2.3.22 Signed-off-by: Matthias Maier <tamiko@gentoo.org> app-emulation/qemu/qemu-4.2.0-r5.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4358c8898d45e59fa3b16c72d67f4475d4851098 commit 4358c8898d45e59fa3b16c72d67f4475d4851098 Author: Matthias Maier <tamiko@gentoo.org> AuthorDate: 2020-04-19 00:31:41 +0000 Commit: Matthias Maier <tamiko@gentoo.org> CommitDate: 2020-04-19 00:31:41 +0000 app-emulation/virt-manager: fix configuration craziness Closes: https://bugs.gentoo.org/717886 Package-Manager: Portage-2.3.99, Repoman-2.3.22 Signed-off-by: Matthias Maier <tamiko@gentoo.org> app-emulation/virt-manager/virt-manager-2.2.1-r2.ebuild | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c4503933639bc86fe77621a9166a8b3b446a4aeb commit c4503933639bc86fe77621a9166a8b3b446a4aeb Author: Brian Evans <grknight@gentoo.org> AuthorDate: 2020-04-19 01:05:38 +0000 Commit: Brian Evans <grknight@gentoo.org> CommitDate: 2020-04-19 01:05:38 +0000 app-emulation/virt-manager: Apply fix from bug 717886 to live ebuild Non-maintainer commit Bug: https://bugs.gentoo.org/717886 Signed-off-by: Brian Evans <grknight@gentoo.org> app-emulation/virt-manager/virt-manager-9999.ebuild | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) And now ebuild doesn't install desktop entry, icons, translations and bash-completions. :( (In reply to Alexander Tsoy from comment #15) > And now ebuild doesn't install desktop entry, icons, translations and > bash-completions. :( Looks like data_files variable doesn't include these files if --skip-build is passed when installing. Created attachment 634294 [details, diff]
Use "esetup.py install" instead of "esetup.py --skip-build install"
Change in distutils-r1.eclass causes potfiles (translations) and .desktop file to not install due to --skip-build for 'esetup.py install' being used by default.
Adding:
python_install() {
esetup.py install
}
before pkg_preinst() fixed the issue for me.
Attaching "virt-manager-2.2.1-r2_po-desktop.patch".
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d4a208ec63b63b4d2960c7511965512a38fa84a8 commit d4a208ec63b63b4d2960c7511965512a38fa84a8 Author: Matthias Maier <tamiko@gentoo.org> AuthorDate: 2020-04-24 17:44:41 +0000 Commit: Matthias Maier <tamiko@gentoo.org> CommitDate: 2020-04-24 18:47:49 +0000 app-emulation/virt-manager: fix installation files Bug: https://bugs.gentoo.org/717886 Closes: https://bugs.gentoo.org/718670 Package-Manager: Portage-2.3.99, Repoman-2.3.22 Signed-off-by: Matthias Maier <tamiko@gentoo.org> .../{virt-manager-2.2.1-r2.ebuild => virt-manager-2.2.1-r3.ebuild} | 4 ++++ app-emulation/virt-manager/virt-manager-9999.ebuild | 4 ++++ 2 files changed, 8 insertions(+) |
