Bug 717680

Summary:	qt5-build.eclass does not respect CXX (WAS: dev-qt/qtxml calls directly g++)
Product:	Gentoo Linux	Reporter:	Agostino Sarubbo <ago>
Component:	Eclasses	Assignee:	Qt Bug Alias <qt>
Status:	CONFIRMED ---
Severity:	normal	CC:	asturm, johannes.geiss, kentnl, mgorny, pesa
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=726112
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:	649420
Bug Blocks:	243502
Attachments:	build.log qtbase-by-qt5-build.eclass.diff

Description Agostino Sarubbo gentoo-dev

2020-04-16 11:19:55 UTC

This is an auto-filled bug because dev-qt/qtxml calls directly g++. Attached build log and emerge --info

Comment 1 Agostino Sarubbo gentoo-dev

2020-04-16 11:20:02 UTC

Created attachment 633174 [details]
build.log

build log and emerge --info

Comment 2 Agostino Sarubbo gentoo-dev

2020-04-20 10:20:19 UTC

this is confirmed for all dev-qt/qt* packages not just qtxml

Comment 3 Agostino Sarubbo gentoo-dev

2020-04-27 07:18:08 UTC

I guess it is an eclass bug.

in qt5-build_src_prepare() there is:
# Respect CC, CXX, *FLAGS, MAKEOPTS and EXTRA_EMAKE when bootstrapping qmake
                sed -i -e "/outpath\/qmake\".*\"\$MAKE\")/ s|)| \
                        ${MAKEOPTS} ${EXTRA_EMAKE} 'CC=$(tc-getCC)' 'CXX=$(tc-getCXX)' \
                        'QMAKE_CFLAGS=${CFLAGS}' 'QMAKE_CXXFLAGS=${CXXFLAGS}' 'QMAKE_LFLAGS=${LDFLAGS}'&|" \
                        -e 's/\(setBootstrapVariable\s\+\|EXTRA_C\(XX\)\?FLAGS=.*\)QMAKE_C\(XX\)\?FLAGS_\(DEBUG\|RELEASE\).*/:/' \
                        configure || die "sed failed (respect env for qmake build)"


But in the practice it does not work at least for CXX/g++

Comment 4 Davide Pesavento (RETIRED) gentoo-dev

2020-05-29 06:24:23 UTC

*** Bug 725956 has been marked as a duplicate of this bug. ***

Comment 5 Andreas Sturmlechner gentoo-dev

2020-06-03 18:06:36 UTC

Created attachment 643294 [details, diff]
qtbase-by-qt5-build.eclass.diff

The above sed at least is still doing something in configure file - attaching diff that is the result of qt5-build_src_prepare on my system.

However, this one is a no-op:
> # Respect CXX in bsymbolic_functions, fvisibility, precomp, and a few other tests
> sed -i -e "/^QMAKE_CONF_COMPILER=/ s:=.*:=\"$(tc-getCXX)\":" \
> 	configure || die "sed failed (QMAKE_CONF_COMPILER)"

QMAKE_CONF_COMPILER var is gone since this commit:
https://github.com/qt/qtbase/commit/90eee08b3e672573e3ad93470d844e1d498651dd

Comment 6 Kent Fredric (IRC: kent\n) (RETIRED) gentoo-dev

2020-06-11 02:27:48 UTC

(In reply to Agostino Sarubbo from comment #2)
> this is confirmed for all dev-qt/qt* packages not just qtxml

It affects far more than just that too, and is currently the leading cause of tc-direct based failures on my rig.

Samples include:
* app-editors/tea
* app-mobilephone/qtadb
* media-video/baka-mplayer
* app-text/qpdfview

Comment 7 Davide Pesavento (RETIRED) gentoo-dev

2020-07-31 16:33:45 UTC

*** Bug 734860 has been marked as a duplicate of this bug. ***