|
Description
Michał Górny
2020-04-16 08:31:03 UTC
I may be interested in becoming the new maintainer for this package, so I had a look at open bugs. This one made me wonder what you consider a "fix"? https://github.com/pypa/pipenv/blob/master/setup.py lists quite a number of dependencies, plus upper-bound version limitations. It looks like changes would need to be made upstream, not in a Gentoo ebuild. (In reply to Ralph Seichter from comment #1) > I may be interested in becoming the new maintainer for this package, so I > had a look at open bugs. This one made me wonder what you consider a "fix"? > https://github.com/pypa/pipenv/blob/master/setup.py lists quite a number of > dependencies, plus upper-bound version limitations. It looks like changes > would need to be made upstream, not in a Gentoo ebuild. The fix would be unbundling these and using system versions. Often, these upper-bound version limitations are conservative or even wrong. But yes, it's possible some porting work would be needed to fix some and upstream those fixes. (I added you to CC because I'm replying now and it looks like you weren't in it before). This is in work. See related PR. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8e0be56464cc537990c3ae58a9f89cca081af059 commit 8e0be56464cc537990c3ae58a9f89cca081af059 Author: Oz N Tiram <oz.tiram@gmail.com> AuthorDate: 2021-07-23 22:01:14 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2021-08-03 07:09:49 +0000 dev-python/pipenv: remove vendored jinja2 and attr. Since pipenv bundles tons of packages, these will be removed in a slow pace. If no bugs are reported, the removal of bundled packages and addition of dependencies can continue. Bug: https://bugs.gentoo.org/717666 Signed-off-by: Oz N Tiram <oz.tiram@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/21828 Signed-off-by: Joonas Niilola <juippis@gentoo.org> ...nv-2021-5-29-r1-remove-attr-vendor-import.patch | 95 ++++++++++++++++++++++ dev-python/pipenv/pipenv-2021.5.29-r1.ebuild | 54 ++++++++++++ 2 files changed, 149 insertions(+) Unbundling attr seems to have broken my installation of pipenv:
$ pipenv --version
Traceback (most recent call last):
File "/usr/lib/python-exec/python3.9/pipenv", line 33, in <module>
sys.exit(load_entry_point('pipenv==2021.5.29', 'console_scripts', 'pipenv')())
File "/usr/lib/python3.9/site-packages/pipenv/vendor/click/core.py", line 829, in __call__
return self.main(*args, **kwargs)
File "/usr/lib/python3.9/site-packages/pipenv/vendor/click/core.py", line 781, in main
with self.make_context(prog_name, args, **extra) as ctx:
File "/usr/lib/python3.9/site-packages/pipenv/vendor/click/core.py", line 700, in make_context
self.parse_args(ctx, args)
File "/usr/lib/python3.9/site-packages/pipenv/vendor/click/core.py", line 1212, in parse_args
rest = Command.parse_args(self, ctx, args)
File "/usr/lib/python3.9/site-packages/pipenv/vendor/click/core.py", line 1044, in parse_args
parser = self.make_parser(ctx)
File "/usr/lib/python3.9/site-packages/pipenv/vendor/click/core.py", line 965, in make_parser
for param in self.get_params(ctx):
File "/usr/lib/python3.9/site-packages/pipenv/vendor/click/core.py", line 912, in get_params
help_option = self.get_help_option(ctx)
File "/usr/lib/python3.9/site-packages/pipenv/cli/options.py", line 27, in get_help_option
from ..core import format_help
File "/usr/lib/python3.9/site-packages/pipenv/core.py", line 33, in <module>
from .project import Project
File "/usr/lib/python3.9/site-packages/pipenv/project.py", line 30, in <module>
from .vendor.requirementslib.models.utils import get_default_pyproject_backend
File "/usr/lib/python3.9/site-packages/pipenv/vendor/requirementslib/__init__.py", line 9, in <module>
from .models.lockfile import Lockfile
File "/usr/lib/python3.9/site-packages/pipenv/vendor/requirementslib/models/lockfile.py", line 8, in <module>
import attr
ModuleNotFoundError: No module named 'attr'
Hi Herman, Thank you for the report. Yes, you are right. This was dumb. Removing attr and not adding as explicit dependency breaks it. So, the next step is: add the following explicit dependencies: 1. attr 2. jinja2 3. yaml Completely remove yaml. For each vendor package removed, explicitly add gentoo ebuild dependency. I will attend to it asap. In order for me to close this bug, I will need to add a few packages to the main gentoo repository, skipping guru. I will also search if some of those already exist in guru, and if so, I can ask here to promote them to the main repo. @juppis will you approve such process? (In reply to OzTiram from comment #7) > In order for me to close this bug, I will need to add a few packages to the > main gentoo repository, skipping guru. > > I will also search if some of those already exist in guru, and if so, I can > ask here to promote them to the main repo. > > > @juppis will you approve such process? Please go for it, unless we're talking about hundreds of packages here. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6f583f0ebf698afcd5cc227f00aae83837f4047c commit 6f583f0ebf698afcd5cc227f00aae83837f4047c Author: Oz N Tiram <oz.tiram@gmail.com> AuthorDate: 2021-08-10 08:34:49 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2021-08-18 13:33:16 +0000 dev-python/pipenv: bump rev-2 * Disable py3.7 * Fix attr->attrs Signed-off-by: Oz N Tiram <oz.tiram@gmail.com> Bug: https://bugs.gentoo.org/show_bug.cgi?id=717666 Closes: https://github.com/gentoo/gentoo/pull/21925 Signed-off-by: Joonas Niilola <juippis@gentoo.org> ...v-2021-5-29-r2-remove-attr-vendor-import.patch} | 0 ...21-5-29-r2-remove-colorama-vendor-import.patch} | 0 dev-python/pipenv/pipenv-2021.5.29-r2.ebuild | 61 ++++++++++++++++++++++ 3 files changed, 61 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=7d2579a842be44fd0d4ed5fe50c37820d2344348 commit 7d2579a842be44fd0d4ed5fe50c37820d2344348 Author: Oz N Tiram <oz.tiram@gmail.com> AuthorDate: 2021-08-09 11:40:29 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2021-08-18 13:33:15 +0000 dev-python/pipenv: fixed vendored packages * Fix missing deps on jinja and attr * Remove vendored colorama, add dep on system colorama * Enable Python-3.10 Signed-off-by: Oz N Tiram <oz.tiram@gmail.com> Bug: https://bugs.gentoo.org/show_bug.cgi?id=717666 Signed-off-by: Joonas Niilola <juippis@gentoo.org> ...nv-2021-5-29-r1-remove-colorama-vendor-import.patch | 18 ++++++++++++++++++ dev-python/pipenv/pipenv-2021.5.29-r1.ebuild | 11 +++++++++-- 2 files changed, 27 insertions(+), 2 deletions(-) Status update: The latest version[1] of pipenv removes 5 bundeled packages (out of 42 in total). I hope to remove even larger amount of packages in the next version. [1]: https://github.com/gentoo/gentoo/pull/22900#issuecomment-966285556 dev-python/pipenv-2022.1.8 fails to work as it seems the vendored tomlkit has been removed but not dep added. furthermore even with dev-python/tomlkit installed it fails with:
Traceback (most recent call last):
File "/usr/lib/python-exec/python3.9/pipenv", line 33, in <module>
sys.exit(load_entry_point('pipenv==2022.1.8', 'console_scripts', 'pipenv')())
File "/usr/lib/python-exec/python3.9/pipenv", line 25, in importlib_load_entry_point
return next(matches).load()
File "/usr/lib/python3.9/importlib/metadata.py", line 77, in load
module = import_module(match.group('module'))
File "/usr/lib/python3.9/importlib/__init__.py", line 127, in import_module
return _bootstrap._gcd_import(name[level:], package, level)
File "<frozen importlib._bootstrap>", line 1030, in _gcd_import
File "<frozen importlib._bootstrap>", line 1007, in _find_and_load
File "<frozen importlib._bootstrap>", line 986, in _find_and_load_unlocked
File "<frozen importlib._bootstrap>", line 680, in _load_unlocked
File "<frozen importlib._bootstrap_external>", line 850, in exec_module
File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
File "/usr/lib/python3.9/site-packages/pipenv/__init__.py", line 57, in <module>
from .cli import cli
File "/usr/lib/python3.9/site-packages/pipenv/cli/__init__.py", line 1, in <module>
from .command import cli # noqa
File "/usr/lib/python3.9/site-packages/pipenv/cli/command.py", line 7, in <module>
from pipenv.cli.options import (
File "/usr/lib/python3.9/site-packages/pipenv/cli/options.py", line 3, in <module>
from pipenv.project import Project
File "/usr/lib/python3.9/site-packages/pipenv/project.py", line 32, in <module>
from pipenv.vendor.requirementslib.models.utils import (
File "/usr/lib/python3.9/site-packages/pipenv/vendor/requirementslib/__init__.py", line 7, in <module>
from .models.lockfile import Lockfile
File "/usr/lib/python3.9/site-packages/pipenv/vendor/requirementslib/models/lockfile.py", line 11, in <module>
import plette.lockfiles
File "/usr/lib/python3.9/site-packages/pipenv/vendor/plette/__init__.py", line 9, in <module>
from .pipfiles import Pipfile
File "/usr/lib/python3.9/site-packages/pipenv/vendor/plette/pipfiles.py", line 7, in <module>
import pipenv.vendor.tomlkit as tomlkit
ModuleNotFoundError: No module named 'pipenv.vendor.tomlkit'
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6b5cc781fd30d0135530115bbd5adf7256d644f1 commit 6b5cc781fd30d0135530115bbd5adf7256d644f1 Author: Oz N Tiram <oz.tiram@gmail.com> AuthorDate: 2022-01-17 14:26:34 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-01-18 12:34:51 +0000 dev-python/pipenv: retain tomlkit in v2022.1.8 Bug: https://bugs.gentoo.org/831101 Bug: https://bugs.gentoo.org/717666 Signed-off-by: Oz N Tiram <oz.tiram@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/23840 Signed-off-by: Sam James <sam@gentoo.org> dev-python/pipenv/pipenv-2022.1.8.ebuild | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=334b247fd906fff1faa59d1e6e838b18f9b335ee commit 334b247fd906fff1faa59d1e6e838b18f9b335ee Author: Oz N Tiram <oz.tiram@gmail.com> AuthorDate: 2022-04-11 21:57:14 +0000 Commit: Arthur Zamarin <arthurzam@gentoo.org> CommitDate: 2022-04-19 05:56:11 +0000 dev-python/pipenv: add 2022.4.8 Also, removed vendored click and iso8601 Signed-off-by: Oz N Tiram <oz.tiram@gmail.com> Bug: https://bugs.gentoo.org/717666 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org> dev-python/pipenv/Manifest | 1 + dev-python/pipenv/pipenv-2022.4.8.ebuild | 90 ++++++++++++++++++++++++++++++++ 2 files changed, 91 insertions(+) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9f06b8a545c21dd54687c67f2560eb7b02ebae70 commit 9f06b8a545c21dd54687c67f2560eb7b02ebae70 Author: Oz N Tiram <oz.tiram@gmail.com> AuthorDate: 2022-06-27 14:11:45 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2022-07-05 08:52:01 +0000 dev-python/pipenv: drop more vendored packages Bug: https://bugs.gentoo.org/717666 Closes: https://github.com/gentoo/gentoo/pull/26092 Signed-off-by: Oz N Tiram <oz.tiram@gmail.com> Signed-off-by: Joonas Niilola <juippis@gentoo.org> dev-python/pipenv/pipenv-2022.6.7-r1.ebuild | 93 +++++++++++++++++++++++++++++ 1 file changed, 93 insertions(+) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f67dfdc56c09318b6acf797a9927fb1660e46463 commit f67dfdc56c09318b6acf797a9927fb1660e46463 Author: Oz N Tiram <oz.tiram@gmail.com> AuthorDate: 2022-08-06 09:40:16 +0000 Commit: Arthur Zamarin <arthurzam@gentoo.org> CommitDate: 2022-09-09 07:22:57 +0000 dev-python/pipenv: drop 2022.6.7 Signed-off-by: Oz N Tiram <oz.tiram@gmail.com> Bug: https://bugs.gentoo.org/717666 Closes: https://github.com/gentoo/gentoo/pull/26757 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org> dev-python/pipenv/pipenv-2022.6.7.ebuild | 89 -------------------------------- dev-python/pipenv/pipenv-2022.8.5.ebuild | 3 +- 2 files changed, 2 insertions(+), 90 deletions(-) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=74c9d4414528f48c7ec8f910ec9f5a13da591c85 commit 74c9d4414528f48c7ec8f910ec9f5a13da591c85 Author: Oz N Tiram <oz.tiram@gmail.com> AuthorDate: 2022-08-06 09:39:21 +0000 Commit: Arthur Zamarin <arthurzam@gentoo.org> CommitDate: 2022-09-09 07:22:56 +0000 dev-python/pipenv: add 2022.8.5 This versions continues the removal of bundeled packages. The removal of bundeled packages is now being done upstream. This release (and previous releases not included in gentoo) removes the following packages compared to the latest version which was delievered in gentoo: * funcsigs * yaml * crayons * certify * charset-normalizer * importlib-metadata * importlib-resources * packaging * urllib3 Bug: https://bugs.gentoo.org/717666 Signed-off-by: Oz N Tiram <oz.tiram@gmail.com> Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org> dev-python/pipenv/Manifest | 1 + dev-python/pipenv/pipenv-2022.8.5.ebuild | 90 ++++++++++++++++++++++++++++++++ 2 files changed, 91 insertions(+) When this bug was first opened, pipenv has 58 packages vendored. The current upstream version has now only 30 package, and I am in the process of cleaning even more. The goal is to get down only to a handful (5-10) essential packages which are really needed for pipenv to work. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=03b9a32a3f6594216faee6c1952e0f9a6de2aec0 commit 03b9a32a3f6594216faee6c1952e0f9a6de2aec0 Author: Oz N Tiram <oz.tiram@gmail.com> AuthorDate: 2022-10-02 07:46:39 +0000 Commit: Arthur Zamarin <arthurzam@gentoo.org> CommitDate: 2022-10-02 18:54:22 +0000 dev-python/pipenv: add 2022.9.24 Signed-off-by: Oz N Tiram <oz.tiram@gmail.com> Bug: https://bugs.gentoo.org/717666 Closes: https://github.com/gentoo/gentoo/pull/27570 Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org> dev-python/pipenv/Manifest | 1 + dev-python/pipenv/pipenv-2022.9.24.ebuild | 88 +++++++++++++++++++++++++++++++ 2 files changed, 89 insertions(+) Created attachment 821725 [details]
colorama exception
dev-python/pipenv-2022.9.24 tries to import colorama from vendor and fails Thanks for your bug report! I submitted a patch to fix this issue. Can you check that it works for you? I was also affected by the colorama import failure in version 2022.9.24 and can confirm that the patch from https://github.com/gentoo/gentoo/pull/27661 fixes the issue. The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6939a1be7ec70c66ea2b17800dde3007bb1d5ea0 commit 6939a1be7ec70c66ea2b17800dde3007bb1d5ea0 Author: Oz N Tiram <oz.tiram@gmail.com> AuthorDate: 2022-10-06 10:58:06 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2022-10-09 16:34:28 +0000 dev-python/pipenv: fix import errors Bug: https://bugs.gentoo.org/717666 Signed-off-by: Oz N Tiram <oz.tiram@gmail.com> Signed-off-by: Joonas Niilola <juippis@gentoo.org> .../pipenv-2022.9.24-inject-site-packages.patch | 34 ++++++++++++++++++++++ 1 file changed, 34 insertions(+) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8d0955461b1f3cd6099b5ddbe20ccc6aea4f8c85 commit 8d0955461b1f3cd6099b5ddbe20ccc6aea4f8c85 Author: Oz Tiram <oz.tiram@gmail.com> AuthorDate: 2022-12-03 19:34:20 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-12-24 06:57:15 +0000 dev-python/pipenv: add 2022.11.30 This commit bumps the version and removes more packages from the vendor directory, as many were also removed upstream. Bug: https://bugs.gentoo.org/717666 Signed-off-by: Oz Tiram <oz.tiram@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/28530 Signed-off-by: Sam James <sam@gentoo.org> dev-python/pipenv/Manifest | 1 + dev-python/pipenv/pipenv-2022.11.30.ebuild | 111 +++++++++++++++++++++++++++++ 2 files changed, 112 insertions(+) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ed8eae40ef3f3603e4b10fed037f3624f68e5704 commit ed8eae40ef3f3603e4b10fed037f3624f68e5704 Author: Oz Tiram <oz.tiram@gmail.com> AuthorDate: 2023-08-17 21:37:47 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2023-09-16 07:57:14 +0000 dev-python/pipenv: update dependencies Remove 2 more vendored libs. Bug: https://bugs.gentoo.org/717666 Signed-off-by: Oz Tiram <oz.tiram@gmail.com> Signed-off-by: Joonas Niilola <juippis@gentoo.org> dev-python/pipenv/pipenv-2023.7.11-r1.ebuild | 111 +++++++++++++++++++++++++++ 1 file changed, 111 insertions(+) The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b7d00239ce93b213031e3b716b42522d4cdd40a1 commit b7d00239ce93b213031e3b716b42522d4cdd40a1 Author: Oz Tiram <oz.tiram@gmail.com> AuthorDate: 2023-09-24 07:52:11 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-10-27 03:23:50 +0000 dev-python/pipenv: add 2023.9.8 Bug: https://bugs.gentoo.org/717666 Signed-off-by: Oz Tiram <oz.tiram@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> dev-python/pipenv/Manifest | 1 + ...8-append-always-install-to-pip-extra-args.patch | 34 ++++++ .../pipenv-2023.9.8-inject-system-packages.patch | 53 +++++++++ dev-python/pipenv/pipenv-2023.9.8.ebuild | 124 +++++++++++++++++++++ 4 files changed, 212 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c08a863d029313452112eead80c32cb796026336 commit c08a863d029313452112eead80c32cb796026336 Author: Oz Tiram <oz.tiram@gmail.com> AuthorDate: 2023-09-24 07:49:12 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-10-27 03:23:49 +0000 dev-python/dparse: new package, add 0.6.3 Bug: https://bugs.gentoo.org/717666 Signed-off-by: Oz Tiram <oz.tiram@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> dev-python/dparse/Manifest | 1 + dev-python/dparse/dparse-0.6.3.ebuild | 21 +++++++++++++++++++++ dev-python/dparse/metadata.xml | 17 +++++++++++++++++ 3 files changed, 39 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=87ef56aa40ff9edfea89a3a90a87a146c55f8ec9 commit 87ef56aa40ff9edfea89a3a90a87a146c55f8ec9 Author: Oz Tiram <oz.tiram@gmail.com> AuthorDate: 2023-09-24 07:49:04 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-10-27 03:23:49 +0000 dev-python/pipdeptree: new package, add 2.13.0 Bug: https://bugs.gentoo.org/717666 Signed-off-by: Oz Tiram <oz.tiram@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> dev-python/pipdeptree/Manifest | 1 + dev-python/pipdeptree/metadata.xml | 17 +++++++++++++++++ dev-python/pipdeptree/pipdeptree-2.13.0.ebuild | 21 +++++++++++++++++++++ 3 files changed, 39 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0b2aad9a07254ceda2be46802c3d0fabc14144a7 commit 0b2aad9a07254ceda2be46802c3d0fabc14144a7 Author: Oz Tiram <oz.tiram@gmail.com> AuthorDate: 2023-09-24 07:48:59 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-10-27 03:23:49 +0000 dev-python/plette: new package, add 0.4.4 Bug: https://bugs.gentoo.org/717666 Signed-off-by: Oz Tiram <oz.tiram@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> dev-python/plette/Manifest | 1 + dev-python/plette/metadata.xml | 17 +++++++++++++++++ dev-python/plette/plette-0.4.4.ebuild | 25 +++++++++++++++++++++++++ 3 files changed, 43 insertions(+) https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=263602cf4bcce73ca6b0b02aa3ba4904274f9fd0 commit 263602cf4bcce73ca6b0b02aa3ba4904274f9fd0 Author: Oz Tiram <oz.tiram@gmail.com> AuthorDate: 2023-09-24 07:46:51 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2023-10-27 03:23:49 +0000 dev-python/pythonfinder: new package, add 2.0.5 Bug: https://bugs.gentoo.org/717666 Signed-off-by: Oz Tiram <oz.tiram@gmail.com> Signed-off-by: Sam James <sam@gentoo.org> dev-python/pythonfinder/Manifest | 1 + .../files/2.0.5-fix-import-cached-property.patch | 13 ++++++++++ dev-python/pythonfinder/metadata.xml | 17 +++++++++++++ dev-python/pythonfinder/pythonfinder-2.0.5.ebuild | 29 ++++++++++++++++++++++ 4 files changed, 60 insertions(+) Fixed. Wow, thanks for this massive undertaking :) |