Bug 716730 – www-client/seamonkey-2.53.1 ignores -O from CFLAGS

• Product: Gentoo Linux
• Status: UNCONFIRMED ---

[Description kavol 2020-04-08 21:03:54 UTC]

On Seamonkey update, I have noticed that it is being compiled with "-O2" instead of "-Os" as I have defined in my CFLAGS/CXXFLAGS.

BTW, in the example below, note also that "-pipe" is being passed twice. And note also that "-g" is being added without me asking to have debuginfo in any way. (I can just hope that it is being stripped later as I don't have "nostrip" in FEATURES, but then again, why it should be added in the first place? - Your docs at https://wiki.gentoo.org/wiki/Debugging advise to add "-ggdb" explicitly, so why the build adds "-g" silently?)

Reproducible: Always

Steps to Reproduce:
1. echo -e CFLAGS=\"-march=native -Os -pipe\"\\nCXXFLAGS=\"\${CFLAGS}\" >> /etc/portage/make.conf
2. emerge seamonkey

Actual Results:  
...
/usr/lib64/ccache/bin/x86_64-pc-linux-gnu-gcc -std=gnu99 -o Unified_c_media_libopus7.o -c -I/var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/seamonk/dist/system_wrappers -include /var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/mozilla/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOPUS_BUILD '-DOPUS_VERSION="v1.2.1-mozilla"' -DUSE_ALLOCA -DOPUS_EXPORT= -DHAVE_LRINTF -DOPUS_HAVE_RTCD -DOPUS_X86_MAY_HAVE_SSE -DOPUS_X86_MAY_HAVE_SSE2 -DOPUS_X86_MAY_HAVE_SSE4_1 -DOPUS_X86_MAY_HAVE_AVX -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/mozilla/media/libopus -I/var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/seamonk/media/libopus -I/var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/mozilla/media/libopus/celt -I/var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/mozilla/media/libopus/include -I/var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/mozilla/media/libopus/silk -I/var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/mozilla/media/libopus/src -I/var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/mozilla/media/libopus/silk/float -I/var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/seamonk/dist/include -I/usr/include/nspr -I/usr/include/nss -I/var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/seamonk/dist/include/nss -fPIC -include /var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/seamonk/mozilla-config.h -DMOZILLA_CLIENT -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -Wformat-security -Wformat-overflow=2 -march=native -pipe -mno-avx -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-math-errno -pthread -pipe -g -freorder-blocks -O2 -fomit-frame-pointer   -MD -MP -MF .deps/Unified_c_media_libopus7.o.pp   /var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/seamonk/media/libopus/Unified_c_media_libopus7.c
...

Expected Results:  
...
/usr/lib64/ccache/bin/x86_64-pc-linux-gnu-gcc -std=gnu99 -o Unified_c_media_libopus7.o -c -I/var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/seamonk/dist/system_wrappers -include /var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/mozilla/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOPUS_BUILD '-DOPUS_VERSION="v1.2.1-mozilla"' -DUSE_ALLOCA -DOPUS_EXPORT= -DHAVE_LRINTF -DOPUS_HAVE_RTCD -DOPUS_X86_MAY_HAVE_SSE -DOPUS_X86_MAY_HAVE_SSE2 -DOPUS_X86_MAY_HAVE_SSE4_1 -DOPUS_X86_MAY_HAVE_AVX -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/mozilla/media/libopus -I/var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/seamonk/media/libopus -I/var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/mozilla/media/libopus/celt -I/var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/mozilla/media/libopus/include -I/var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/mozilla/media/libopus/silk -I/var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/mozilla/media/libopus/src -I/var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/mozilla/media/libopus/silk/float -I/var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/seamonk/dist/include -I/usr/include/nspr -I/usr/include/nss -I/var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/seamonk/dist/include/nss -fPIC -include /var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/seamonk/mozilla-config.h -DMOZILLA_CLIENT -Wall -Wempty-body -Wignored-qualifiers -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=free-nonheap-object -Wformat -Wformat-security -Wformat-overflow=2 -march=native -pipe -mno-avx -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fomit-frame-pointer   -MD -MP -MF .deps/Unified_c_media_libopus7.o.pp   /var/tmp/portage/www-client/seamonkey-2.53.1/work/seamonkey-2.53.1/seamonk/media/libopus/Unified_c_media_libopus7.c
...

# emerge --info
Portage 2.3.89 (python 3.6.10-final-0, default/linux/amd64/17.0/desktop/plasma, gcc-9.2.0, glibc-2.29-r7, 4.19.97-gentoo x86_64)
=================================================================
System uname: Linux-4.19.97-gentoo-x86_64-Intel-R-_Pentium-R-_CPU_B960_@_2.20GHz-with-gentoo-2.6
KiB Mem:     3954888 total,     46636 free
KiB Swap:    8393924 total,   7923908 free
Timestamp of repository gentoo: Wed, 08 Apr 2020 10:30:01 +0000
Head commit of repository gentoo: 569a7cb42ae38657cc8d312daeeeb48735087b0a
sh bash 4.4_p23-r1
ld GNU ld (Gentoo 2.33.1 p2) 2.33.1
ccache version 3.7.7 [enabled]
app-shells/bash:          4.4_p23-r1::gentoo
dev-lang/perl:            5.30.1::gentoo
dev-lang/python:          2.7.17-r2::gentoo, 3.6.10-r1::gentoo, 3.7.7-r1::gentoo
dev-util/ccache:          3.7.7-r1::gentoo
dev-util/cmake:           3.16.5::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.6-r1::gentoo
sys-apps/openrc:          0.42.1::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.13.4-r2::gentoo, 1.15.1-r2::gentoo, 1.16.1-r1::gentoo
sys-devel/binutils:       2.33.1-r1::gentoo
sys-devel/gcc:            9.2.0-r2::gentoo
sys-devel/gcc-config:     2.2.1::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 5.4::gentoo (virtual/os-headers)
sys-libs/glibc:           2.29-r7::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts: 
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-metamanifest: no
    sync-rsync-verify-max-age: 24

x-portage
    location: /usr/local/portage
    masters: gentoo
    priority: 0

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="@FREE OPERA-12"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -Os -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=native -Os -pipe"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs ccache config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="cs_CZ.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="cs cs_CZ en sk sk_SK"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acpi alsa amd64 berkdb bluetooth branding bzip2 cairo cdda cdr cli crypt cups dbus declarative dpi dri dts dvd dvdr elogind emboss encode exif extraengine fftw firmware flac fortran gdbm geo gif gimp gpg gpm iconv icu ipv6 jingle jpeg kde kdepim kipi kwallet lcms libnotify libtirpc mad mng mod modplug mp3 mp4 mpeg mtp music ncurses nls nptl ogg opengl openmp openssl pam pango pcre pcre16 pdf phonon pim plasma pm-utils png policykit postproc ppds python qml qt5 readline scanner sdl seccomp semantic-desktop sound spell split-usr sqlite ssl startup-notification svg symlink system-libvpx tcpd threads tiff truetype udev udisks unicode upnp upower usb v4l vaapi video vorbis widgets wifi wxwidgets x264 x265 xcb xcomposite xml xv xvid zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput keyboard mouse" KERNEL="linux" L10N="cs en sk" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" RUBY_TARGETS="ruby24 ruby25" USERLAND="GNU" VIDEO_CARDS="intel i965" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 1 Lars Wendler (Polynomial-C) (RETIRED) 2021-05-04 07:14:53 UTC]

Well, your -Os not appearing in the compile output is a result of mozcoreconf-v6.eclass filtering all -O options:

  https://gitweb.gentoo.org/repo/gentoo.git/tree/eclass/mozcoreconf-v6.eclass#n206

I'm still investigating regarding the -g flag.

[Comment 2 kavol 2021-05-04 19:05:37 UTC]

(In reply to Lars Wendler (Polynomial-C) from comment #1)
> Well, your -Os not appearing in the compile output is a result of
> mozcoreconf-v6.eclass filtering all -O options:
> 
>  
> https://gitweb.gentoo.org/repo/gentoo.git/tree/eclass/mozcoreconf-v6.
> eclass#n206
> 
> I'm still investigating regarding the -g flag.

thanks for looking, but the question is why?

no comment in the code ... does it break with anything else then O2?

- I have quite good experiences with Os, no hard data, but subjectively, all machines with 4 GB RAM (all = 2 old laptops :-)) where I have changed O2 to Os feel a bit more responsive (well, hell of a lot more responsive compared to Fedora ... ~110 MiB vs ~400 MiB used RAM at login screen)

so I would like if it worked for all the software; also, if it can't work and the ebuild (or eclass) needs to change it, it would be nice to issue a warning