Summary: | games-fps/sauerbraten-9999 live ebuild | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | brankob |
Component: | Current packages | Assignee: | Gentoo Games <games> |
Status: | RESOLVED NEEDINFO | ||
Severity: | normal | CC: | jstein, sam |
Priority: | Normal | Keywords: | EBUILD |
Version: | unspecified | ||
Hardware: | AMD64 | ||
OS: | Linux | ||
See Also: | https://bugs.gentoo.org/show_bug.cgi?id=706308 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
new ebuild
new version ( without games eclass) |
Description
brankob
2020-04-07 09:42:47 UTC
Created attachment 631082 [details]
new ebuild
Thank you for your contribution. I had a short look on the ebuild. Here a few ideas: * can't you use a specific commit instead a 9999? It will less often break. * Please test the ebuild with repoman full -d -x https://wiki.gentoo.org/wiki/Repoman and pkgcheck * We always try to use the latest EAPI, please bump to EAPI=7 * Please remove obsolete lines * remove KEYWORDS for 9999 * please fix the header. (see /usr/portage/skel.ebuild and https://devmanual.gentoo.org/ebuild-writing/eapi/) * A bot can look for additional mistakes, if you upload a PR via github * We can help you on IRC #gentoo-dev-help to improve the ebuild, if you got stuck. I know about that version. That too is old. I've used it until recently. But htat version still doessn't work with Wayland - it still uses SDL1. Meanwhile, current latest svn stuff works great with wayland. I've corrreected the ebuild ( thrown outr games eclass stuff, but have a few snags left. Will upload it shortly... (In reply to Branko Badrljica from comment #3) > I know about that version. That too is old. > I've used it until recently. > > But htat version still doessn't work with Wayland - it still uses SDL1. > > Meanwhile, current latest svn stuff works great with wayland. > > I've corrreected the ebuild ( thrown outr games eclass stuff, but have a > few snags left. Will upload it shortly... https://github.com/gentoo/gentoo/pull/19820 Remove games.eclass Created attachment 693813 [details]
new version ( without games eclass)
prablably couple other changes done , too.
This is latest version that I'm using.
If it's still relevant, I'd appreciate you posting the patch in git format-patch format or as a GitHub PR. Either way, can you include the GCO sign off in a comment? (In reply to Sam James from comment #6) > If it's still relevant, I'd appreciate you posting the patch in git > format-patch format or as a GitHub PR. Either way, can you include the GCO > sign off in a comment? I posted this because I worked on this package when fixing all the games.eclass consumers, but I appreciate it’s been a while. I’ve bumped for bug 759535. Please reopen if you are still bothered about a live ebuild. Not sure if we really need one. |