|Summary:||net-vpn/networkmanager-l2tp: support nls, glib flags and more|
|Product:||Gentoo Linux||Reporter:||Alexander Kurakin <kuraga333>|
|Component:||Current packages||Assignee:||Piotr Karbowski <slashbeast>|
|Severity:||normal||CC:||alexander, alexxy, kuraga333, leio|
|Package list:||Runtime testing required:||---|
Description Alexander Kurakin 2020-04-04 18:41:01 UTC
I see `--enable-nls` option in `./configure --help`. So let's add `nls` flag support?
Comment 1 Alexander Kurakin 2020-04-04 18:52:59 UTC
Well, `--with-libnm-glib` option, also (`glib` flag).
Comment 2 Alexander Kurakin 2020-04-04 18:55:58 UTC
Also, I see --disable-more-warnings --with-dist-version=Gentoo in a neighbor https://gitweb.gentoo.org/repo/gentoo.git/tree/net-vpn/networkmanager-libreswan/networkmanager-libreswan-1.2.12.ebuild which are acceptable by networkmanager-l2tp's `./configure`.
Comment 3 Mart Raudsepp 2020-04-04 19:26:05 UTC
Providing an option for nls makes no sense. Some of the rest seem relevant, especially explicitly forcing off libnm-glib with --without-libnm-glib feels appropriate to ensure things are good with the p.masked networkmanager
Comment 4 Douglas Kosovic 2021-09-27 22:46:04 UTC
I'm pretty certain `--with-dist-version=Gentoo` is incorrect and not a good idea, here are some examples from other Linux distribution for NetworkManager-l2tp-1.8.6 : Fedora 35 : --with-dist-version=1.8.6-1.f35 Ubuntu 20.04 : --with-dist-version=1.8.6-1~ubuntu20.04.1 So basically `--with-dist-version` is intended to have the software version number and the linux distribution's revision number of the package. I vaguely remember `--disable-more-warnings` was required a long time ago to successfully build the NetworkManager VPN clients on 32bit platforms when used in combination with -Werror, but that issue was fixed ages ago. Regarding `--with-libnm-glib` / `--without-libnm-glib`, extract from the NEWS file for NetworkManager 1.20 : https://cgit.freedesktop.org/NetworkManager/NetworkManager/tree/NEWS * The libnm-glib library, deprecated in favor of libnm since NetworkManager 1.0, and disabled by default since NetworkManager 1.12, has now been removed. The majority of VPN clients now have `--without-libnm-glib` as their default. libnm-glib code will most likely eventually get removed from the VPN clients. Explicitly using `--without-libnm-glib` might make some sense, but `--with-libnm-glib` definitely doesn't.