Summary: | net-misc/netkit-telnetd-0.17-r12 : * (no error message) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | Gentoo musl team <musl> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | joakim.tjernlund, paolo.pedroni, proxy-maint, stefan |
Priority: | Normal | Keywords: | PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/18412 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 685160 | ||
Attachments: |
emerge-info.txt
emerge-history.txt environment etc.portage.tbz2 net-misc:netkit-telnetd-0.17-r12:20200401-023546.log temp.tbz2 Make logwtmp optional Possible __environ fix |
Description
Toralf Förster
2020-04-01 07:12:19 UTC
Created attachment 628276 [details]
emerge-info.txt
Created attachment 628278 [details]
emerge-history.txt
Created attachment 628280 [details]
environment
Created attachment 628282 [details]
etc.portage.tbz2
Created attachment 628284 [details]
net-misc:netkit-telnetd-0.17-r12:20200401-023546.log
Created attachment 628286 [details]
temp.tbz2
I can't reproduce... Checking for snprintf declaration... ok Checking for snprintf implementation... ok Generating MCONFIG... sed: -e expression #1, char 103: unknown option to `s' * ERROR: net-misc/netkit-telnetd-0.17-r12::gentoo failed (configure phase): * (no error message) * * Call stack: * ebuild.sh, line 125: Called src_configure * environment, line 1044: Called die * The specific snippet of code: * sed -i -e "s/-pipe -O2/${CFLAGS}/" -e "s/^\(LDFLAGS=\).*/\1${LDFLAGS}/" -e "s/-Wpointer-arith//" MCONFIG || die Created attachment 674341 [details, diff]
Make logwtmp optional
The configure script exits if logwtmp is not found (musl has no utmp/wtmp functionality), in which case MCONFIG is not generated.
This patch makes logwtmp support optional by conditionally excluding the offending code.
Created attachment 674344 [details, diff]
Possible __environ fix
Another build failure on musl:
x86_64-gentoo-linux-musl-gcc -march=native -O2 -pipe -fomit-frame-pointer -O2 -Wall -Wno-trigraphs '-DISSUE_FILE="/etc/issue.net"' -DPARANOID_TTYS -DNO_LOGWTMP -DNO_REVOKE -DKLUDGELINEMODE -DDIAGNOSTICS -DLOGIN_WRAPPER=\"/usr/sbin/telnetlogin\" -D_GNU_SOURCE setproctitle.c -c
setproctitle.c:89:2: error: '__environ' undeclared (first use in this function); did you mean 'environ'?
89 | __environ = (char **) malloc(sizeof (char *) * (i + 1));
| ^~~~~~~~~
| environ
The attached patch fixes this compilation error (by replacing "__environ" with "environ"), but since I'm not really a C developer, it may not do what it's supposed to.
(In reply to Joakim Tjernlund from comment #8) > Checking for snprintf declaration... ok > Checking for snprintf implementation... ok > Generating MCONFIG... > sed: -e expression #1, char 103: unknown option to `s' > * ERROR: net-misc/netkit-telnetd-0.17-r12::gentoo failed (configure phase): > * (no error message) > * > * Call stack: > * ebuild.sh, line 125: Called src_configure > * environment, line 1044: Called die > * The specific snippet of code: > * sed -i -e "s/-pipe -O2/${CFLAGS}/" -e > "s/^\(LDFLAGS=\).*/\1${LDFLAGS}/" -e "s/-Wpointer-arith//" MCONFIG || die This error seems unrelated to the bug. What's the value of your CFLAGS and LDFLAGS environment variables? (In reply to Stefan Michelsson from comment #11) > (In reply to Joakim Tjernlund from comment #8) > > Checking for snprintf declaration... ok > > Checking for snprintf implementation... ok > > Generating MCONFIG... > > sed: -e expression #1, char 103: unknown option to `s' > > * ERROR: net-misc/netkit-telnetd-0.17-r12::gentoo failed (configure phase): > > * (no error message) > > * > > * Call stack: > > * ebuild.sh, line 125: Called src_configure > > * environment, line 1044: Called die > > * The specific snippet of code: > > * sed -i -e "s/-pipe -O2/${CFLAGS}/" -e > > "s/^\(LDFLAGS=\).*/\1${LDFLAGS}/" -e "s/-Wpointer-arith//" MCONFIG || die > > This error seems unrelated to the bug. What's the value of your CFLAGS and > LDFLAGS environment variables? portageq envvar LDFLAGS -Wl,-O1 -Wl,--as-needed portageq envvar CFLAGS -O2 -pipe -Wno-deprecated-declarations -Wno-error (In reply to Joakim Tjernlund from comment #12) > (In reply to Stefan Michelsson from comment #11) > > (In reply to Joakim Tjernlund from comment #8) > > > Checking for snprintf declaration... ok > > > Checking for snprintf implementation... ok > > > Generating MCONFIG... > > > sed: -e expression #1, char 103: unknown option to `s' > > > * ERROR: net-misc/netkit-telnetd-0.17-r12::gentoo failed (configure phase): > > > * (no error message) > > > * > > > * Call stack: > > > * ebuild.sh, line 125: Called src_configure > > > * environment, line 1044: Called die > > > * The specific snippet of code: > > > * sed -i -e "s/-pipe -O2/${CFLAGS}/" -e > > > "s/^\(LDFLAGS=\).*/\1${LDFLAGS}/" -e "s/-Wpointer-arith//" MCONFIG || die > > > > This error seems unrelated to the bug. What's the value of your CFLAGS and > > LDFLAGS environment variables? > > portageq envvar LDFLAGS > -Wl,-O1 -Wl,--as-needed > > portageq envvar CFLAGS > -O2 -pipe -Wno-deprecated-declarations -Wno-error That was the wrong system, this is the failing one: portageq envvar LDFLAGS -Wl,-O1 -Wl,--as-needed portageq envvar CFLAGS -O2 -pipe -Wno-error -fno-stack-check -Wno-deprecated-declarations (In reply to Joakim Tjernlund from comment #13) > (In reply to Joakim Tjernlund from comment #12) > > (In reply to Stefan Michelsson from comment #11) > > > (In reply to Joakim Tjernlund from comment #8) > > > > Checking for snprintf declaration... ok > > > > Checking for snprintf implementation... ok > > > > Generating MCONFIG... > > > > sed: -e expression #1, char 103: unknown option to `s' > > > > * ERROR: net-misc/netkit-telnetd-0.17-r12::gentoo failed (configure phase): > > > > * (no error message) > > > > * > > > > * Call stack: > > > > * ebuild.sh, line 125: Called src_configure > > > > * environment, line 1044: Called die > > > > * The specific snippet of code: > > > > * sed -i -e "s/-pipe -O2/${CFLAGS}/" -e > > > > "s/^\(LDFLAGS=\).*/\1${LDFLAGS}/" -e "s/-Wpointer-arith//" MCONFIG || die > > > > > > This error seems unrelated to the bug. What's the value of your CFLAGS and > > > LDFLAGS environment variables? > > > > portageq envvar LDFLAGS > > -Wl,-O1 -Wl,--as-needed > > > > portageq envvar CFLAGS > > -O2 -pipe -Wno-deprecated-declarations -Wno-error > > That was the wrong system, this is the failing one: > portageq envvar LDFLAGS > -Wl,-O1 -Wl,--as-needed > > portageq envvar CFLAGS > -O2 -pipe -Wno-error -fno-stack-check -Wno-deprecated-declarations I remembered one odd thing in my gentoo: cat /etc/portage/bashrc #echo $EBUILD_PHASE if [ "x$EBUILD_PHASE" = "xconfigure" ]; then echo "Adding -fdebug-prefix-map to CFLAGS/CXXFLAGS" CFLAGS="$CFLAGS -fdebug-prefix-map=..=$(readlink -f ..)" CXXFLAGS="$CXXFLAGS -fdebug-prefix-map=..=$(readlink -f ..)" fi (In reply to Joakim Tjernlund from comment #14) > (In reply to Joakim Tjernlund from comment #13) > > (In reply to Joakim Tjernlund from comment #12) > > > (In reply to Stefan Michelsson from comment #11) > > > > (In reply to Joakim Tjernlund from comment #8) > > > > > Checking for snprintf declaration... ok > > > > > Checking for snprintf implementation... ok > > > > > Generating MCONFIG... > > > > > sed: -e expression #1, char 103: unknown option to `s' > > > > > * ERROR: net-misc/netkit-telnetd-0.17-r12::gentoo failed (configure phase): > > > > > * (no error message) > > > > > * > > > > > * Call stack: > > > > > * ebuild.sh, line 125: Called src_configure > > > > > * environment, line 1044: Called die > > > > > * The specific snippet of code: > > > > > * sed -i -e "s/-pipe -O2/${CFLAGS}/" -e > > > > > "s/^\(LDFLAGS=\).*/\1${LDFLAGS}/" -e "s/-Wpointer-arith//" MCONFIG || die > > > > > > > > This error seems unrelated to the bug. What's the value of your CFLAGS and > > > > LDFLAGS environment variables? > > > > > > portageq envvar LDFLAGS > > > -Wl,-O1 -Wl,--as-needed > > > > > > portageq envvar CFLAGS > > > -O2 -pipe -Wno-deprecated-declarations -Wno-error > > > > That was the wrong system, this is the failing one: > > portageq envvar LDFLAGS > > -Wl,-O1 -Wl,--as-needed > > > > portageq envvar CFLAGS > > -O2 -pipe -Wno-error -fno-stack-check -Wno-deprecated-declarations > > I remembered one odd thing in my gentoo: > cat /etc/portage/bashrc > #echo $EBUILD_PHASE > if [ "x$EBUILD_PHASE" = "xconfigure" ]; then > echo "Adding -fdebug-prefix-map to CFLAGS/CXXFLAGS" > CFLAGS="$CFLAGS -fdebug-prefix-map=..=$(readlink -f ..)" > CXXFLAGS="$CXXFLAGS -fdebug-prefix-map=..=$(readlink -f ..)" > fi If I remove this bashrc , it works. Not sure what triggers the failure though Added an extra echo of CFLAGS in bashrc and got this: CFLAGS: -O2 -pipe -Wno-error -fno-stack-check -Wno-deprecated-declarations -fdebug-prefix-map=..=/var/tmp/portage/net-misc/netkit-telnetd-0.17-r12 so the extra / chars in there trips sed. (In reply to Joakim Tjernlund from comment #16) > Added an extra echo of CFLAGS in bashrc and got this: > CFLAGS: -O2 -pipe -Wno-error -fno-stack-check -Wno-deprecated-declarations > -fdebug-prefix-map=..=/var/tmp/portage/net-misc/netkit-telnetd-0.17-r12 > > so the extra / chars in there trips sed. Yes, my next suggestion would have been to check the output of ebuild --debug $(portageq get_repo_path / gentoo)/net-misc/netkit-telnetd/netkit-telnetd-0.17-r12.ebuild clean configure 2>/dev/null | grep "sed " The error message suggested that there were extra separators (/ in this case) in the expression. Like I said, that error didn't seem related to this bug (which is/was about configuration/compilation failure on musl because musl doesn't have an utmp/wtmp implementation). (In reply to Stefan Michelsson from comment #17) > (In reply to Joakim Tjernlund from comment #16) > > Added an extra echo of CFLAGS in bashrc and got this: > > CFLAGS: -O2 -pipe -Wno-error -fno-stack-check -Wno-deprecated-declarations > > -fdebug-prefix-map=..=/var/tmp/portage/net-misc/netkit-telnetd-0.17-r12 > > > > so the extra / chars in there trips sed. > > Yes, my next suggestion would have been to check the output of > ebuild --debug $(portageq get_repo_path / > gentoo)/net-misc/netkit-telnetd/netkit-telnetd-0.17-r12.ebuild clean > configure 2>/dev/null | grep "sed " > > The error message suggested that there were extra separators (/ in this > case) in the expression. > > > Like I said, that error didn't seem related to this bug (which is/was about > configuration/compilation failure on musl because musl doesn't have an > utmp/wtmp implementation). Right, this is another problem but now that we know what is there is no idea to file another one. Seem like most pkgs are switching to @ as sed delimiter and so could netkit-telnetd do. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=be181e0c76f2e0c99b4652f4be9d079010b2ebae commit be181e0c76f2e0c99b4652f4be9d079010b2ebae Author: PPed72 <paolo.pedroni@iol.it> AuthorDate: 2020-11-26 10:57:25 +0000 Commit: Joonas Niilola <juippis@gentoo.org> CommitDate: 2020-12-01 07:56:02 +0000 net-misc/netkit-telnetd: change sed delimiter Closes: https://bugs.gentoo.org/715706 Signed-off-by: Paolo Pedroni <paolo.pedroni@iol.it> Package-Manager: Portage-3.0.9, Repoman-3.0.2 Closes: https://github.com/gentoo/gentoo/pull/18412 Signed-off-by: Joonas Niilola <juippis@gentoo.org> net-misc/netkit-telnetd/netkit-telnetd-0.17-r12.ebuild | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) |