Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 715678

Summary: =sci-libs/fflas-ffpack-2.4.3: import package from sage-on-gentoo overlay
Product: Gentoo Linux Reporter: Michael Orlitzky <mjo>
Component: New packagesAssignee: Michael Orlitzky <mjo>
Status: RESOLVED FIXED    
Severity: normal CC: frp.bissey, mgorny
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description Michael Orlitzky gentoo-dev 2020-03-31 23:01:08 UTC
I wonder if we should make those local cpu_flags_x86 global... other than that this looks straightforward, and all of the dependencies can now be detected by sage.
Comment 1 Michael Orlitzky gentoo-dev 2020-03-31 23:09:06 UTC
Michał, this overlay package currently has two local flags for cpu_flags_x86_avx512dq and cpu_flags_x86_avx512vl. I see that these are supported by cpuid2cpuflags,

  https://github.com/mgorny/cpuid2cpuflags/blob/master/src/x86.c

but they aren't in profiles/desc/cpu_flags_x86.desc. Does it make sense to add them globally now, or leave them local for the time being?
Comment 2 François Bissey 2020-04-01 00:10:34 UTC
At the time I inserted those flags, I could see them in cpuid2dcpuflags code on github but not in a release of it, and certainly not in the available gentoo package. I lifted the name from there with the idea that they would eventually be available. 

I think there are a few other packages in the tree that have also started to use some of them locally.
Comment 3 François Bissey 2020-04-01 00:19:54 UTC
Hum, after checking the most interesting use of non standard cpu flags is in some eclasses.
/usr/portage/eclass/toolchain.eclass:		4.9 -mno-avx512pf
/usr/portage/eclass/toolchain.eclass:		4.9 -mno-avx512f
/usr/portage/eclass/toolchain.eclass:		4.9 -mno-avx512er
/usr/portage/eclass/toolchain.eclass:		4.9 -mno-avx512cd
/usr/portage/eclass/flag-o-matic.eclass:		-mno-avx512cd -mno-avx512er -mno-avx512f -mno-avx512pf -mno-sha

May be I saw some more stuff in the science overlay or the stuff has been cleaned.
Comment 4 Larry the Git Cow gentoo-dev 2020-04-03 16:05:28 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8db3670e7902795f2ae61d64b1930a946e5b2efc

commit 8db3670e7902795f2ae61d64b1930a946e5b2efc
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2020-04-01 23:59:53 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2020-04-03 16:03:48 +0000

    sci-libs/fflas-ffpack: new package for finite-field linear algebra.
    
    This is a straightforward import of the latest fflas-ffpack-2.4.3.ebuild
    that François Bissey has been maintaining in the sage-on-gentoo overlay,
    with only a few minor changes:
    
      * I added a "+" to the LICENSE to match the upstream LGPL-2.1+.
    
      * I switched the openmp check to use tc-check-openmp() conditionally
        on the MERGE_TYPE variable.
    
      * Added BDEPEND="virtual/pkgconfig" since we patch in a call to
        PKG_CHECK_MODULES.
    
    I also removed a warning about build failures with USE=openmp. From what
    I can tell, this stems from an older report (upstream Github issue 48)
    using gcc-4.9.x that was never fully debugged. If the problems persist,
    we can revisit that report, or just mask the flag.
    
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=715678
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 sci-libs/fflas-ffpack/Manifest                     |  1 +
 sci-libs/fflas-ffpack/fflas-ffpack-2.4.3.ebuild    | 62 +++++++++++++++
 .../files/fflas-ffpack-2.3.2-blaslapack.patch      | 90 ++++++++++++++++++++++
 sci-libs/fflas-ffpack/metadata.xml                 | 37 +++++++++
 4 files changed, 190 insertions(+)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=292d2d9703b6b0c6235b7de1e7dc343c66d772fb

commit 292d2d9703b6b0c6235b7de1e7dc343c66d772fb
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2020-04-01 19:01:08 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2020-04-03 16:03:34 +0000

    profiles/desc/cpu_flags_x86.desc: add avx512dq and avx512vl.
    
    These two flags are already supported by cpuid2cpuflags, but so far no
    package in ::gentoo uses them. The forthcoming sci-libs/fflas-ffpack
    will use them, however, and -- given that they're CPU flags whose names
    are fixed -- it seems most sensible to add them globally right away.
    
    Bug: https://bugs.gentoo.org/715678
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 profiles/desc/cpu_flags_x86.desc | 2 ++
 1 file changed, 2 insertions(+)