Summary: | dev-java/icedtea-web-1.8.4 version bump | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Joakim Tjernlund <joakim.tjernlund> |
Component: | Current packages | Assignee: | Java team <java> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | jstein, mattemod, ostroffjh, sam |
Priority: | Normal | Keywords: | EBUILD |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
icedtea web ebuild
somewhat buggy 1.8.3 ebuild random Java 11 patch found on the net icedtea-web-1.8.3 ebuild icedtea-web-1.8.4 ebuild |
Description
Joakim Tjernlund
2020-03-29 13:55:53 UTC
Created attachment 626976 [details]
icedtea web ebuild
Only builds against openjdk-8
I have an 1.8.3 ebuild too but that one seems a bit buggy, there is some background.jpg not loading at start up. Created attachment 626978 [details]
somewhat buggy 1.8.3 ebuild
please upload a PR on github and label it "do not merge". You can discuss the ebuild and get help for repair on the IRC channels #gentoo-dev-help and #gentoo-java (In reply to Joakim Tjernlund from comment #3) > Created attachment 626978 [details] > somewhat buggy 1.8.3 ebuild patch for jdk11? Created attachment 635028 [details, diff]
random Java 11 patch found on the net
(In reply to Andrea Postiglione from comment #5) > (In reply to Joakim Tjernlund from comment #3) > > Created attachment 626978 [details] > > somewhat buggy 1.8.3 ebuild > > patch for jdk11? Can't remember what that was for but here it is anyway (In reply to Joakim Tjernlund from comment #7) > (In reply to Andrea Postiglione from comment #5) > > (In reply to Joakim Tjernlund from comment #3) > > > Created attachment 626978 [details] > > > somewhat buggy 1.8.3 ebuild > > > > patch for jdk11? > > Can't remember what that was for but here it is anyway I suspect that upstream icedtea-web is better for java 11 though. Created attachment 635076 [details]
icedtea-web-1.8.3 ebuild
ebuild
(In reply to Andrea Postiglione from comment #9) > Created attachment 635076 [details] > icedtea-web-1.8.3 ebuild > > ebuild Did you fix anything? I seems like you mostly removed comments and removed pkg_setup, does that mean you built and tested against java-11 as well? Created attachment 652056 [details]
icedtea-web-1.8.4 ebuild
new ebuild
(In reply to Andrea Postiglione from comment #11) > Created attachment 652056 [details] > icedtea-web-1.8.4 ebuild > > new ebuild This will build against current java VM and fail if VM is 11 Migth also install under wrong path The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d79c65a0c600776066d2e0ebe2d261a41c345d57 commit d79c65a0c600776066d2e0ebe2d261a41c345d57 Author: Georgy Yakovlev <gyakovlev@gentoo.org> AuthorDate: 2020-09-05 04:32:54 +0000 Commit: Georgy Yakovlev <gyakovlev@gentoo.org> CommitDate: 2020-09-05 05:23:43 +0000 dev-java/icedtea-web: fix multiple qa issues in 1.8.4 disabled a lot of useless/old functionality Bug: https://bugs.gentoo.org/711392 Closes: https://bugs.gentoo.org/715316 Closes: https://bugs.gentoo.org/684330 Closes: https://github.com/gentoo/gentoo/pull/17413 Package-Manager: Portage-3.0.5, Repoman-3.0.1 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org> dev-java/icedtea-web/files/README.gentoo-r2 | 14 +++++ dev-java/icedtea-web/icedtea-web-1.8.4.ebuild | 88 +++++++++++++-------------- 2 files changed, 57 insertions(+), 45 deletions(-) 1.8.4 does not build if java-11 is default VM. I have this(stolen from some other java ebuild): pkg_setup() { JAVA_PKG_WANT_BUILD_VM="openjdk-${SLOT} openjdk-bin-${SLOT}" JAVA_PKG_WANT_SOURCE="${SLOT}" JAVA_PKG_WANT_TARGET="${SLOT}" # The nastiness below is necessary while the gentoo-vm USE flag is # masked. First we call java-pkg-2_pkg_setup if it looks like the # flag was unmasked against one of the possible build VMs. If not, # we try finding one of them in their expected locations. This would # have been slightly less messy if openjdk-bin had been installed to # /opt/${PN}-${SLOT} or if there was a mechanism to install a VM env # file but disable it so that it would not normally be selectable. local vm for vm in ${JAVA_PKG_WANT_BUILD_VM}; do if [[ -d ${EPREFIX}/usr/lib/jvm/${vm} ]]; then java-pkg-2_pkg_setup return fi done if has_version --host-root dev-java/openjdk:${SLOT}; then export JAVA_HOME=${EPREFIX}/usr/$(get_libdir)/openjdk-${SLOT} export JDK_HOME="${JAVA_HOME}" export ANT_RESPECT_JAVA_HOME=ture else if [[ ${MERGE_TYPE} != "binary" ]]; then JDK_HOME=$(best_version --host-root dev-java/openjdk-bin:${SLOT}) [[ -n ${JDK_HOME} ]] || die "Build VM not found!" JDK_HOME=${JDK_HOME#*/} JDK_HOME=${EPREFIX}/opt/${JDK_HOME%-r*} export JDK_HOME export JAVA_HOME="${JDK_HOME}" export ANT_RESPECT_JAVA_HOME=ture fi fi } and also changed SLOT to 8 |