Bug 715290 – dev-python/python-language-server: requires old <=dev-python/ujson-1.35

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Michał Górny 2020-03-29 10:19:19 UTC]

NonsolvableDepsInStable: version 0.31.9: nonsolvable depset(rdepend) keyword(~amd64) stable profile (default/linux/amd64/17.0) (39 total): solutions: [ <=dev-python/ujson-1.35[-python_single_target_python3_6(-),-python_single_target_python3_7(-),python_targets_python3_6(-),python_targets_python3_7(-)] ]

[Comment 1 Nowa Ammerlaan 2020-03-29 13:49:09 UTC]

> NonsolvableDepsInStable: version 0.31.9: nonsolvable depset(rdepend) keyword(~amd64) stable profile (default/linux/amd64/17.0) (39 total): solutions: [ <=dev-python/ujson-1.35[-python_single_target_python3_6(-),-python_single_target_python3_7(-),python_targets_python3_6(-),python_targets_python3_7(-)] ]

Just tested python-langauge-server/python-jsonrpc-server with >ujson-1.35, and it looks like python-jsonrpc-server (and therefore python-language-server) has to have ujson-1.35. Otherwise the test suite fails:
AssertionError: assert b'' == (b'Content-Length: 10\r\nContent-Type: application/vscode-jsonrpc; charset=ut'\n b'f8\r\n\r\n1546304461')
E             Full diff:
E             + b''
E             - (
E             -  b'Content-Length: 10\r\nContent-Type: application/vscode-jsonrpc; charset=ut'
E             -  b'f8\r\n\r\n1546304461',
E             - )

test/test_streams.py:114: AssertionError

[Comment 2 Nowa Ammerlaan 2020-05-12 08:34:51 UTC]

See also: https://github.com/palantir/python-language-server/issues/802

"""
Hello. Once the windows and mac wheels are mived from test pypi to real pypi we will make the move.
"""

[Comment 3 Nowa Ammerlaan 2020-05-12 08:37:07 UTC]

And also: https://github.com/palantir/python-language-server/issues/744

And: https://github.com/palantir/python-language-server/pull/781
(Merged, should be in the next version)

[Comment 4 Jannik Glückert 2020-10-10 23:53:18 UTC]

This is fixed as of 0.35.0 , see the release announcement https://github.com/palantir/python-language-server/releases/tag/0.35.0

[Comment 5 Nowa Ammerlaan 2020-10-11 08:36:52 UTC]

Yeah it says it is compatible with newer ujson in the changelog, but when I ran the tests I only got it to pass with version 1.35

[Comment 6 Joonas Niilola 2020-10-11 08:45:12 UTC]

Maybe they forgot to fix test cases? Can you try modifying the test requirement and see if it passes.

Also an upstream issue about it would be preferred.

[Comment 7 Nowa Ammerlaan 2020-10-11 11:00:23 UTC]

I just retested this, and still found that python-jsonrpc-server does not work with newer ujson. This upstream PR fixes the issue: https://github.com/palantir/python-jsonrpc-server/pull/49

[Comment 8 Larry the Git Cow 2020-10-16 13:26:27 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dbc464b7fc5f2cfdcce55e03ed68f66a80abc313

commit dbc464b7fc5f2cfdcce55e03ed68f66a80abc313
Author:     Andrew Ammerlaan <[e-mail]>
AuthorDate: 2020-10-11 11:13:14 +0000
Commit:     Joonas Niilola <[e-mail]>
CommitDate: 2020-10-16 13:26:18 +0000

    dev-python/python-jsonrpc-server: fix bug in tests with ujson>3
    
    Closes: https://bugs.gentoo.org/715290
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Andrew Ammerlaan <[e-mail]>
    Signed-off-by: Joonas Niilola <[e-mail]>

 ...n-jsonrpc-server-0.4.0-fix-test-with-ujson-3-and-up.patch | 12 ++++++++++++
 ...er-0.4.0.ebuild => python-jsonrpc-server-0.4.0-r1.ebuild} |  8 +++-----
 2 files changed, 15 insertions(+), 5 deletions(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0e7bb9b48f1a198982e44aaf3edf998e903893f8

commit 0e7bb9b48f1a198982e44aaf3edf998e903893f8
Author:     Andrew Ammerlaan <[e-mail]>
AuthorDate: 2020-10-11 11:14:39 +0000
Commit:     Joonas Niilola <[e-mail]>
CommitDate: 2020-10-16 13:26:18 +0000

    dev-python/python-language-server: allow newer ujson
    
    Bug: https://bugs.gentoo.org/715290
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Andrew Ammerlaan <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/17882
    Signed-off-by: Joonas Niilola <[e-mail]>

 ...server-0.35.1.ebuild => python-language-server-0.35.1-r1.ebuild} | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)