Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 715140

Summary: dev-perl/String-Format-1.170.0-r1 : Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex
Product: Gentoo Linux Reporter: bdouxx <bdouxx-gentoo>
Component: Current packagesAssignee: Gentoo Perl team <perl>
Status: RESOLVED FIXED    
Severity: normal CC: bdouxx-gentoo, halcon, jstein
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---

Description bdouxx 2020-03-28 10:15:38 UTC
warning when using the module


perlcritic my_script.pl          
                                                                              
Unescaped left brace in regex is deprecated here (and will be fatal in Perl 5.32), passed through in regex; marked by <-- HERE in m/
               (%             # leading '%'
                (-)?          # left-align, rather than right
                (\d*)?        # (optional) minimum field width
                (?:\.(\d*))?  # (optional) maximum field width
                ({ <-- HERE .*?})?      # (optional) stuff inside
                (\S)          # actual format character
             )/ at /usr/lib64/perl5/vendor_perl/5.30.1/String/Format.pm line 77.


problem solved in a more recent version of the module:

https://metacpan.org/changes/release/SREZIC/String-Format-1.18

need to change ebuild with this: 

6,7c6,7
< MODULE_AUTHOR=DARREN
< MODULE_VERSION=1.17
---
> MODULE_AUTHOR=SREZIC
> MODULE_VERSION=1.18
Comment 1 Alexey Mishustin 2021-02-02 01:50:47 UTC
"will be fatal in Perl 5.32" means that not only String-Format-1.170.0 will not work in the next perl version (5.32), but all its reverse dependencies, including Perl-Critic, won't work either.

--- /var/db/repos/gentoo/dev-perl/String-Format/String-Format-1.170.0-r1.ebuild 2021-01-07 01:39:32.000000000 +0300
+++ /var/db/repos/halcon-overlay/dev-perl/String-Format/String-Format-1.180.ebuild      2021-02-02 04:42:31.245329521 +0300
@@ -1,10 +1,10 @@
 # Copyright 1999-2021 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
-EAPI=5
+EAPI=7
 
-MODULE_AUTHOR=DARREN
-MODULE_VERSION=1.17
+DIST_AUTHOR=SREZIC
+DIST_VERSION=1.18
 inherit perl-module
 
 DESCRIPTION="sprintf-like string formatting capabilities with arbitrary format definitions"
Comment 2 Larry the Git Cow gentoo-dev 2021-05-08 13:10:07 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d6ce771cd91bb2f7493286a02fd5bb0fd2a83c4e

commit d6ce771cd91bb2f7493286a02fd5bb0fd2a83c4e
Author:     Andreas K. Hüttel <dilfridge@gentoo.org>
AuthorDate: 2021-05-08 13:09:10 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2021-05-08 13:09:10 +0000

    dev-perl/String-Format: Version bump 1.18
    
    Closes: https://bugs.gentoo.org/715140
    Package-Manager: Portage-3.0.18, Repoman-3.0.2
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 dev-perl/String-Format/Manifest                     |  1 +
 dev-perl/String-Format/String-Format-1.180.0.ebuild | 15 +++++++++++++++
 2 files changed, 16 insertions(+)