Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 71485

Summary: Request: Add amr support into media-video/ffmpeg
Product: Gentoo Linux Reporter: hodak
Component: New packagesAssignee: Gentoo Media-video project <media-video>
Status: RESOLVED DUPLICATE    
Severity: normal CC: 1723542c42148b2fe4af9f7ad1e382b30d4b7fd7, cmr, gentoo
Priority: High    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: ffmpeg-0.4.9_p20050226-r5_amr.patch

Description hodak 2004-11-16 20:44:23 UTC
It is possible add support for amr. To do this one has to specify the following flags when doing configure:
--enable-amr_nb
--enable-amr_nb-fixed
--enable-amr_wb

Then 2 files need to downloaded:
http://www.3gpp.org/ftp/Specs/archive/26_series/26.204/26204-510.zip
http://www.3gpp.org/ftp/Specs/latest/Rel-5/26_series/26073-510.zip

First file should be extracted into libavcodec/amrwb_float, the second one into
libavcodec/amr. 
CFLAGS in libavcodec/amr/makefile shoudl be changed to 
CFLAGS = -Wall -I. $(CFLAGS_$(MODE)) -D$(VAD) -DMMS_IO
 
That should be about it. 
Unfortunatelly, I do not know enough about ebuild to do the changes listed above myself. 

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Chris White (RETIRED) gentoo-dev 2005-03-15 21:43:42 UTC
amr support is trying to get integrated via the latest cvs snapshot, the duplicate bug listed is currently being tested to make sure that amr works across arches.

*** This bug has been marked as a duplicate of 85407 ***
Comment 2 chris roddy 2005-05-18 17:39:20 UTC
bug 85407 has been closed; amr support has been dropped from the ffmpeg ebuild.

I would like to request that this bug be reopened so that the possibility of amr
support in ffmpeg can be examined again.
Comment 3 Boris 2005-06-18 04:03:37 UTC
Created attachment 61438 [details, diff]
ffmpeg-0.4.9_p20050226-r5_amr.patch

(In reply to comment #2)
> I would like to request that this bug be reopened so that the
> possibility of amr support in ffmpeg can be examined again.

There are licensing-issues with the amr-support in ffmpeg, thats why they don't
include it, see amr.c:

> The licence of the code from 3gpp is unclear
> so you have to download the code separately.


Nevertheless, I created a small patch based on the attachment in Bug #85407 and
a more current version of the ebuild from the tree, so people can add
amr-support themselves if they want.
Comment 4 Marcello Magaldi 2005-12-19 01:53:38 UTC
(In reply to comment #3)
> Nevertheless, I created a small patch based on the attachment in Bug #85407 and
> a more current version of the ebuild from the tree, so people can add
> amr-support themselves if they want.

I tried to apply your patch but it fails :
patch <ffmpeg-0.4.9_p20050226-r5_amr.patch ffmpeg-0.4.9_p20050226-r5.ebuild
patching file ffmpeg-0.4.9_p20050226-r5.ebuild
Hunk #1 FAILED at 12.
1 out of 3 hunks FAILED -- saving rejects to file ffmpeg-0.4.9_p20050226-r5.ebuild.rej
Comment 5 Boris 2005-12-19 13:09:15 UTC
(In reply to comment #4)

> I tried to apply your patch but it fails

The ebuild changed in the last few months [1]
Try and replace the ~alpha and ~ia64 with alpha and ia64 in the IUSE _of the patch_!

[1] http://www.gentoo.org/cgi-bin/viewcvs.cgi/media-video/ffmpeg/ffmpeg-0.4.9_p20050226-r5.ebuild?r1=1.15&r2=1.11