Summary: | games-fps/serious-sam-tse - Serious Sam: The Second Encounter (New Package) | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Matt <shovas> |
Component: | [OLD] Games | Assignee: | Sergey Popov <pinkbyte> |
Status: | RESOLVED FIXED | ||
Severity: | enhancement | CC: | brebs, flash3001, iyosifov, maxim.konyushikhin, nitro |
Priority: | Normal | Keywords: | EBUILD |
Version: | unspecified | ||
Hardware: | x86 | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
serious-sam-tse-1.07_beta1.ebuild (New Package)
serious-sam-tse-1.07_beta1.ebuild (New Package) serious-sam-tse-1.07_beta1.ebuild (New Package) serious-sam-tse-1.07_beta1.ebuild (New Package) serious-sam-tse-1.07_beta1.ebuild (New Package) ssamtse-1_beta1.ebuild ssamtse-1_beta1.ebuild ssamtse-1_beta1.ebuild ssamtse-1_beta1.ebuild games-fps/ssamtse-1_beta1-r1.ebuild games-fps/ssamtse-1_beta1-r1.ebuild |
Description
Matt
2004-11-16 19:18:29 UTC
Created attachment 44126 [details]
serious-sam-tse-1.07_beta1.ebuild (New Package)
Created attachment 44748 [details]
serious-sam-tse-1.07_beta1.ebuild (New Package)
Fixes ownership to root.games in /usr/games/bin and /opt/serious-sam-tfe/.
Comment on attachment 44748 [details]
serious-sam-tse-1.07_beta1.ebuild (New Package)
Bad attachment.
Created attachment 44749 [details]
serious-sam-tse-1.07_beta1.ebuild (New Package)
Fixes ownership to root.games in /usr/games/bin and /opt/serious-sam-tse.
I found two trivial bugs on serious-sam-tse-1.07_beta1.ebuild (id=44749). 1) the simlink still not change ownership as you can see from my log: --------------------------------------------------------------------- ...[CUT] * Found CD #1 root at /mnt/cdrom >>> Unpacking source... * Extracting all embedded archives from fetched packages. * o Processing ssamtse-beta1.sh.bin... >>> Source unpacked. >>> Test phase [not enabled]: games-fps/serious-sam-tse-1.07_beta1 >>> Install serious-sam-tse-1.07_beta1 into /var/tmp/portage/serious-sam-tse-1.07_beta1/image/ category games-fps * Copying CDROM /Install/ image. * Extracting and installing from sub-archive ssamtse-beta1-embedded-archive.tar * Extracting and installing from sub-archive bins.tar.bz2 * Extracting and installing from sub-archive setupstuff.tar.gz * Creating symlinks for binaries. chown: cannot access `/usr/games/bin/ssamtse': No such file or directory man: prepallstrip: ...[CUT] --------------------------------------------------------------------- ls -l /usr/games/bin/ssamtse lrwxrwxrwx 1 root root 28 11 dic 15:35 /usr/games/bin/ssamtse -> /opt/serious-sam-tse/ssamtse 2) the .ebuild doesn't place KDE/GNOME games menu entry. However thank you very much for that great work. Ciao. p.s.: sorry for my bad english. Created attachment 45957 [details]
serious-sam-tse-1.07_beta1.ebuild (New Package)
Symlink ownership changes during src_install() referencing non-image
directories corrected. Bug concerning KDE/Gnome menu entries could not be acted
on as a proper Gentoo-wide solution has not yet been created.
Created attachment 48706 [details]
serious-sam-tse-1.07_beta1.ebuild (New Package)
Fixes /Install/ copy instead of /Install/* copy. Smarter copying of CD data.
Created attachment 80986 [details]
ssamtse-1_beta1.ebuild
Here is a tidied ebuild, with extra USE flags.
ssamtse-1_beta1.ebuild worked well for me - install was smooth. Game runs pretty well install and game works perfect here #8: Okay, I'll admit I've been away from Gentoo for a while and so I'm very, very rusty, but do your ebuilds even work? I can't get a digest out of them. They seem broken? #11: Sorry, I'm _am_ very, very rusty. Learning things again. No problems with the ebuild yet. Just wanted to note that bug 71436 comment 13 reports the files in the new ebuild are not available from the servers used. I ran into this problem but didn't have the motivation to report it. My ebuild uses icculus.org which has the files and is working. Regarding the ebuild cleanup by Paul Bredbury, like I mentioned in the other bug I don't mean to come off like a prick, but I think the original ebuild was better. Created attachment 104254 [details] ssamtse-1_beta1.ebuild Fixed SRC_URI. Minor tweaks. Untested ebuild. Both Edome and PlanetMirror are specified as mirrors e.g. here: http://files.seriouszone.com/download.php?fileid=410 Created attachment 104322 [details]
ssamtse-1_beta1.ebuild
Hi all! I made some minor changes. Please consider adding this ebuild to the portage tree. I can maintain it if it is needed. Tested, works fine. Created attachment 104338 [details]
ssamtse-1_beta1.ebuild
Merged the last two ebuilds, with further improvements. The only difference in the installed files is the removal of the Windows-specific files.
Explanatory notes:
* games_pkg_setup and games_pkg_postinst are placed at the *top* of the subroutine as standard, in case they define variables to be used later in the same subroutine, and to be consistent with other eclasses.
* Levels dir is created, just for safety - it's harmless, and I couldn't be bothered testing the different USE combinations to see if it can safely be removed.
* unpack already dies on failure, so no need to check. Contrarily, games_make_wrapper and make_desktop_entry customarily don't have a die added, because they're only installing one small file each.
* doins *.gro is only done once.
* The .so files are marked executable also.
* Slightly rewrote the bin directory handling so that a rm command is not necessary (except applying to $D).
* There are no .doc files on the SSam Gold CD, so I don't install *.doc.
* einfo is used for messages that can be ignored, and elog for messages which should be seen.
(In reply to comment #17) I have two questions: > * games_pkg_setup and games_pkg_postinst are placed at the *top* of the > subroutine as standard, in case they define variables to be used later in the > same subroutine, and to be consistent with other eclasses. 1. Why games_pkg_setup should be at the top? man games.ebuild says that it must be the last statement. > games_make_wrapper and make_desktop_entry customarily don't have a die added, > because they're only installing one small file each. 2. But this small files are inportant for end user as it expects to run game from the menu icon and that the install process always works the same way. (In reply to comment #18) > man games.eclass says that it must be the last statement. The docs are out-of-date - see e.g. /usr/portage/games-fps/qudos/qudos-9999.ebuild > But this small files are important for end user The commands themselves should die on failure, but Gentoo devs can't even agree on dobin dying on failure - bug #138792 :( (In reply to comment #19) Thank you for explanations: very useful for me. I have no more remarks for now. Ebuild installs fine, game works as expected. Created attachment 276607 [details] games-fps/ssamtse-1_beta1-r1.ebuild I updated the ebuild and made a few changes to get it working correctly on my system, as well as to improve it where possible. The biggest changes: * Switched to the dynamic binary to match the ssamtfe change I submitted to bug 71436. This seems to work better on modern systems. * Re-added support for the level cabs as unshield 0.6 unpacks them just fine * Rearranged a LOT of the level and resource files to make everything install in the correct location. The Technology demo now works, for example. There are two remaining issues that I couldn't work out: 1. map and model downloads are broken. The source site no longer exists, and the replacement (http://www.seriouszone.com/) seems to be having major file hosting issues. I was able to find all of the files hosted on gamefront and pull them manually, but I don't think that's an acceptable source. Given that these seem to be somewhat arbitrarily chosen community maps/models, it might be easiest and best to just remove it altogether and let users add what they want. 2. The CD includes a mod called Warped (my version does, anyway) that, after the path changes mentioned above, now actually shows up in the in-game Mods list. However, when trying to select a mod (either Warped, or the default Second Encounter) the game crashes. I get no information either to stdout or to the log file, and I haven't been able to figure out what's going on. Heck, it may be one of the remaining bugs in the Linux client, since this is still a beta after all. At this point I don't care all that much as it appears to be a multi-player thing, but just the fact that I couldn't get it working is rather annoying... Anyway, enjoy. Please let me know if you spot any problems. Created attachment 323846 [details]
games-fps/ssamtse-1_beta1-r1.ebuild
minor update: cdrom and unpacker eclasses now explicitly included, as required
I will put this package to tree in few days. Ebuild needs some polishing, also links on additional maps and models are dead, so i have removed them for now :-( Commited to tree as games-fps/serious-sam-tse Hey, Sergey. Thanks for your cleanup work, and finally getting this into the tree! Much appreciated. Since we now have the Second Encounter included in portage, have you given any thought to adding the First Encounter ebuild in bug 71436? I'm sure it could use a similar level of cleanup as this ebuild, but if you would be willing to consider it for inclusion as well, I'd be happy to spend some time cleaning it up to match this one as much as possible. Just let me know. (In reply to comment #25) > Hey, Sergey. Thanks for your cleanup work, and finally getting this into > the tree! Much appreciated. > > Since we now have the Second Encounter included in portage, have you given > any thought to adding the First Encounter ebuild in bug 71436? I'm sure it > could use a similar level of cleanup as this ebuild, but if you would be > willing to consider it for inclusion as well, I'd be happy to spend some > time cleaning it up to match this one as much as possible. > > Just let me know. Sure, i can say you what to look for in ebuild. This is: - proper KEYWORDS; - verified dependencies both on amd64 and x86(if you can not verify them on some of this arches, just say it in ebuild's comment) - probably by running clean stage3 in chroot and discovering dependencies one by one; - do not bother about QA variables - i will handle this myself; - take care about unneeded files(such as Setup.exe and stuff for it) and bundled libraries(such as libogg and libvorbis - package should use system ones if it is possible) I think that this is all issues with this ebuild. If you want to discuss more details, i think we should do this in bug #71436 and not here :-) |