Bug 714736

Summary:	app-text/fbpdf-0_p20190202 : fbpdf.c: error: format not a string literal and no format arguments [-Werror=format-security]
Product:	Gentoo Linux	Reporter:	Toralf Förster <toralf>
Component:	Current packages	Assignee:	Sergei Trofimovich (RETIRED) <slyfox>
Status:	RESOLVED FIXED
Severity:	normal
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	713576
Attachments:	emerge-info.txt app-text:fbpdf-0_p20190202:20200325-103057.log emerge-history.txt environment etc.portage.tbz2 temp.tbz2

Description Toralf Förster gentoo-dev

2020-03-25 16:29:48 UTC

make -j1 CC=x86_64-pc-linux-gnu-gcc CFLAGS=-O2 -pipe -march=native  -falign-functions=32:25:16 -fno-common -Werror=format-security -Wformat LDFLAGS=-Wl,-O1 -Wl,--as-needed 
x86_64-pc-linux-gnu-gcc -c -O2 -pipe -march=native  -falign-functions=32:25:16 -fno-common -Werror=format-security -Wformat fbpdf.c
fbpdf.c: In function main:
fbpdf.c:350:3: error: format not a string literal and no format arguments [-Werror=format-security]

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_gnome-20200322-135559

  -------------------------------------------------------------------

  Please see the tracker bug for details.

gcc-config -l:
 [1] x86_64-pc-linux-gnu-9.3.0 *
clang version 10.0.0 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/10/bin
/usr/lib/llvm/10
10.0.0
Available Python interpreters, in order of preference:
  [1]   python3.8
  [2]   python3.7
  [3]   python3.6
  [4]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems)
  [2]   ruby25 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.42.0 *
The following VMs are available for generation-2:
*)	IcedTea JDK 3.14.0 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm

The Glorious Glasgow Haskell Compilation System, version 8.0.2

timestamp of HEAD at this tinderbox image:
/var/db/repos/gentoo	Wed 25 Mar 2020 09:43:04 AM UTC

emerge -qpvO app-text/fbpdf
[ebuild  N    ] app-text/fbpdf-0_p20190202

Comment 1 Toralf Förster gentoo-dev

2020-03-25 16:29:51 UTC

Created attachment 625782 [details]
emerge-info.txt

Comment 2 Toralf Förster gentoo-dev

2020-03-25 16:29:54 UTC

Created attachment 625784 [details]
app-text:fbpdf-0_p20190202:20200325-103057.log

Comment 3 Toralf Förster gentoo-dev

2020-03-25 16:29:57 UTC

Created attachment 625786 [details]
emerge-history.txt

Comment 4 Toralf Förster gentoo-dev

2020-03-25 16:30:00 UTC

Created attachment 625788 [details]
environment

Comment 5 Toralf Förster gentoo-dev

2020-03-25 16:30:03 UTC

Created attachment 625790 [details]
etc.portage.tbz2

Comment 6 Toralf Förster gentoo-dev

2020-03-25 16:30:06 UTC

Created attachment 625792 [details]
temp.tbz2

Comment 7 Sergei Trofimovich (RETIRED) gentoo-dev

2020-03-25 19:37:37 UTC

Probably fixed upstream as https://github.com/aligrudi/fbpdf/commit/e89e36c01d09ca6aec03732e922e749257cac3f4

Comment 8 Larry the Git Cow gentoo-dev

2020-03-25 19:46:26 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c5ebe7c33f634a80a9137bdee9e856bc30e01509

commit c5ebe7c33f634a80a9137bdee9e856bc30e01509
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2020-03-25 19:46:02 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2020-03-25 19:46:18 +0000

    app-text/fbpdf: backport -Werror=format-security fix, bug #714736
    
    Reported-by: Toralf Förster
    Closes: https://bugs.gentoo.org/714736
    Package-Manager: Portage-2.3.95, Repoman-2.3.21
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 app-text/fbpdf/fbpdf-0_p20190202.ebuild            |  3 +-
 .../fbpdf/files/fbpdf-0_p20190202-printf.patch     | 38 ++++++++++++++++++++++
 2 files changed, 40 insertions(+), 1 deletion(-)