Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 714168

Summary: net-misc/networkmanager-1.26.2: udev rule for setting ENV{ID_NET_DRIVER} on devices is broken because of wrong hardcoded path for sed
Product: Gentoo Linux Reporter: Andrei Slavoiu <ansla80>
Component: Current packagesAssignee: Gentoo Linux Gnome Desktop Team <gnome>
Status: CONFIRMED ---    
Severity: normal CC: jstein, whissi
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/17935
https://bugs.gentoo.org/show_bug.cgi?id=811291
Whiteboard:
Package list:
Runtime testing required: ---
Attachments: emerge --info

Description Andrei Slavoiu 2020-03-24 13:26:43 UTC
The rule in is:
ENV{ID_NET_DRIVER}=="veth", ENV{NM_UNMANAGED}="1"

however, on my system, no network device has ID_NET_DRIVER set so the rule is never matched.

The present attributes are:
P: /devices/virtual/net/vethcf09565
E: DEVPATH=/devices/virtual/net/vethcf09565
E: IFINDEX=10
E: INTERFACE=vethcf09565
E: SUBSYSTEM=net
E: USEC_INITIALIZED=6109932011
E: net.ifnames=0

Reproducible: Always
Comment 1 Andrei Slavoiu 2020-03-24 13:28:16 UTC
Created attachment 625004 [details]
emerge --info
Comment 2 Andrei Slavoiu 2020-03-24 13:31:39 UTC
btw, as a workaround, I changed the rule to:
ENV{INTERFACE}=="veth*", ENV{NM_UNMANAGED}="1"
Comment 3 Joakim Tjernlund 2020-03-30 09:33:43 UTC
I wonder if not this file is the reason:
   /lib/udev/rules.d/84-nm-drivers.rules
it has /usr/sbin/ethtool hardcoded and Gentoo NM does not
depend on ethtool.

Your rule is better though as it does not depend on ethtool at all.
Comment 4 Andrei Slavoiu 2020-03-30 15:43:07 UTC
You are right, /lib/udev/rules.d/84-nm-drivers.rules is the broken one, but not necessarily because of ethtool hardcoded path, I do have it there. But on Gentoo "sed" is installed in /bin, not /usr/bin.
Comment 5 Joakim Tjernlund 2020-04-01 21:17:22 UTC
(In reply to Andrei Slavoiu from comment #4)
> You are right, /lib/udev/rules.d/84-nm-drivers.rules is the broken one, but
> not necessarily because of ethtool hardcoded path, I do have it there. But
> on Gentoo "sed" is installed in /bin, not /usr/bin.

Right, I forgot it was sed, not ethtool.
Still good to loose the ethtool/sed dependency though
Comment 6 Larry the Git Cow gentoo-dev 2020-11-05 02:43:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5f8d9746194996f440c3cd5ee6276ecdb0c62add

commit 5f8d9746194996f440c3cd5ee6276ecdb0c62add
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2020-10-15 13:42:55 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2020-11-05 02:41:31 +0000

    net-misc/networkmanager: fix 84-nm-drivers.rules UDEV rule
    
    Closes: https://bugs.gentoo.org/714168
    Package-Manager: Portage-3.0.8, Repoman-3.0.1
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/17935
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 net-misc/networkmanager/networkmanager-1.26.4.ebuild | 5 +++++
 1 file changed, 5 insertions(+)
Comment 7 Mart Raudsepp gentoo-dev 2020-12-08 08:24:21 UTC
This needs upstreaming in a more complete form
Comment 8 Matt Turner gentoo-dev 2022-05-18 02:55:12 UTC
In the v1.38.0 NEWS file I see

> * Veth devices with name "eth*" are now managed by default via the
>   udev rule. This is to support managing the network in LXD containers.

Does this resolve the issue?