| Summary: | media-libs/mesa: limit llvm version in a slot-operator dep | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Alexander Tsoy <alexander> |
| Component: | Current packages | Assignee: | Gentoo X packagers <x11> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | grknight, mgorny |
| Priority: | Normal | ||
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
(In reply to Alexander Tsoy from comment #0) > > Otherwise, mesa could RDEPEND on a newer llvm slot. Steps to reproduce: > > 1. install sys-devel/llvm-10.0* > 2. re-emerge mesa (19.3* or 20.0*) > 3. uninstall sys-devel/llvm-10.0* How did you "uninstall"? It is not normally possible. (In reply to Brian Evans from comment #1) > How did you "uninstall"? It is not normally possible. Oh, indeed. I probably did emerge -C sys-devel/llvm:10 since I was sure that nothing depends on it. :) (In reply to Alexander Tsoy from comment #2) > (In reply to Brian Evans from comment #1) > > How did you "uninstall"? It is not normally possible. > Oh, indeed. I probably did emerge -C sys-devel/llvm:10 since I was sure that > nothing depends on it. :) If that's the case, then this is a broken dependency tree caused by such an action and portage is recommending the way to correct it (with a full @world update). Unless you can show a good reason to limit the version, I recommend closing as INVALID (In reply to Brian Evans from comment #3) > Unless you can show a good reason to limit the version, I recommend closing > as INVALID mesa should not RDEPEND on unsupported llvm slot/subslot. There is also an example of how package should depend on llvm in llvm.eclass: https://gitweb.gentoo.org/repo/gentoo.git/tree/eclass/llvm.eclass?id=d2b1544125d76c2069c8c5a53dc62dbb379bf501#n24 mgorny, do you have an opinion on this?
@@ -153,7 +153,7 @@
sys-devel/llvm:9[${MULTILIB_USEDEP}]
sys-devel/llvm:8[${MULTILIB_USEDEP}]
)
- sys-devel/llvm:=[${MULTILIB_USEDEP}]
+ <sys-devel/llvm-10:=[${MULTILIB_USEDEP}]
"
(presumably I would change "10" to ${LLVM_MAX_SLOT})
(In reply to Matt Turner from comment #5) > mgorny, do you have an opinion on this? > > @@ -153,7 +153,7 @@ > sys-devel/llvm:9[${MULTILIB_USEDEP}] > sys-devel/llvm:8[${MULTILIB_USEDEP}] > ) > - sys-devel/llvm:=[${MULTILIB_USEDEP}] > + <sys-devel/llvm-10:=[${MULTILIB_USEDEP}] > " Makes sense. I'm sorry that I didn't do it that way originally. > > (presumably I would change "10" to ${LLVM_MAX_SLOT}) Way, technically it's $((LLVM_MAX_SLOT + 1)), or ${LLVM_MAX_SLOT}.9999 ;-). The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4d9406d9e086884c61ab153771628d19f75b78e8 commit 4d9406d9e086884c61ab153771628d19f75b78e8 Author: Matt Turner <mattst88@gentoo.org> AuthorDate: 2020-04-03 17:39:33 +0000 Commit: Matt Turner <mattst88@gentoo.org> CommitDate: 2020-04-03 17:42:29 +0000 media-libs/mesa: Explicitly limit llvm max version Closes: https://bugs.gentoo.org/712904 Signed-off-by: Matt Turner <mattst88@gentoo.org> media-libs/mesa/mesa-9999.ebuild | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) |
There should be a version limit in a depdendency with slot-operator: @@ -153,7 +153,7 @@ sys-devel/llvm:9[${MULTILIB_USEDEP}] sys-devel/llvm:8[${MULTILIB_USEDEP}] ) - sys-devel/llvm:=[${MULTILIB_USEDEP}] + <sys-devel/llvm-10:=[${MULTILIB_USEDEP}] " LLVM_DEPSTR_AMDGPU=${LLVM_DEPSTR//]/,llvm_targets_AMDGPU(-)]} CLANG_DEPSTR=${LLVM_DEPSTR//llvm/clang} This is even outlined in comment inside ebuild: # How to use it: ... # 2. Update the := to specify *max* version, e.g. < 10. Otherwise, mesa could RDEPEND on a newer llvm slot. Steps to reproduce: 1. install sys-devel/llvm-10.0* 2. re-emerge mesa (19.3* or 20.0*) 3. uninstall sys-devel/llvm-10.0* 4. $ sudo emerge -pc ... Calculating dependencies... done! * Dependencies could not be completely resolved due to * the following required packages not being installed: * * sys-devel/llvm:10/10=[abi_x86_32(-),abi_x86_64(-),llvm_targets_AMDGPU(-)] pulled in by: * media-libs/mesa-20.0.1-r1 * * Have you forgotten to do a complete update prior to depclean? The * most comprehensive command for this purpose is as follows: * * emerge --update --newuse --deep --with-bdeps=y @world * * Note that the --with-bdeps=y option is not required in many * situations. Refer to the emerge manual page (run `man emerge`) * for more information about --with-bdeps. * * Also, note that it may be necessary to manually uninstall * packages that no longer exist in the repository, since it may not * be possible to satisfy their dependencies. /var/db/pkg/media-libs/mesa-20.0.1-r1/RDEPEND: ... || ( sys-devel/llvm:9[abi_x86_32(-),abi_x86_64(-),llvm_targets_AMDGPU(-)] sys-devel/llvm:8[abi_x86_32(-),abi_x86_64(-),llvm_targets_AMDGPU(-)] ) sys-devel/llvm:10/10=[abi_x86_32(-),abi_x86_64(-),llvm_targets_AMDGPU(-)] and after the change: /var/db/pkg/media-libs/mesa-20.0.1-r1/RDEPEND: ... || ( sys-devel/llvm:9[abi_x86_32(-),abi_x86_64(-),llvm_targets_AMDGPU(-)] sys-devel/llvm:8[abi_x86_32(-),abi_x86_64(-),llvm_targets_AMDGPU(-)] ) <sys-devel/llvm-10:9/9=[abi_x86_32(-),abi_x86_64(-),llvm_targets_AMDGPU(-)]