Bug 711052

Summary:	net-mail/notmuch: USE-Flags vs. dependencies
Product:	Gentoo Linux	Reporter:	Franz Trischberger <franz.trischberger>
Component:	Current packages	Assignee:	Ralph Seichter <gentoo>
Status:	RESOLVED FIXED
Severity:	normal	CC:	franz.trischberger, jstein, proxy-maint
Priority:	Normal	Keywords:	PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
See Also:	https://github.com/gentoo/gentoo/pull/15918
Whiteboard:
Package list:		Runtime testing required:	---

Description Franz Trischberger 2020-02-28 17:45:23 UTC

notmuch currently pulls in sphinx unconditionally, even as runtime dependency.
It's used to generate manpages and info files. While the man-pages are built only when USE="doc" is set, the info files get built unconditionally.

This is how notmuch was installed:

Installed versions:  0.29.3(0/5)^t(12:20:13 02/27/20)(crypt valgrind -doc -emacs -mutt -nmbug -python -test PYTHON_TARGETS="python3_6 -python3_7")

$ qlist notmuch
/usr/bin/notmuch
/usr/share/doc/notmuch-0.29.3/NEWS.bz2
/usr/share/doc/notmuch-0.29.3/README.bz2
/usr/share/doc/notmuch-0.29.3/AUTHORS.bz2
/usr/share/info/notmuch-compact.info.bz2
/usr/share/info/notmuch-search.info.bz2
/usr/share/info/notmuch-hooks.info.bz2
/usr/share/info/notmuch-config.info.bz2
/usr/share/info/notmuch-search-terms.info.bz2
/usr/share/info/notmuch-emacs-mua.info.bz2
/usr/share/info/notmuch-properties.info.bz2
/usr/share/info/notmuch-insert.info.bz2
/usr/share/info/notmuch-reindex.info.bz2
/usr/share/info/notmuch-count.info.bz2
/usr/share/info/notmuch-tag.info.bz2
/usr/share/info/notmuch-show.info.bz2
/usr/share/info/notmuch-new.info.bz2
/usr/share/info/notmuch-address.info.bz2
/usr/share/info/notmuch-reply.info.bz2
/usr/share/info/notmuch-dump.info.bz2
/usr/share/info/notmuch.info.bz2
/usr/share/info/notmuch-restore.info.bz2
/usr/share/zsh/site-functions/_notmuch
/usr/share/zsh/site-functions/_email-notmuch
/usr/include/notmuch.h
/usr/lib64/libnotmuch.so.5.2.0
/usr/lib64/libnotmuch.so.5
/usr/lib64/libnotmuch.so

Wouldn't it be better to completely skip building docs when USE="doc" isn't set and only pull in sphinx as BDEPEND when USE="doc" is set?

Comment 1 Ralph Seichter 2020-05-22 17:30:35 UTC

Franz: I have recently become the new maintainer for Gentoo's notmuch package. The linked pull request contains an updated ebuild that addresses your concerns. If you have the time to test it, I'd appreciate you letting me know the results. Thanks.

Comment 2 Franz Trischberger 2020-05-22 18:55:29 UTC

(In reply to Ralph Seichter from comment #1)
> Franz: I have recently become the new maintainer for Gentoo's notmuch
> package. The linked pull request contains an updated ebuild that addresses
> your concerns. If you have the time to test it, I'd appreciate you letting
> me know the results. Thanks.

Ralph, thx for your work.
Unfortunately I moved away from Gentoo, so I can't test it.
I hope there are others who can give your changes a try.
Regards
Franz

Comment 3 Larry the Git Cow gentoo-dev

2020-05-23 13:51:30 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=76371e7a6fe33fc8ebd38b56d5ac45eed4af1e52

commit 76371e7a6fe33fc8ebd38b56d5ac45eed4af1e52
Author:     Ralph Seichter <github@seichter.de>
AuthorDate: 2020-05-22 16:37:45 +0000
Commit:     Andreas K. Hüttel <dilfridge@gentoo.org>
CommitDate: 2020-05-23 13:45:41 +0000

    net-mail/notmuch: Fix runtime dependencies
    
    * Updated ebuild for EAPI 7.
    
    * Fix: Earlier ebuild versions had unconditional dependencies on Sphinx
      and Texinfo even at runtime. Moved dependencies to BDEPEND and tied
      them to USE=doc.
    
    * Fix: Install Texinfo documentation only when USE=doc is specified.
    
    Closes: https://bugs.gentoo.org/711052
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Ralph Seichter <gentoo@seichter.de>
    Closes: https://github.com/gentoo/gentoo/pull/15918
    Signed-off-by: Andreas K. Hüttel <dilfridge@gentoo.org>

 net-mail/notmuch/notmuch-0.29.3-r2.ebuild | 230 ++++++++++++++++++++++++++++++
 1 file changed, 230 insertions(+)