Summary: | app-misc/rox-filer-2.11 : fails to build with -fno-common or gcc-10 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | P Purkayastha <ppurka> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | proxy-maint |
Priority: | Normal | Keywords: | PATCH, PullRequest |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
See Also: | https://github.com/gentoo/gentoo/pull/16499 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 705764 | ||
Attachments: |
emerge-info.txt
app-misc:rox-filer-2.11:20200220-071533.log emerge-history.txt environment etc.portage.tbz2 logs.tbz2 New rox-filer-2.11-r1.ebuild Use patch instead of sed command Fix prestripped files Fix compilation with gcc-10 |
Description
Toralf Förster
2020-02-20 18:22:27 UTC
Created attachment 614678 [details]
emerge-info.txt
Created attachment 614680 [details]
app-misc:rox-filer-2.11:20200220-071533.log
Created attachment 614682 [details]
emerge-history.txt
Created attachment 614684 [details]
environment
Created attachment 614686 [details]
etc.portage.tbz2
Created attachment 614688 [details]
logs.tbz2
Created attachment 671815 [details] New rox-filer-2.11-r1.ebuild Patch for rox-filer fixing multiple bugs - bug 745018 , bug 710330 and changed to EAPI 7. I will attach the other patches in ${FILESDIR} in subsequent posts. --- /usr/portage/app-misc/rox-filer/rox-filer-2.11.ebuild 2019-08-29 21:46:34.476602777 +0800 +++ /usr/local/portage/app-misc/rox-filer/rox-filer-2.11-r1.ebuild 2020-11-17 19:03:55.071253860 +0800 @@ -1,9 +1,9 @@ # Copyright 1999-2019 Gentoo Authors # Distributed under the terms of the GNU General Public License v2 -EAPI=5 +EAPI=7 -inherit desktop epatch virtualx +inherit desktop virtualx DESCRIPTION="ROX-Filer a drag and drop spatial file manager" HOMEPAGE="http://rox.sourceforge.net/desktop" @@ -27,12 +27,12 @@ S="${WORKDIR}/${P}"/ROX-Filer/src -src_prepare() { - epatch "${FILESDIR}/${P}-in-source-build.patch" - - sed -i -e 's:g_strdup(getenv("APP_DIR")):"/usr/share/rox":' \ - main.c || die "sed failed" -} +PATCHES=( + "${FILESDIR}/${P}-in-source-build.patch" + "${FILESDIR}/${P}-APP_DIR-fix.patch" + "${FILESDIR}/${P}-fix-prestripped-files.patch" + "${FILESDIR}/${P}-gcc-10-fix.patch" +) src_configure() { econf LIBS="-lm -ldl" Created attachment 671818 [details, diff]
Use patch instead of sed command
Use patch instead of sed command in ebuild.
Created attachment 671821 [details, diff]
Fix prestripped files
Patch to stop pre-stripping binary
Created attachment 671824 [details, diff]
Fix compilation with gcc-10
Patch to fix compilation with gcc-10
Hi, could you make a Github pull request with your changes, as your patches are un-mergeable as-is without a proper sign-off. https://www.gentoo.org/glep/glep-0076.html#certificate-of-origin Note that you can't modify the existing ebuild with all of your changes in here, you should make a new revbump with EAPI-7 and all your changes, and reset KEYWORDS to ~. The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=21c3d9ba810ae35fe90b7a5c5ba0ebdb6b502f70 commit 21c3d9ba810ae35fe90b7a5c5ba0ebdb6b502f70 Author: Azamat H. Hackimov <azamat.hackimov@gmail.com> AuthorDate: 2020-06-29 21:38:48 +0000 Commit: Aaron Bauman <bman@gentoo.org> CommitDate: 2020-11-28 17:46:40 +0000 app-misc/rox-filer: fix compilation with GCC10 Updated ebuild to EAPI7, fixed compilation with -fno-common. Closes: https://bugs.gentoo.org/710330 Package-Manager: Portage-2.3.99, Repoman-2.3.23 Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com> Closes: https://github.com/gentoo/gentoo/pull/16499 Signed-off-by: Aaron Bauman <bman@gentoo.org> .../rox-filer/files/rox-filer-2.11-gcc10.patch | 27 ++++++++++++++++++++++ app-misc/rox-filer/metadata.xml | 1 + app-misc/rox-filer/rox-filer-2.11.ebuild | 26 ++++++++++++--------- 3 files changed, 43 insertions(+), 11 deletions(-) |