Bug 710302

Summary:	net-analyzer/wireshark-3.2.1 - automagic dependency on app-arch/zstd
Product:	Gentoo Linux	Reporter:	Ben Kohler <bkohler>
Component:	Current packages	Assignee:	Gentoo Netmon project <netmon>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bkohler
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---

Description Ben Kohler gentoo-dev

2020-02-20 15:05:42 UTC

Wireshark seems to be linking to libzstd if it's found.

# emerge -cav zstd

Calculating dependencies... done!
>>> Calculating removal order...

>>> These are the packages that would be unmerged:

 app-arch/zstd
    selected: 1.4.4-r2 
   protected: none 
     omitted: none 

All selected packages: =app-arch/zstd-1.4.4-r2

>>> 'Selected' packages are slated for removal.
>>> 'Protected' and 'omitted' packages will not be removed.

Would you like to unmerge these packages? [Yes/No] y
>>> Waiting 5 seconds before starting...
>>> (Control-C to abort)...
>>> Unmerging in: 5 4 3 2 1
>>> Unmerging (1 of 1) app-arch/zstd-1.4.4-r2...
Packages installed:   1293
Packages in world:    163
Packages in system:   43
Required packages:    1293
Number removed:       1

 * GNU info directory index is up-to-date.

!!! existing preserved libs:
>>> package: app-arch/zstd-1.4.4-r2
 *  - /usr/lib64/libzstd.so.1
 *  - /usr/lib64/libzstd.so.1.4.4
 *      used by /usr/lib64/libwireshark.so.13.0.1 (net-analyzer/wireshark-3.2.1)
Use emerge @preserved-rebuild to rebuild packages using these libraries
#

Comment 1 Ben Kohler gentoo-dev

2020-02-20 15:14:03 UTC

-- The following OPTIONAL packages have been found:
...
* ZSTD (required version >= 1.0.0), A compressor/decompressor from Facebook providing better compression than Snappy at a cost of speed, <https://facebook.github.io/zstd/>
...

This fix seems to work ok:

--- a/net-analyzer/wireshark-3.2.1.ebuild
+++ b/net-analyzer/wireshark-3.2.1.ebuild
@@ -17,7 +17,7 @@
 	+dumpcap +editcap http2 kerberos libxml2 lua lz4 maxminddb +mergecap
 	+minizip +netlink +plugins plugin-ifdemo +pcap +qt5 +randpkt +randpktdump
 	+reordercap sbc selinux +sharkd smi snappy spandsp sshdump ssl sdjournal
-	+text2pcap tfshark +tshark +udpdump zlib
+	+text2pcap tfshark +tshark +udpdump zlib zstd
 "
 S=${WORKDIR}/${P/_/}
 
@@ -167,6 +167,7 @@
 		-DENABLE_SNAPPY=$(usex snappy)
 		-DENABLE_SPANDSP=$(usex spandsp)
 		-DENABLE_ZLIB=$(usex zlib)
+		-DENABLE_ZSTD=$(usex zstd)
 	)
 
 	cmake_src_configure

Comment 2 Larry the Git Cow gentoo-dev

2020-03-10 08:22:53 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dd462bb7b45a8bf989967919f06806a916356017

commit dd462bb7b45a8bf989967919f06806a916356017
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2020-02-27 10:51:26 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2020-03-10 08:22:26 +0000

    net-analyzer/wireshark: Version 3.2.2
    
    Package-Manager: Portage-2.3.89, Repoman-2.3.20
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=710302
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 net-analyzer/wireshark/Manifest               |   1 +
 net-analyzer/wireshark/wireshark-3.2.2.ebuild | 249 ++++++++++++++++++++++++++
 2 files changed, 250 insertions(+)