Bug 709782 – dev-python/pylibacl-0.5.3: testEquivMode fails

• Product: Gentoo Linux
• Status: CONFIRMED ---

[Description Rolf Eike Beer 2020-02-16 09:01:18 UTC]

Created attachment 613962 [details]
build.log

Portage 2.3.84 (python 3.6.9-final-0, default/linux/sparc/17.0, gcc-9.2.0, glibc-2.29-r2, 5.5.2-sparc64 sparc64)
=================================================================
System uname: Linux-5.5.2-sparc64-sparc64-sun4v-with-gentoo-2.4.1
KiB Mem:    33079800 total,  14109600 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Sun, 16 Feb 2020 01:15:01 +0000
Head commit of repository gentoo: 2309cdf3f0197a9073e9b667459d7068f06e8b57
sh bash 4.4_p23-r1
ld GNU ld (Gentoo 2.32 p2) 2.32.0
distcc 3.3.3 sparc-unknown-linux-gnu [disabled]
ccache version 3.7.7 [disabled]
app-shells/bash:          4.4_p23-r1::gentoo
dev-lang/perl:            5.30.1::gentoo
dev-lang/python:          2.7.16::gentoo, 3.6.9::gentoo
dev-util/ccache:          3.7.7::gentoo
dev-util/cmake:           3.14.6::gentoo
sys-apps/baselayout:      2.4.1-r2::gentoo
sys-apps/openrc:          0.42.1::gentoo
sys-apps/sandbox:         2.13::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r4::gentoo
sys-devel/automake:       1.13.4-r2::gentoo, 1.16.1-r1::gentoo
sys-devel/binutils:       2.32-r1::gentoo
sys-devel/gcc:            9.2.0-r2::gentoo
sys-devel/gcc-config:     2.2::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.2.1-r4::gentoo
sys-kernel/linux-headers: 4.19::gentoo (virtual/os-headers)
sys-libs/glibc:           2.29-r2::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.de.gentoo.org/gentoo-portage/
    priority: -1000
    sync-rsync-verify-jobs: 1
    sync-rsync-extra-opts: 
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: yes

ACCEPT_KEYWORDS="sparc"
ACCEPT_LICENSE="* -@EULA"
CBUILD="sparc-unknown-linux-gnu"
CFLAGS="-O2 -mcpu=niagara2 -pipe -Wcast-align"
CHOST="sparc-unknown-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt /var/qmail/alias /var/qmail/control /var/vpopmail/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php7.1/ext-active/ /etc/php/apache2-php7.2/ext-active/ /etc/php/apache2-php7.3/ext-active/ /etc/php/cgi-php7.1/ext-active/ /etc/php/cgi-php7.2/ext-active/ /etc/php/cgi-php7.3/ext-active/ /etc/php/cli-php7.1/ext-active/ /etc/php/cli-php7.2/ext-active/ /etc/php/cli-php7.3/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-O2 -mcpu=niagara2 -pipe -Wcast-align"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS=""
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned sandbox sfperms strict strict-keepdir unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS=""
GENTOO_MIRRORS="ftp://ftp.wh2.tu-dresden.de/pub/mirrors/gentoo ftp://ftp.join.uni-muenster.de/pub/linux/distributions/gentoo"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j20 -l40"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="acl berkdb big-endian bzip2 cli crypt cxx dri fortran gdbm iconv ipv6 libtirpc ncurses nls nptl openmp pam pcre readline sparc split-usr ssl tcpd unicode xattr zlib" ADA_TARGET="gnat_2018" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput keyboard mouse" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-2" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_6" PYTHON_TARGETS="python2_7 python3_6" RUBY_TARGETS="ruby24" USERLAND="GNU" VIDEO_CARDS="fbdev glint mga r128 radeon dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

[Comment 1 Michał Górny 2020-04-12 18:53:51 UTC]

To be honest, I think this issue may actually be arch-specific.  Could you reproduce it on some other arch in your arsenal?  ;-)

Ago, would you be able to run it through all arches under your disposal and let me know if some of them fail?

[Comment 2 Rolf Eike Beer 2020-04-12 19:12:34 UTC]

happens the same on hppa (which also has more errors)

[Comment 3 Sergei Trofimovich (RETIRED) 2020-04-12 22:08:39 UTC]

> Traceback (most recent call last):
>  File "test/test_acls.py", line 189, in testEquivMode
>     self.assertEqual(acl.equiv_mode(), mode)
> AssertionError: 0 != 420

It's an unstream endianness bug in acl.c where mode_t was assumed to be unsigned short. Fixed upstream in https://github.com/iustin/pylibacl/commit/2c3c52bcf087c25a5ce58a68968b53f985b77d73.

[Comment 4 Sergei Trofimovich (RETIRED) 2020-04-12 22:09:10 UTC]

Created attachment 632554 [details, diff]
pylibacl-0.5.3-endianness.patch

[Comment 5 Michał Górny 2020-04-13 06:24:59 UTC]

I'm confused.  Why is your patch different than upstream's?  Is it because of surrounding code, or does upstream still do it wrong?  If just the former, I think it'd make more sense to do a snapshot.

[Comment 6 Agostino Sarubbo 2020-04-13 10:02:04 UTC]

Created attachment 632628 [details]
x86.log

this is on x86

[Comment 7 Sergei Trofimovich (RETIRED) 2020-04-17 17:46:21 UTC]

Upstream fixed it in a few iterations.

Initially it used format string "H" (unsigned short) and mode_t* (unsigned int*) mismatch. Then moved away from "H" format string into using runtime inspection of the object type (API change). Probably to workaround obscure bugs caused in other system. Upstream's final state looks reasonable.

But I did not succeed building upstream master with python2.7. I'm not sure I tried properly though.

One-liner to match actual type passed for "H" format string looks least invasive without changing program's semantics.

[Comment 8 Michał Górny 2020-04-18 05:11:56 UTC]

I've added 0.5.4 (which is the last release supporting Python 2) and the current snapshot.  I'd appreciate if you could test both and compare the results.

[Comment 9 Rolf Eike Beer 2020-04-18 08:59:50 UTC]

The snapshot passes tests, 0.5.4 fails with:

FAIL: testNegativeQualifier (__main__.ModificationTests)
Tests negative qualifier handling
----------------------------------------------------------------------
Traceback (most recent call last):
  File "test/test_acls.py", line 616, in testNegativeQualifier
    e.qualifier = qualifier
AssertionError: OverflowError not raised