Bug 709638

Summary:	sys-block/tgt-1.0.79 : fails to build with -fno-common or gcc-10
Product:	Gentoo Linux	Reporter:	Toralf Förster <toralf>
Component:	Current packages	Assignee:	Matthew Thode ( prometheanfire ) <prometheanfire>
Status:	RESOLVED FIXED
Severity:	normal	CC:	cluster
Priority:	Normal	Keywords:	PATCH, PullRequest
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://github.com/fujita/tgt/commit/5d0d6a2921fa6d39485ab3d7282b5b0990368145
See Also:	https://github.com/gentoo/gentoo/pull/18897
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	705764
Attachments:	emerge-info.txt emerge-history.txt environment etc.portage.tbz2 sys-block:tgt-1.0.79:20200214-081947.log temp.tbz2

Description Toralf Förster gentoo-dev

2020-02-14 18:19:58 UTC

x86_64-pc-linux-gnu-gcc -c -O2 -pipe -march=native -fno-common -DUSE_SIGNALFD -DUSE_TIMERFD -DUSE_EVENTFD -D_GNU_SOURCE -I. -g -O2 -fno-strict-aliasing -Wall -Wstrict-prototypes -Werror -fPIC -DTGT_VERSION=\"\" -DBSDIR=\"/lib/tgt/backing-store\" bs_sheepdog.c -o bs_sheepdog.o
echo x86_64-pc-linux-gnu-gcc -Wl,-E,-rpath=/lib/tgt iscsi/conn.o iscsi/param.o iscsi/session.o iscsi/iscsid.o iscsi/target.o iscsi/chap.o iscsi/sha1.o iscsi/md5.o iscsi/transport.o iscsi/iscsi_tcp.o iscsi/isns.o bs_aio.o iscsi/iser.o iscsi/iser_text.o tgtd.o mgmt.o target.o scsi.o log.o driver.o util.o work.o concat_buf.o parser.o spc.o sbc.o mmc.o osd.o scc.o smc.o ssc.o libssc.o bs_rdwr.o bs_ssc.o bs_null.o bs_sg.o bs.o libcrc32c.o bs_sheepdog.o -o tgtd -laio -libverbs -lrdmacm -lpthread -ldl
x86_64-pc-linux-gnu-gcc -Wl,-E,-rpath=/lib/tgt iscsi/conn.o iscsi/param.o iscsi/session.o iscsi/iscsid.o iscsi/target.o iscsi/chap.o iscsi/sha1.o iscsi/md5.o iscsi/transport.o iscsi/iscsi_tcp.o iscsi/isns.o bs_aio.o iscsi/iser.o iscsi/iser_text.o tgtd.o mgmt.o target.o scsi.o log.o driver.o util.o work.o concat_buf.o parser.o spc.o sbc.o mmc.o osd.o scc.o smc.o ssc.o libssc.o bs_rdwr.o bs_ssc.o bs_null.o bs_sg.o bs.o libcrc32c.o bs_sheepdog.o -o tgtd -laio -libverbs -lrdmacm -lpthread -ldl
x86_64-pc-linux-gnu-gcc -Wl,-E,-rpath=/lib/tgt iscsi/conn.o iscsi/param.o iscsi/session.o iscsi/iscsid.o iscsi/target.o iscsi/chap.o iscsi/sha1.o iscsi/md5.o iscsi/transport.o iscsi/iscsi_tcp.o iscsi/isns.o bs_aio.o iscsi/iser.o iscsi/iser_text.o tgtd.o mgmt.o target.o scsi.o log.o driver.o util.o work.o concat_buf.o parser.o spc.o sbc.o mmc.o osd.o scc.o smc.o ssc.o libssc.o bs_rdwr.o bs_ssc.o bs_null.o bs_sg.o bs.o libcrc32c.o bs_sheepdog.o -o tgtd -Wl,-E,-rpath=/lib/tgt -laio -libverbs -lrdmacm -lpthread -ldl
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: iscsi/iser.o:/var/tmp/portage/sys-block/tgt-1.0.79/work/fujita-tgt-b43dbc6/usr/iscsi/iser.c:95: multiple definition of `__packed'; iscsi/iscsid.o:/var/tmp/portage/sys-block/tgt-1.0.79/work/fujita-tgt-b43dbc6/usr/iscsi/iscsid.c:1077: first defined here
collect2: error: ld returned 1 exit status

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1-libressl-20200210-001509

  -------------------------------------------------------------------

  Please see the tracker bug for details.

gcc-config -l:
 [1] x86_64-pc-linux-gnu-9.2.0 *

clang:
clang version 9.0.1 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/9/bin
llvm:
9.0.1
Available Python interpreters, in order of preference:
  [1]   python3.8
  [2]   python3.6
  [3]   python3.7 (fallback)
  [4]   python2.7 (fallback)

Available Rust versions:
  [1]   rust-1.41.0 *
java-config:
The following VMs are available for generation-2:
1)	AdoptOpenJDK 8.242_p08 [openjdk-bin-8]
*)	AdoptOpenJDK JRE 8.242_p08 [openjdk-jre-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8 
  [2]   openjdk-jre-bin-8  system-vm
ghc:
The Glorious Glasgow Haskell Compilation System, version 8.0.2

repository:
==> /var/db/repos/gentoo/metadata/timestamp.chk <==
Fri, 14 Feb 2020 07:37:27 +0000

emerge -qpvO sys-block/tgt
[ebuild  N    ] sys-block/tgt-1.0.79  USE="infiniband -fcoe -fcp -ibmvio -rbd"

Comment 1 Toralf Förster gentoo-dev

2020-02-14 18:20:01 UTC

Created attachment 613798 [details]
emerge-info.txt

Comment 2 Toralf Förster gentoo-dev

2020-02-14 18:20:05 UTC

Created attachment 613800 [details]
emerge-history.txt

Comment 3 Toralf Förster gentoo-dev

2020-02-14 18:20:08 UTC

Created attachment 613802 [details]
environment

Comment 4 Toralf Förster gentoo-dev

2020-02-14 18:20:10 UTC

Created attachment 613804 [details]
etc.portage.tbz2

Comment 5 Toralf Förster gentoo-dev

2020-02-14 18:20:13 UTC

Created attachment 613806 [details]
sys-block:tgt-1.0.79:20200214-081947.log

Comment 6 Toralf Förster gentoo-dev

2020-02-14 18:20:16 UTC

Created attachment 613808 [details]
temp.tbz2

Comment 7 Larry the Git Cow gentoo-dev

2021-01-01 18:04:32 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e547354a2545379b5cdacbd8118c866ca768559c

commit e547354a2545379b5cdacbd8118c866ca768559c
Author:     Jakov Smolic <jakov.smolic@sartura.hr>
AuthorDate: 2021-01-01 18:04:24 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2021-01-01 18:04:24 +0000

    sys-block/tgt: Fix build with gcc-10
    
    Closes: https://bugs.gentoo.org/709638
    Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>
    Signed-off-by: David Seifert <soap@gentoo.org>

 sys-block/tgt/files/tgt-1.0.79-fno-common.patch | 22 ++++++++++++++++++++++
 sys-block/tgt/tgt-1.0.79.ebuild                 | 12 +++++++-----
 2 files changed, 29 insertions(+), 5 deletions(-)