Bug 709334 – sys-apps/portage with python-3.8: DeprecationWarning: "@coroutine" decorator is deprecated

• Product: Portage Development
• Status: RESOLVED FIXED

[Description Doppler 2020-02-12 02:42:26 UTC]

Full message:
/usr/lib/portage/python3.8/socks5-server.py:33: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
  def handle_proxy_conn(self, reader, writer):
/usr/lib/portage/python3.8/socks5-server.py:197: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead
  def handle_proxied_conn(self, proxied_reader, writer, parent_task):


This is displayed every time any package is installed unless FEATURES='-network-sandbox' is set.
Without digging very deep into this, it appears that it should be relatively simple to use async/await instead of decorators/yield. Those features are Python 3.5+ only, but the only remaining pre-3.5 implementation usable on Portage should be 2.7, which is already past EOL.

[Comment 1 Doppler 2020-03-01 22:03:57 UTC]

Correction: It appears with FEATURES=distcc

[Comment 2 Zac Medico 2020-03-02 06:15:36 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=e836c4ffb32aba02b28b0254a3edb2147dd362b5

commit e836c4ffb32aba02b28b0254a3edb2147dd362b5
Author: Zac Medico <[e-mail]>
Date:   2020-03-01 21:56:12 -0800

    bin/socks5-server.py: PEP 492 coroutines with async and await syntax
    
    https://bugs.gentoo.org/709334
    Signed-off-by: Zac Medico <[e-mail]>

 bin/socks5-server.py | 36 +++++++++++++++++-------------------
 1 file changed, 17 insertions(+), 19 deletions(-)

[Comment 3 Larry the Git Cow 2020-03-04 10:27:35 UTC]

The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2fe510215d12499f0f4f955adfd0f22e761a015e

commit 2fe510215d12499f0f4f955adfd0f22e761a015e
Author:     Zac Medico <[e-mail]>
AuthorDate: 2020-03-04 10:16:59 +0000
Commit:     Zac Medico <[e-mail]>
CommitDate: 2020-03-04 10:25:03 +0000

    sys-apps/portage: Bump to version 2.3.92
    
     #601252 emerge --pretend --fetchonly event loop recursion
     #709334 socks5-server.py async and await coroutine syntax
     #709746 Rename PORTAGE_LOG_FILTER_FILE_CMD from PORTAGE_LOG_FILTER_FILE
     #711322 emerge hang after src_install
     #711362 egencache AttributeError: 'NoneType' object has no attribute
             'ebuild'
     #711400 AttributeError: 'NoneType' object has no attribute 'depth'
    
    Bug: https://bugs.gentoo.org/711148
    Bug: https://bugs.gentoo.org/709334
    Bug: https://bugs.gentoo.org/709746
    Closes: https://bugs.gentoo.org/711322
    Bug: https://bugs.gentoo.org/711362
    Bug: https://bugs.gentoo.org/711400
    Package-Manager: Portage-2.3.92, Repoman-2.3.20
    Signed-off-by: Zac Medico <[e-mail]>

 sys-apps/portage/Manifest                                         | 2 +-
 sys-apps/portage/{portage-2.3.91.ebuild => portage-2.3.92.ebuild} | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)