Summary: | mount-boot.eclass: failure in mount-boot_pkg_pretend when sys-apps/mawk is used: awk: line 3: function gensub never defined | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Red <redblade7> |
Component: | Current packages | Assignee: | Gentoo's Team for Core System packages <base-system> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | redblade7, ulm |
Priority: | Normal | ||
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Attachments: |
Build log
mount-boot.eclass: Make awk expression work with mawk. |
Description
Red
2020-02-11 20:03:04 UTC
Created attachment 613412 [details]
Build log
ulm: Could you please have a look? gensub is coming from your change, https://gitweb.gentoo.org/repo/gentoo.git/commit/eclass/mount-boot.eclass?id=2d90570e81469bf75b2d4a4275151e282632c18e Created attachment 613420 [details, diff]
mount-boot.eclass: Make awk expression work with mawk.
Does attached patch fix the problem for you?
I have tested it with gawk, mawk and nawk.
(In reply to Ulrich Müller from comment #3) > Created attachment 613420 [details, diff] [details, diff] > mount-boot.eclass: Make awk expression work with mawk. > > Does attached patch fix the problem for you? > > I have tested it with gawk, mawk and nawk. I tried putting the patch portion of the email in /etc/portage/patches/sys-firmware/intel-microcode and it didn't detect it. (In reply to Red from comment #4) > I tried putting the patch portion of the email in > /etc/portage/patches/sys-firmware/intel-microcode and it didn't detect it. No, that won't work. /etc/portage/patches/ is only intended for patching the package, not patching ebuilds or eclasses. Anyway, I've posted it to gentoo-dev for review: https://archives.gentoo.org/gentoo-dev/message/94de9ef07d776e1fcd92dc11ff4cde28 The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=53c9011002e037ee2b8d97a5ee5657be6f4dd275 commit 53c9011002e037ee2b8d97a5ee5657be6f4dd275 Author: Ulrich Müller <ulm@gentoo.org> AuthorDate: 2020-02-12 02:08:37 +0000 Commit: Ulrich Müller <ulm@gentoo.org> CommitDate: 2020-02-13 04:31:04 +0000 mount-boot.eclass: Make awk expression work with mawk. gensub() is a GNUism and doesn't exist in all awk variants. Use a loop instead. Tested with gawk, nawk, mawk, and busybox awk. Closes: https://bugs.gentoo.org/709322 Signed-off-by: Ulrich Müller <ulm@gentoo.org> eclass/mount-boot.eclass | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Should be fixed now, please test. Thanks for reporting! |