Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 709300

Summary: app-misc/utimer-0.4-r1 : fails to build with -fno-common or gcc-10
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: Current packagesAssignee: Kfir Lavi <lavi.kfir>
Status: RESOLVED FIXED    
Severity: normal CC: jer, proxy-maint
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 705764    
Attachments: emerge-info.txt
app-misc:utimer-0.4-r1:20200211-023403.log
emerge-history.txt
environment
etc.portage.tbz2
logs.tbz2
temp.tbz2
files/utimer-0.4-fno-common.patch

Description Toralf Förster gentoo-dev 2020-02-11 17:54:26 UTC
  208 | void g_atexit  (GVoidFunc    func);
      |      ^~~~~~~~
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I../..  -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include  -DG_ENABLE_DEBUG   -O2 -pipe -march=native -fno-common -c -o log.o `test -f '../../src/log.c' || echo './'`../../src/log.c
x86_64-pc-linux-gnu-gcc  -O2 -pipe -march=native -fno-common  -Wl,-O1 -Wl,--as-needed -o maintests maintests.o timer.o utils.o log.o -lgobject-2.0 -lglib-2.0  -lgio-2.0 -lgobject-2.0 -lglib-2.0  -lgobject-2.0 -lgthread-2.0 
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: timer.o:(.bss+0x0): multiple definition of `ut_config'; maintests.o:(.bss+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: timer.o:(.bss+0x40): multiple definition of `savedttystate'; maintests.o:(.bss+0x40): first defined here

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1-libressl-20200210-001509

  -------------------------------------------------------------------

  Please see the tracker bug for details.

gcc-config -l:
 [1] x86_64-pc-linux-gnu-9.2.0 *


llvm:
9.0.1
Available Python interpreters, in order of preference:
  [1]   python3.8
  [2]   python3.6
  [3]   python3.7 (fallback)
  [4]   python2.7 (fallback)




ghc:
The Glorious Glasgow Haskell Compilation System, version 8.0.2

repository:
==> /var/db/repos/gentoo/metadata/timestamp.chk <==
Tue, 11 Feb 2020 00:11:22 +0000

emerge -qpvO app-misc/utimer
[ebuild  N    ] app-misc/utimer-0.4-r1  USE="nls -debug"
Comment 1 Toralf Förster gentoo-dev 2020-02-11 17:54:28 UTC
Created attachment 613308 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-02-11 17:54:31 UTC
Created attachment 613310 [details]
app-misc:utimer-0.4-r1:20200211-023403.log
Comment 3 Toralf Förster gentoo-dev 2020-02-11 17:54:34 UTC
Created attachment 613312 [details]
emerge-history.txt
Comment 4 Toralf Förster gentoo-dev 2020-02-11 17:54:37 UTC
Created attachment 613314 [details]
environment
Comment 5 Toralf Förster gentoo-dev 2020-02-11 17:54:40 UTC
Created attachment 613316 [details]
etc.portage.tbz2
Comment 6 Toralf Förster gentoo-dev 2020-02-11 17:54:43 UTC
Created attachment 613318 [details]
logs.tbz2
Comment 7 Toralf Förster gentoo-dev 2020-02-11 17:54:46 UTC
Created attachment 613320 [details]
temp.tbz2
Comment 8 Jeroen Roovers (RETIRED) gentoo-dev 2020-02-12 10:34:14 UTC
Created attachment 613434 [details, diff]
files/utimer-0.4-fno-common.patch
Comment 9 Jeroen Roovers (RETIRED) gentoo-dev 2020-02-12 10:36:00 UTC
Comment on attachment 613434 [details, diff]
files/utimer-0.4-fno-common.patch

It would have made more sense to add these definitions to src/utimer.c but then src/tests/maintests.c would fail to compile. Alternatively the declarations could be moved from src/utimer.h to src/utils.h.

>--- a/src/utils.c
>+++ b/src/utils.c
>@@ -36,6 +36,10 @@
> #include "utils.h"
> #include "utimer.h"
> 
>+GMainLoop         *loop;
>+gboolean          paused;
>+struct termios    savedttystate;
>+Config            ut_config;
> 
> gulong ul_add (gulong a, gulong b)
> {
Comment 10 Jeroen Roovers (RETIRED) gentoo-dev 2020-05-21 12:02:59 UTC
*** Bug 721092 has been marked as a duplicate of this bug. ***
Comment 11 Larry the Git Cow gentoo-dev 2020-12-28 11:50:43 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1f02614a2f744c3bc9073a1cc4984a875747bc96

commit 1f02614a2f744c3bc9073a1cc4984a875747bc96
Author:     Jakov Smolic <jakov.smolic@sartura.hr>
AuthorDate: 2020-12-28 11:50:11 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2020-12-28 11:50:11 +0000

    app-misc/utimer: Port to EAPI 7
    
    * Thanks to Jeroen Roovers for submitting the fno-common patch
    
    Closes: https://bugs.gentoo.org/717250
    Closes: https://bugs.gentoo.org/709300
    Package-Manager: Portage-3.0.9, Repoman-3.0.1
    Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>
    Signed-off-by: David Seifert <soap@gentoo.org>

 app-misc/utimer/files/utimer-0.4-fno-common.patch | 29 +++++++++++++++++++++++
 app-misc/utimer/files/utimer-0.4-locale.patch     | 10 ++++++++
 app-misc/utimer/utimer-0.4-r1.ebuild              | 24 +++++++++----------
 3 files changed, 50 insertions(+), 13 deletions(-)