Bug 708794 – games-action/heroes-0.21-r2 : fails to build with -fno-common or gcc-10

• Product: Gentoo Linux
• Status: RESOLVED FIXED

[Description Toralf Förster 2020-02-09 09:41:06 UTC]

rm -f sys/libhsdlm.a
ar cru sys/libhsdlm.a sys/std/libhsdlm_a-main.o 
x86_64-pc-linux-gnu-ranlib sys/libhsdlm.a
x86_64-pc-linux-gnu-gcc  -O2 -pipe -march=native -fno-common -DNDEBUG -g  -Wl,-O1 -Wl,--as-needed -o heroes argv.o bonus.o camera.o const.o debughash.o debugmsg.o endscroll.o errors.o explosions.o extras.o fader.o fontdata.o gameid.o hedlite.o helptext.o hendian.o heroes.o intro.o items.o levellst.o locales.o menus.o misc.o musicfiles.o parafmt.o pcx.o pendulum.o people.o persona.o pixelize.o prefs.o readmake.o relocate.o render.o renderdata.o rsc_files.o rsc_files_hash.o savegame.o scores.o scrtools.o sprglauto.o sprglenz.o sprite.o spropaque.o sprprog.o sprprogwav.o sprrle.o sprshade.o sprtext.o sprunish.o sprzcol.o timer.o userconf.o userdir.o vars.o visuals.o lvl/libhlvl.a media/libhmcommon.a ../lib/libheroes.a  media/libhsdlj.a media/libhsdls.a media/libhsdlvkm.a  sys/libhsdlm.a -lSDL_mixer -lSDL -lpthread  sys/libhsdlm.a -lm 
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: persona.o:/var/tmp/portage/games-action/heroes-0.21-r2/work/heroes-0.21/src/persona.h:32: multiple definition of `keep_suid'; heroes.o:/var/tmp/portage/games-action/heroes-0.21-r2/work/heroes-0.21/src/persona.h:32: first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: persona.o:/var/tmp/portage/games-action/heroes-0.21-r2/work/heroes-0.21/src/persona.h:31: multiple definition of `keep_sgid'; heroes.o:/var/tmp/portage/games-action/heroes-0.21-r2/work/heroes-0.21/src/persona.h:31: first defined here

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_no-multilib-test-20200203-215003

  -------------------------------------------------------------------

  Please see the tracker bug for details.

gcc-config -l:
 [1] x86_64-pc-linux-gnu-9.2.0 *

clang:
clang version 9.0.1 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/9/bin
llvm:
9.0.1
Available Python interpreters, in order of preference:
  [1]   python3.8
  [2]   python3.6
  [3]   python3.7 (fallback)
  [4]   python2.7 (fallback)

Available Rust versions:
  [1]   rust-1.41.0 *
java-config:
The following VMs are available for generation-2:
*)	AdoptOpenJDK JRE 8.242_p08 [openjdk-jre-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-jre-bin-8  system-vm
ghc:
The Glorious Glasgow Haskell Compilation System, version 8.0.2

repository:
==> /var/db/repos/gentoo/metadata/timestamp.chk <==
Sun, 09 Feb 2020 01:47:10 +0000

emerge -qpvO games-action/heroes
[ebuild  N    ] games-action/heroes-0.21-r2  USE="nls -ggi -sdl"

[Comment 1 Toralf Förster 2020-02-09 09:41:08 UTC]

Created attachment 612966 [details]
emerge-info.txt

[Comment 2 Toralf Förster 2020-02-09 09:41:11 UTC]

Created attachment 612968 [details]
emerge-history.txt

[Comment 3 Toralf Förster 2020-02-09 09:41:14 UTC]

Created attachment 612970 [details]
environment

[Comment 4 Toralf Förster 2020-02-09 09:41:17 UTC]

Created attachment 612972 [details]
etc.portage.tbz2

[Comment 5 Toralf Förster 2020-02-09 09:41:19 UTC]

Created attachment 612974 [details]
games-action:heroes-0.21-r2:20200209-025909.log

[Comment 6 Toralf Förster 2020-02-09 09:41:22 UTC]

Created attachment 612976 [details]
logs.tbz2

[Comment 7 Toralf Förster 2020-02-09 09:41:25 UTC]

Created attachment 612978 [details]
temp.tbz2

[Comment 8 Larry the Git Cow 2020-06-12 03:14:01 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=effe2edd232d7f8decce455309dd6ae252316cfe

commit effe2edd232d7f8decce455309dd6ae252316cfe
Author:     Azamat H. Hackimov <[e-mail]>
AuthorDate: 2020-06-08 09:58:02 +0000
Commit:     Stefan Strogin <[e-mail]>
CommitDate: 2020-06-12 03:13:10 +0000

    games-action/heroes: fix compilation; update ebuild
    
    Fix compilation on GCC 10 (#708794, patch taken from Debian
    https://salsa.debian.org/games-team/heroes/-/blob/master/debian/patches/single-declaration.patch),
    update to EAPI 7, minor cleanups.
    
    Closes: https://bugs.gentoo.org/708794
    Package-Manager: Portage-2.3.99, Repoman-2.3.22
    Signed-off-by: Azamat H. Hackimov <[e-mail]>
    
    Add patch to add a missing header and packed attributes for structures
    [https://salsa.debian.org/games-team/heroes/-/blob/master/debian/patches/compilation-fixes.patch]
    Closes: https://github.com/gentoo/gentoo/pull/16116
    Signed-off-by: Stefan Strogin <[e-mail]>

 .../heroes/files/heroes-0.21-compilation.patch     | 48 ++++++++++++++++++++++
 ...ix.patch => heroes-0.21-cvs-segfault-fix.patch} |  0
 games-action/heroes/files/heroes-0.21-gcc10.patch  | 16 ++++++++
 games-action/heroes/heroes-0.21-r2.ebuild          | 42 +++++++++++--------
 4 files changed, 89 insertions(+), 17 deletions(-)