Bug 708732

Summary:	www-client/dillo-3.0.5-r2 USE=ssl with dev-libs/openssl-1.1 - configure: WARNING: * No libssl found. Disabling ssl support.*
Product:	Gentoo Linux	Reporter:	Ben Kohler <bkohler>
Component:	Current packages	Assignee:	Desktop Misc. Team <desktop-misc>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bkohler
Priority:	Normal	Keywords:	PATCH
Version:	unspecified
Hardware:	All
OS:	Linux
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	592438
Attachments:	build.log (configure phase) dillo-openssl-1.1.patch

Description Ben Kohler gentoo-dev

2020-02-08 15:01:46 UTC

Created attachment 612794 [details]
build.log (configure phase)

All current ebuild versions of dillo with USE=ssl do pass --enable-ssl but later in configure it shows:

checking for SSL_library_init in -lssl... no
configure: WARNING: *** No libssl found. Disabling ssl support.***

This is likely due to this [1] openssl-1.1 change:
"HISTORY
The SSL_library_init() and OpenSSL_add_ssl_algorithms() functions were deprecated in OpenSSL 1.1.0 by OPENSSL_init_ssl()."


[1] https://www.openssl.org/docs/man1.1.1/man3/SSL_library_init.html

Comment 1 Ben Kohler gentoo-dev

2020-02-08 15:03:21 UTC

Created attachment 612796 [details, diff]
dillo-openssl-1.1.patch

This patch is adapted from freebsd's, seems to work well here.  Only tested on 3.0.5-r2 so far, not 9999.

Comment 2 Jeroen Roovers (RETIRED) gentoo-dev

2020-02-09 10:59:49 UTC

(In reply to Ben Kohler from comment #1)
> Created attachment 612796 [details, diff] [details, diff]
> dillo-openssl-1.1.patch
> 
> This patch is adapted from freebsd's, seems to work well here.  Only tested
> on 3.0.5-r2 so far, not 9999.

Upstream switched to mbedtls a while ago, which the -9999 ebuild already reflects.

Comment 3 Jeroen Roovers (RETIRED) gentoo-dev

2020-02-09 11:02:37 UTC

(In reply to Jeroen Roovers from comment #2)
> Upstream switched to mbedtls a while ago, which the -9999 ebuild already
> reflects.

In fact you reported that yourself in bug #705056. :-)

Comment 4 Jeroen Roovers (RETIRED) gentoo-dev

2020-02-09 11:03:23 UTC

Comment on attachment 612796 [details, diff]
dillo-openssl-1.1.patch

Shouldn't this be dropped in favour of support for mbedtls?

Comment 5 Jeroen Roovers (RETIRED) gentoo-dev

2020-02-09 11:13:32 UTC

Comment on attachment 612796 [details, diff]
dillo-openssl-1.1.patch

Partially at https://hg.dillo.org/dillo/rev/b171b8610400

Comment 6 Larry the Git Cow gentoo-dev

2020-02-09 11:45:19 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9489ea43e91dbe22e609e7029759defc6b7ffe8b

commit 9489ea43e91dbe22e609e7029759defc6b7ffe8b
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2020-02-09 11:43:47 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2020-02-09 11:45:15 +0000

    www-client/dillo: Fix compiling against >dev-libs/openssl-1.1
    
    Package-Manager: Portage-2.3.87, Repoman-2.3.20
    Closes: https://bugs.gentoo.org/708732
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 www-client/dillo/dillo-3.0.5-r3.ebuild             | 70 ++++++++++++++++++++++
 .../dillo/files/dillo-3.0.5-openssl-1.1.patch      | 26 ++++++++
 2 files changed, 96 insertions(+)