Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 708526

Summary: net-libs/libiscsi-1.18.0 : fails to build with -fno-common or gcc-10
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: Current packagesAssignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it <maintainer-needed>
Status: RESOLVED FIXED    
Severity: normal Keywords: PullRequest
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/18934
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 705764, 762907    
Attachments: emerge-info.txt
emerge-history.txt
environment
etc.portage.tbz2
logs.tbz2
net-libs:libiscsi-1.18.0:20200206-080740.log
temp.tbz2

Description Toralf Förster gentoo-dev 2020-02-06 22:23:44 UTC
libtool: link: echo "{ global:" > .libs/libiscsi.ver
libtool: link:  cat ./libiscsi.syms | sed -e "s/\(.*\)/\1;/" >> .libs/libiscsi.ver
libtool: link:  echo "local: *; };" >> .libs/libiscsi.ver
libtool: link:  x86_64-pc-linux-gnu-gcc -shared  -fPIC -DPIC  .libs/libiscsi_la-connect.o .libs/libiscsi_la-crc32c.o .libs/libiscsi_la-discovery.o .libs/libiscsi_la-init.o .libs/libiscsi_la-login.o .libs/libiscsi_la-nop.o .libs/libiscsi_la-pdu.o .libs/libiscsi_la-iscsi-command.o .libs/libiscsi_la-scsi-lowlevel.o .libs/libiscsi_la-socket.o .libs/libiscsi_la-sync.o .libs/libiscsi_la-task_mgmt.o .libs/libiscsi_la-logging.o .libs/libiscsi_la-iser.o   -libverbs -lrdmacm -Wl,--as-needed -lgcrypt  -O2 -march=native -Wl,-O1 -Wl,--defsym=__gentoo_check_ldflags__=0   -Wl,-soname -Wl,libiscsi.so.8 -Wl,-version-script -Wl,.libs/libiscsi.ver -o .libs/libiscsi.so.8.0.0
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: .libs/libiscsi_la-iser.o:(.bss+0x0): multiple definition of `__packed'; .libs/libiscsi_la-init.o:(.bss+0x0): first defined here
collect2: error: ld returned 1 exit status

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_developer-libressl-20200202-211607

  -------------------------------------------------------------------

  Please see the tracker bug for details.

gcc-config -l:
 [1] x86_64-pc-linux-gnu-9.2.0 *

clang:
clang version 9.0.1 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/9/bin
llvm:
9.0.1
Available Python interpreters, in order of preference:
  [1]   python3.8
  [2]   python3.7
  [3]   python3.6
  [4]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems)
  [2]   ruby25 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.41.0 *
java-config:
The following VMs are available for generation-2:
*)	IcedTea JDK 3.14.0 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm
ghc:
The Glorious Glasgow Haskell Compilation System, version 8.0.2

repository:
==> /var/db/repos/gentoo/metadata/timestamp.chk <==
Thu, 06 Feb 2020 06:51:00 +0000

emerge -qpvO net-libs/libiscsi
[ebuild  N    ] net-libs/libiscsi-1.18.0  USE="-static-libs"
Comment 1 Toralf Förster gentoo-dev 2020-02-06 22:23:47 UTC
Created attachment 612230 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-02-06 22:23:50 UTC
Created attachment 612232 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2020-02-06 22:23:52 UTC
Created attachment 612234 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2020-02-06 22:23:55 UTC
Created attachment 612236 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2020-02-06 22:23:58 UTC
Created attachment 612238 [details]
logs.tbz2
Comment 6 Toralf Förster gentoo-dev 2020-02-06 22:24:01 UTC
Created attachment 612240 [details]
net-libs:libiscsi-1.18.0:20200206-080740.log
Comment 7 Toralf Förster gentoo-dev 2020-02-06 22:24:05 UTC
Created attachment 612242 [details]
temp.tbz2
Comment 8 Jannik Glückert 2020-12-19 22:47:07 UTC
Me & a few other users could not reproduce, can you please check?

Either way, the upstream fix is https://github.com/sahlberg/libiscsi/pull/307/commits/51391285d85955c6d33f2a4bfe86602eb5d230fb
Comment 9 Larry the Git Cow gentoo-dev 2021-01-07 10:08:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=21c320c1a5455367d0df77c43005b26a8685cdff

commit 21c320c1a5455367d0df77c43005b26a8685cdff
Author:     Jakov Smolic <jakov.smolic@sartura.hr>
AuthorDate: 2021-01-07 10:08:22 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2021-01-07 10:08:22 +0000

    net-libs/libiscsi: Port to EAPI 7
    
    * Disable static-libs
    * Fix build with gcc-10
    
    Closes: https://bugs.gentoo.org/708526
    Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>
    Signed-off-by: David Seifert <soap@gentoo.org>

 .../files/libiscsi-1.18.0-fno-common.patch         | 14 +++++++++++++
 net-libs/libiscsi/libiscsi-1.18.0.ebuild           | 23 ++++++++++++++--------
 2 files changed, 29 insertions(+), 8 deletions(-)