Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 707724

Summary: games-arcade/opentyrian-2.1.20130907-r1 : fails to build with -fno-common or gcc-10
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: Current packagesAssignee: Tony Vroon (RETIRED) <chainsaw>
Status: RESOLVED FIXED    
Severity: normal CC: denilsonsa, games
Priority: Normal Keywords: PullRequest
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/17182
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 705764    
Attachments: emerge-info.txt
emerge-history.txt
environment
etc.portage.tbz2
games-arcade:opentyrian-2.1.20130907-r1:20200201-045405.log
temp.tbz2

Description Toralf Förster gentoo-dev 2020-02-01 09:21:54 UTC
  127 |           ( abs((YUV1 & Vmask) - (YUV2 & Vmask)) > trV ) );
      |             ^~~
cc -c -o obj/xmas.o -std=c99 -I./src -DTARGET_UNIX -MMD -pedantic -Wall -Wextra -Wno-missing-field-initializers -DWITH_NETWORK '-DHG_REV="2.1.20130907"' -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT -O2 -pipe -march=native -fno-common -DDATA_PATH=\"/usr/share/opentyrian\" src/xmas.c
cc -o opentyrian -Wl,-O1 -Wl,--as-needed obj/animlib.o obj/arg_parse.o obj/backgrnd.o obj/cJSON.o obj/config.o obj/destruct.o obj/editship.o obj/episodes.o obj/file.o obj/font.o obj/fonthand.o obj/game_menu.o obj/helptext.o obj/joystick.o obj/jukebox.o obj/keyboard.o obj/lds_play.o obj/loudness.o obj/lvllib.o obj/lvlmast.o obj/mainint.o obj/menus.o obj/mingw_fixes.o obj/mouse.o obj/mtrand.o obj/musmast.o obj/network.o obj/nortsong.o obj/nortvars.o obj/opentyr.o obj/opl.o obj/palette.o obj/params.o obj/pcxload.o obj/pcxmast.o obj/picload.o obj/player.o obj/scroller.o obj/setup.o obj/shots.o obj/sizebuf.o obj/sndmast.o obj/sprite.o obj/starlib.o obj/tyrian2.o obj/varz.o obj/vga256d.o obj/vga_palette.o obj/video.o obj/video_scale.o obj/video_scale_hqNx.o obj/xmas.o -lm -lSDL -lpthread -lSDL_net
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: obj/destruct.o:(.bss+0x0): multiple definition of `tremtab_add'; obj/config.o:(.bss+0x1474): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: obj/destruct.o:(.bss+0x4): multiple definition of `tremtab_pos'; obj/config.o:(.bss+0x1478): first defined here

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_gnome-20200129-211601

  -------------------------------------------------------------------

  Please see the tracker bug for details.

gcc-config -l:
 [1] x86_64-pc-linux-gnu-9.2.0 *

clang:
clang version 9.0.1 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/9/bin
llvm:
9.0.1
Available Python interpreters, in order of preference:
  [1]   python3.8
  [2]   python3.7
  [3]   python3.6
  [4]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems)
  [2]   ruby25 (with Rubygems) *

java-config:
The following VMs are available for generation-2:
1)	IcedTea JDK 3.15.0 [icedtea-8]
*)	IcedTea JDK 3.14.0 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-8 
  [2]   icedtea-bin-8  system-vm
ghc:
The Glorious Glasgow Haskell Compilation System, version 8.0.2

repository:
==> /var/db/repos/gentoo/metadata/timestamp.chk <==
Sat, 01 Feb 2020 03:27:53 +0000

emerge -qpvO games-arcade/opentyrian
[ebuild  N    ] games-arcade/opentyrian-2.1.20130907-r1
Comment 1 Toralf Förster gentoo-dev 2020-02-01 09:21:57 UTC
Created attachment 610262 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-02-01 09:22:00 UTC
Created attachment 610264 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2020-02-01 09:22:03 UTC
Created attachment 610266 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2020-02-01 09:22:05 UTC
Created attachment 610268 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2020-02-01 09:22:08 UTC
Created attachment 610270 [details]
games-arcade:opentyrian-2.1.20130907-r1:20200201-045405.log
Comment 6 Toralf Förster gentoo-dev 2020-02-01 09:22:11 UTC
Created attachment 610272 [details]
temp.tbz2
Comment 7 Denilson Sá Maia 2020-07-15 00:18:01 UTC
This has been reported upstream: https://github.com/opentyrian/opentyrian/issues/2

And they have created a patch/commit: https://github.com/opentyrian/opentyrian/commit/962ee8fc46ca51691bde1c8c1022dacbe8a037ed.patch

I can confirm the code fully compiles with the above patch. (I haven't tried running it.)

(Sidenote: there are already 99 commits since the 2013 release)
Comment 8 Larry the Git Cow gentoo-dev 2020-08-22 18:56:23 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3e70d543f74f8445856c0ebd943d9409b7c0eb13

commit 3e70d543f74f8445856c0ebd943d9409b7c0eb13
Author:     Azamat H. Hackimov <azamat.hackimov@gmail.com>
AuthorDate: 2020-08-20 11:52:33 +0000
Commit:     James Le Cuirot <chewi@gentoo.org>
CommitDate: 2020-08-22 18:55:59 +0000

    games-arcade/opentyrian: fix issues
    
    Update to EAPI 7, drop mercurial dependency (not required anymore),
    fixed compilation with -fno-common, updated HOMEPAGE, LICENSE
    
    Closes: https://bugs.gentoo.org/514966
    Closes: https://bugs.gentoo.org/707724
    Closes: https://bugs.gentoo.org/738182
    Package-Manager: Portage-2.3.103, Repoman-2.3.23
    Signed-off-by: Azamat H. Hackimov <azamat.hackimov@gmail.com>
    Signed-off-by: James Le Cuirot <chewi@gentoo.org>

 .../opentyrian/files/2.1.20130907-gcc10.patch      | 362 +++++++++++++++++++++
 games-arcade/opentyrian/metadata.xml               |   2 +-
 .../opentyrian/opentyrian-2.1.20130907-r2.ebuild   |  54 +++
 3 files changed, 417 insertions(+), 1 deletion(-)