Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 707460

Summary: games-action/garden-1.0.9-r1 : fails to build with -fno-common or gcc-10
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: Current packagesAssignee: Gentoo Games <games>
Status: RESOLVED FIXED    
Severity: normal Keywords: PullRequest
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
See Also: https://github.com/gentoo/gentoo/pull/17596
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 705764    
Attachments: emerge-info.txt
emerge-history.txt
environment
etc.portage.tbz2
games-action:garden-1.0.9-r1:20200130-103512.log
logs.tbz2
temp.tbz2

Description Toralf Förster gentoo-dev 2020-01-30 19:19:00 UTC
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I.  -D'DATADIR="/usr/share/garden"'   -O2 -pipe -march=native -fno-common -std=gnu89 -c -o stuff.o stuff.c
/bin/sh ../libtool  --tag=CC   --mode=link x86_64-pc-linux-gnu-gcc  -O2 -pipe -march=native -fno-common -std=gnu89  -Wl,-O1 -Wl,--as-needed -o garden cloud.o display.o display_init.o ebullet.o eclass.o enemy.o game.o input.o level.o main.o menu.o palette.o pbullet.o sound.o stuff.o    -lm  -L/usr/lib64 -lalleg
libtool: link: x86_64-pc-linux-gnu-gcc -O2 -pipe -march=native -fno-common -std=gnu89 -Wl,-O1 -o garden cloud.o display.o display_init.o ebullet.o eclass.o enemy.o game.o input.o level.o main.o menu.o palette.o pbullet.o sound.o stuff.o  -Wl,--as-needed -lm -L/usr/lib64 -lalleg
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: main.o:(.bss+0x5940): multiple definition of `eclass'; eclass.o:(.data+0x0): first defined here
collect2: error: ld returned 1 exit status

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_systemd-20200126-201521

  -------------------------------------------------------------------

  Please see the tracker bug for details.

gcc-config -l:
 [1] x86_64-pc-linux-gnu-9.2.0 *

clang:
clang version 9.0.1 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/9/bin
llvm:
9.0.1
Available Python interpreters, in order of preference:
  [1]   python3.8
  [2]   python3.6
  [3]   python3.7 (fallback)
  [4]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems)
  [2]   ruby25 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.40.0 *
java-config:
The following VMs are available for generation-2:
*)	AdoptOpenJDK 8.242_p08 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   openjdk-bin-8  system-vm
ghc:
The Glorious Glasgow Haskell Compilation System, version 8.0.2

repository:
==> /var/db/repos/gentoo/metadata/timestamp.chk <==
Thu, 30 Jan 2020 09:51:31 +0000

emerge -qpvO games-action/garden
[ebuild  N    ] games-action/garden-1.0.9-r1
Comment 1 Toralf Förster gentoo-dev 2020-01-30 19:19:05 UTC
Created attachment 609068 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-01-30 19:19:10 UTC
Created attachment 609070 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2020-01-30 19:19:15 UTC
Created attachment 609072 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2020-01-30 19:19:19 UTC
Created attachment 609074 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2020-01-30 19:19:24 UTC
Created attachment 609076 [details]
games-action:garden-1.0.9-r1:20200130-103512.log
Comment 6 Toralf Förster gentoo-dev 2020-01-30 19:19:28 UTC
Created attachment 609078 [details]
logs.tbz2
Comment 7 Toralf Förster gentoo-dev 2020-01-30 19:19:33 UTC
Created attachment 609080 [details]
temp.tbz2
Comment 8 Larry the Git Cow gentoo-dev 2020-09-20 15:32:24 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=48eaec8d39c191ef1c59ac457f882a6d61ad15c4

commit 48eaec8d39c191ef1c59ac457f882a6d61ad15c4
Author:     Alexey Sokolov <sokolov@google.com>
AuthorDate: 2020-09-18 23:59:18 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2020-09-20 15:30:51 +0000

    games-action/garden: fix build with gcc 10
    
    Closes: https://github.com/gentoo/gentoo/pull/17596
    Closes: https://bugs.gentoo.org/707460
    Package-Manager: Portage-3.0.4, Repoman-3.0.1
    Signed-off-by: Alexey Sokolov <alexey+gentoo@asokolov.org>
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 .../garden/files/garden-1.0.9-fnocommon.patch      | 11 +++++
 games-action/garden/garden-1.0.9-r2.ebuild         | 48 ++++++++++++++++++++++
 2 files changed, 59 insertions(+)