Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 707272

Summary: net-im/telegram-desktop uses a bundled version of media-libs/rlottie
Product: Gentoo Linux Reporter: Pavel Volkov <ao>
Component: Current packagesAssignee: Georgy Yakovlev <gyakovlev>
Status: RESOLVED FIXED    
Severity: normal CC: esigra, jstein, juippis, sam
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: Linux   
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 251464    

Description Pavel Volkov 2020-01-29 18:21:15 UTC
Reading the new net-im/telegram-desktop-1.9.9.ebuild, it seems it uses bundled media-libs/rlottie instead of packaged.
Since I've used another overlayed telegram ebuild before, which linked to standalone rlottie, probably we can switch painlessly to media-libs/rlottie from portage tree.

Reproducible: Always
Comment 1 Georgy Yakovlev archtester gentoo-dev 2020-01-30 05:05:39 UTC
It is planned, problem is that it does not have a release or stable ABI.
Ideally I’d wait til it gets a tag, but we can add a dep if at least it gets a subslot.

Also it’ll need a pkgconfig patch, pretty trivial one.

Unbundling tgvoip also planned, just need more time.
Comment 2 Georgy Yakovlev archtester gentoo-dev 2020-04-21 07:22:20 UTC
re-checked, we still have to use bundled rlottie, otherwise it may crash on some stickers with system-installed one.
pkg-config patch no longer needed though.

changes we need could be probably backported to our rlottie ebuild

https://github.com/Samsung/rlottie/pull/252/files

but idk, no longer applies to current master and can be a bit painful to maintain in the long run

adding juippis to CC as rlottie maintainer, just fyi, no action needed right now.
Comment 3 Joonas Niilola gentoo-dev 2020-06-18 12:30:14 UTC
They released 0.1 upstream. Maybe it's easier to point a working dependency, or carry patches now?

I added a subslot because the ABI has broken already before a release, I just _hope_ they will now update their sonames with breaking releases.
Comment 4 Georgy Yakovlev archtester gentoo-dev 2020-06-18 22:49:06 UTC
thanks for the ping wrt 0.1, that's something =)

I'll talk with telegram guys. they use older patched version of rlottie, maybe they can re-base on new version.


patches need to be re-based every release. unbundling is not super-urgent and I'm ok with bundled lib for now until upstream makes up their mind.

telegram is kinda complicated beast and it has to work on linux and windows and macOS, so moving internal libs it not that easy. Everything else except couple header-only libs is unbundled.
Comment 5 Larry the Git Cow gentoo-dev 2020-10-26 08:03:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4364658df0ff6f92297648a32dbd28efac732e80

commit 4364658df0ff6f92297648a32dbd28efac732e80
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2020-10-26 08:00:00 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2020-10-26 08:01:28 +0000

    net-im/telegram-desktop: bump to 2.4.4
    
    webrtc is imposibble to turn off for now, unfortunately.
    webrtc alsa and pulseaudio will be forced on for now.
    add system-rlottie useflag.
    
    for now tg_owt bundles the following:
    openh264
    abseil-cpp
    libsrtp
    libvpx
    libyuv
    pffft
    rnnoise
    usrsctp
    
    Bug: https://bugs.gentoo.org/736774
    Bug: https://bugs.gentoo.org/749288
    Closes: https://bugs.gentoo.org/739466
    Closes: https://bugs.gentoo.org/707272
    Package-Manager: Portage-3.0.8, Repoman-3.0.2
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 net-im/telegram-desktop/Manifest                   |   2 +
 net-im/telegram-desktop/metadata.xml               |   2 +
 .../telegram-desktop/telegram-desktop-2.4.4.ebuild | 184 +++++++++++++++++++++
 3 files changed, 188 insertions(+)