Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!

Bug 707262

Summary: x11-wm/awesome-4.3-r1 : fails to build with -fno-common or gcc-10
Product: Gentoo Linux Reporter: Toralf Förster <toralf>
Component: Current packagesAssignee: Maxim Koltsov (RETIRED) <maksbotan>
Status: RESOLVED FIXED    
Severity: normal CC: maracay, sam
Priority: Normal Keywords: PATCH
Version: unspecified   
Hardware: All   
OS: Linux   
URL: https://github.com/awesomeWM/awesome/commit/d256d9055095f27a33696e0aeda4ee20ed4fb1a0
See Also: https://bugs.gentoo.org/show_bug.cgi?id=763861
https://bugs.gentoo.org/show_bug.cgi?id=763927
Whiteboard:
Package list:
Runtime testing required: ---
Bug Depends on:    
Bug Blocks: 705764    
Attachments: emerge-info.txt
emerge-history.txt
environment
etc.portage.tbz2
logs.tbz2
temp.tbz2
x11-wm:awesome-4.3-r1:20200129-155526.log

Description Toralf Förster gentoo-dev 2020-01-29 18:16:59 UTC
FAILED: awesome 
: && /usr/bin/x86_64-pc-linux-gnu-gcc -O2 -pipe -march=native -fno-common  -Wl,-O1 -Wl,--as-needed    -rdynamic CMakeFiles/awesome.dir/awesome.c.o CMakeFiles/awesome.dir/banning.c.o CMakeFiles/awesome.dir/color.c.o CMakeFiles/awesome.dir/dbus.c.o CMakeFiles/awesome.dir/draw.c.o CMakeFiles/awesome.dir/event.c.o CMakeFiles/awesome.dir/ewmh.c.o CMakeFiles/awesome.dir/keygrabber.c.o CMakeFiles/awesome.dir/luaa.c.o CMakeFiles/awesome.dir/mouse.c.o CMakeFiles/awesome.dir/mousegrabber.c.o CMakeFiles/awesome.dir/property.c.o CMakeFiles/awesome.dir/root.c.o CMakeFiles/awesome.dir/selection.c.o CMakeFiles/awesome.dir/spawn.c.o CMakeFiles/awesome.dir/stack.c.o CMakeFiles/awesome.dir/strut.c.o CMakeFiles/awesome.dir/systray.c.o CMakeFiles/awesome.dir/xwindow.c.o CMakeFiles/awesome.dir/xkb.c.o CMakeFiles/awesome.dir/xrdb.c.o CMakeFiles/awesome.dir/common/atoms.c.o CMakeFiles/awesome.dir/common/backtrace.c.o CMakeFiles/awesome.dir/common/buffer.c.o CMakeFiles/awesome.dir/common/luaclass.c.o CMakeFiles/awesome.dir/common/lualib.c.o CMakeFiles/awesome.dir/common/luaobject.c.o CMakeFiles/awesome.dir/common/util.c.o CMakeFiles/awesome.dir/common/version.c.o CMakeFiles/awesome.dir/common/xcursor.c.o CMakeFiles/awesome.dir/common/xembed.c.o CMakeFiles/awesome.dir/common/xutil.c.o CMakeFiles/awesome.dir/objects/button.c.o CMakeFiles/awesome.dir/objects/client.c.o CMakeFiles/awesome.dir/objects/drawable.c.o CMakeFiles/awesome.dir/objects/drawin.c.o CMakeFiles/awesome.dir/objects/key.c.o CMakeFiles/awesome.dir/objects/screen.c.o CMakeFiles/awesome.dir/objects/tag.c.o CMakeFiles/awesome.dir/objects/window.c.o  -o awesome  -lxcb  -lxcb  -lgdk_pixbuf-2.0  -lgobject-2.0  -lglib-2.0  -lX11  -lxcb-cursor  -lxcb-randr  -lxcb-xtest  -lxcb-xinerama  -lxcb-shape  -lxcb-util  -lxcb-keysyms  -lxcb-icccm  -lxcb-xkb  -lxkbcommon-x11  -lxkbcommon  -lcairo  -lxcb-render  -lstartup-notification-1  -lxdg-basedir  -lxcb-xrm  -lxcb  -lm  -llua  -lm  -ldbus-1  -lgdk_pixbuf-2.0  -lgobject-2.0  -lglib-2.0  -lX11  -lxcb-cursor  -lxcb-randr  -lxcb-xtest  -lxcb-xinerama  -lxcb-shape  -lxcb-util  -lxcb-keysyms  -lxcb-icccm  -lxcb-xkb  -lxkbcommon-x11  -lxkbcommon  -lcairo  -lxcb-render  -lstartup-notification-1  -lxdg-basedir  -lxcb-xrm  -lm  -llua  -lm  -ldbus-1 && :
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: CMakeFiles/awesome.dir/banning.c.o:(.bss+0x0): multiple definition of `client_class'; CMakeFiles/awesome.dir/awesome.c.o:(.bss+0x1e0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: CMakeFiles/awesome.dir/banning.c.o:(.bss+0x80): multiple definition of `window_class'; CMakeFiles/awesome.dir/awesome.c.o:(.bss+0x260): first defined here

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_plasma_systemd-20200127-214345

  -------------------------------------------------------------------

  Please see the tracker bug for details.

gcc-config -l:
 [1] x86_64-pc-linux-gnu-9.2.0 *

clang:
clang version 9.0.1 
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/9/bin
llvm:
9.0.1
Available Python interpreters, in order of preference:
  [1]   python3.8
  [2]   python3.6
  [3]   python2.7 (fallback)
Available Ruby profiles:
  [1]   ruby24 (with Rubygems)
  [2]   ruby25 (with Rubygems) *

java-config:
The following VMs are available for generation-2:
*)	IcedTea JDK 3.14.0 [icedtea-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-bin-8  system-vm
ghc:
The Glorious Glasgow Haskell Compilation System, version 7.10.3

repository:
==> /var/db/repos/gentoo/metadata/timestamp.chk <==
Wed, 29 Jan 2020 15:06:24 +0000

emerge -qpvO x11-wm/awesome
[ebuild  N    ] x11-wm/awesome-4.3-r1  USE="dbus -doc -gnome -luajit -test"
Comment 1 Toralf Förster gentoo-dev 2020-01-29 18:17:02 UTC
Created attachment 608272 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2020-01-29 18:17:05 UTC
Created attachment 608274 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2020-01-29 18:17:08 UTC
Created attachment 608276 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2020-01-29 18:17:12 UTC
Created attachment 608278 [details]
etc.portage.tbz2
Comment 5 Toralf Förster gentoo-dev 2020-01-29 18:17:15 UTC
Created attachment 608280 [details]
logs.tbz2
Comment 6 Toralf Förster gentoo-dev 2020-01-29 18:17:18 UTC
Created attachment 608282 [details]
temp.tbz2
Comment 7 Toralf Förster gentoo-dev 2020-01-29 18:17:21 UTC
Created attachment 608284 [details]
x11-wm:awesome-4.3-r1:20200129-155526.log
Comment 8 bob 2020-07-30 04:52:27 UTC
happening for me too, with luajit and gcc 10

compiles just fine with clang 10
Comment 9 Eddie Chapman 2020-10-17 08:05:49 UTC
One of the hunks in the upstream patch, the one against objects/tag.c, fails to apply to Gentoo's package source, only due to context and line number changes. Just replace it with this corrected hunk which works:

--- a/objects/tag.c
+++ b/objects/tag.c
@@ -190,6 +190,8 @@
 #include "ewmh.h"
 #include "luaa.h"

+lua_class_t tag_class;
+
 /**
  * @signal request::select
  */
Comment 10 Larry the Git Cow gentoo-dev 2020-12-26 21:32:58 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9ff59e69344b86713527434dab3c6c570c5e1470

commit 9ff59e69344b86713527434dab3c6c570c5e1470
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2020-12-26 21:32:48 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2020-12-26 21:32:56 +0000

    x11-wm/awesome: add -fno-common (gcc 10) patch
    
    Thanks-to: Eddie Chapman <maracay@ehuk.net>
    Closes: https://bugs.gentoo.org/707262
    Package-Manager: Portage-3.0.9, Repoman-3.0.2
    Signed-off-by: Sam James <sam@gentoo.org>

 x11-wm/awesome/awesome-4.3-r1.ebuild              |   1 +
 x11-wm/awesome/awesome-4.3-r100.ebuild            |   1 +
 x11-wm/awesome/files/awesome-4.3-fno-common.patch | 240 ++++++++++++++++++++++
 3 files changed, 242 insertions(+)
Comment 11 Larry the Git Cow gentoo-dev 2020-12-28 11:50:42 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ca44b49126e8b55af71ad6326d34830154c97c90

commit ca44b49126e8b55af71ad6326d34830154c97c90
Author:     Jakov Smolic <jakov.smolic@sartura.hr>
AuthorDate: 2020-12-28 11:50:18 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2020-12-28 11:50:18 +0000

    x11-wm/awesome: fix build with gcc-10
    
    * Port to cmake eclass
    * Minor additional cleanup
    * Thanks to Jeroen Roovers for submitting the patch link and to Eddie
      Chapman for providing the patch fix
    
    Closes: https://bugs.gentoo.org/707262
    Package-Manager: Portage-3.0.9, Repoman-3.0.1
    Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>
    Signed-off-by: David Seifert <soap@gentoo.org>

 ...awesome-4.3-r1.ebuild => awesome-4.3-r2.ebuild} | 71 ++++++++++++----------
 x11-wm/awesome/files/awesome-4.3-fno-common.patch  | 69 ++-------------------
 2 files changed, 42 insertions(+), 98 deletions(-)
Comment 12 bob 2020-12-30 14:22:03 UTC
still happening with luajit
Comment 13 bob 2020-12-30 14:24:46 UTC
(In reply to bob from comment #12)
> still happening with luajit

oh wait, no, i got confused by my local ebuild
Comment 14 StellaJames 2021-07-15 04:21:24 UTC Comment hidden (spam)
Comment 15 NevaehGarcia 2021-07-19 11:35:53 UTC
It was an amazing site with amazing content https://bit.ly/3xGwgwl