Summary: | sys-apps/ipmitool-1.8.18-r1 : fails to build with -fno-common or gcc-10 | ||
---|---|---|---|
Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
Component: | Current packages | Assignee: | Sysadmin Bugs <sysadmin> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | b.buschinski, jer, n-roeser, sandino |
Priority: | Normal | Keywords: | PATCH |
Version: | unspecified | ||
Hardware: | All | ||
OS: | Linux | ||
URL: | https://github.com/ipmitool/ipmitool/commit/c3939dac2c060651361fc71516806f9ab8c38901 | ||
Whiteboard: | |||
Package list: | Runtime testing required: | --- | |
Bug Depends on: | |||
Bug Blocks: | 705764 | ||
Attachments: |
emerge-info.txt
emerge-history.txt environment etc.portage.tbz2 logs.tbz2 sys-apps:ipmitool-1.8.18-r1:20200128-051950.log temp.tbz2 files/ipmitool-1.8.18-fno-common.patch impitool-1.8.17-r1 build log files/ipmitool-1.8.18-fno-common.patch |
Description
Toralf Förster
2020-01-28 18:27:42 UTC
Created attachment 606244 [details]
emerge-info.txt
Created attachment 606246 [details]
emerge-history.txt
Created attachment 606248 [details]
environment
Created attachment 606250 [details]
etc.portage.tbz2
Created attachment 606252 [details]
logs.tbz2
Created attachment 606254 [details]
sys-apps:ipmitool-1.8.18-r1:20200128-051950.log
Created attachment 606256 [details]
temp.tbz2
Created attachment 632992 [details, diff]
files/ipmitool-1.8.18-fno-common.patch
Also note that: 1) Debian is at patchlevel 8 now. 2) the project appears to have moved to https://github.com/ipmitool/ipmitool - the old HOMEPAGE http://ipmitool.sf.net/ redirects to the SF project page, which has a note about the Github migration. Created attachment 649374 [details] impitool-1.8.17-r1 build log sys-apps/ipmitool-1.8.17-r1 no longer makes for (apparently) the same reasons. Perhaps the package should be masked completely until 1.8.19 is released. The download page on the github sources has the following verbiage (https://github.com/ipmitool/ipmitool/releases/tag/IPMITOOL_1_8_18) "... released this on Jun 25, 2019 · 204 commits to master since this release. This is Release 1.8.18 freshly rebuilt from github sources." The source 1.8.18 files (from Oct 2016) I have (in /var/cache/distfiles) and that the ebuilds expect are the from the sf.net project page. I forgot to note I'm also on GCC10 Comment on attachment 649374 [details] impitool-1.8.17-r1 build log lanplus_crypt_impl.c: In function ‘lanplus_encrypt_aes_cbc_128’: lanplus_crypt_impl.c:158:17: error: storage size of ‘ctx’ isn’t known 158 | EVP_CIPHER_CTX ctx; | ^~~ lanplus_crypt_impl.c:158:17: warning: unused variable ‘ctx’ [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wunused-variable^G-Wunused-variable8;;^G] lanplus_crypt_impl.c: In function ‘lanplus_decrypt_aes_cbc_128’: lanplus_crypt_impl.c:233:17: error: storage size of ‘ctx’ isn’t known 233 | EVP_CIPHER_CTX ctx; | ^~~ That's bug #592494. Created attachment 649446 [details, diff]
files/ipmitool-1.8.18-fno-common.patch
Actually, since gVersionInfo is only used in lib/ipmi_hpmfwupg.c, just declare it static there, and remove it from the (internal) header file include/ipmitool/ipmi_hpmfwupg.h.
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=27c39af013c9ba5db43cd7f37eabb69b7d076873 commit 27c39af013c9ba5db43cd7f37eabb69b7d076873 Author: Patrick McLean <patrick.mclean@sony.com> AuthorDate: 2020-08-19 21:28:19 +0000 Commit: Patrick McLean <chutzpah@gentoo.org> CommitDate: 2020-08-19 21:28:35 +0000 sys-apps/ipmitool-1.8.18-r1: Fix build with gcc-10 (bug #706870) Closes: https://bugs.gentoo.org/706870 Copyright: Sony Interactive Entertainment Inc. Package-Manager: Portage-3.0.4, Repoman-3.0.1 Signed-off-by: Patrick McLean <chutzpah@gentoo.org> .../files/ipmitool-1.8.18-fno-common.patch | 22 ++++++++++++++++++++++ sys-apps/ipmitool/ipmitool-1.8.18-r1.ebuild | 1 + 2 files changed, 23 insertions(+) (In reply to Larry the Git Cow from comment #14) > The bug has been closed via the following commit(s): > > https://gitweb.gentoo.org/repo/gentoo.git/commit/ > ?id=27c39af013c9ba5db43cd7f37eabb69b7d076873 > > commit 27c39af013c9ba5db43cd7f37eabb69b7d076873 > Author: Patrick McLean <patrick.mclean@sony.com> > AuthorDate: 2020-08-19 21:28:19 +0000 > Commit: Patrick McLean <chutzpah@gentoo.org> > CommitDate: 2020-08-19 21:28:35 +0000 > > sys-apps/ipmitool-1.8.18-r1: Fix build with gcc-10 (bug #706870) > > Closes: https://bugs.gentoo.org/706870 > Copyright: Sony Interactive Entertainment Inc. > Package-Manager: Portage-3.0.4, Repoman-3.0.1 > Signed-off-by: Patrick McLean <chutzpah@gentoo.org> > > .../files/ipmitool-1.8.18-fno-common.patch | 22 > ++++++++++++++++++++++ > sys-apps/ipmitool/ipmitool-1.8.18-r1.ebuild | 1 + > 2 files changed, 23 insertions(+) You are seriously claiming both copyright and authorship of the patch attached above for Sony? *slow clap* |