| Summary: | media-sound/aqualung-1.0-r3 : fails to build with -fno-common or gcc-10 | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Toralf Förster <toralf> |
| Component: | Current packages | Assignee: | Daniel Pielmeier <billie> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kripton, sound, stefantalpalaru |
| Priority: | Normal | Keywords: | PullRequest |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | Linux | ||
| See Also: | https://github.com/gentoo/gentoo/pull/16958 | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Bug Depends on: | |||
| Bug Blocks: | 705764 | ||
| Attachments: |
emerge-info.txt
emerge-history.txt environment etc.portage.tbz2 logs.tbz2 media-sound:aqualung-1.0-r3:20200127-231801.log temp.tbz2 |
||
Created attachment 605974 [details]
emerge-info.txt
Created attachment 605976 [details]
emerge-history.txt
Created attachment 605978 [details]
environment
Created attachment 605980 [details]
etc.portage.tbz2
Created attachment 605982 [details]
logs.tbz2
Created attachment 605984 [details]
media-sound:aqualung-1.0-r3:20200127-231801.log
Created attachment 605986 [details]
temp.tbz2
A working aqualung-1.0-r4 is available in my overlay: https://github.com/stefantalpalaru/gentoo-overlay (In reply to Ștefan Talpalaru from comment #8) > A working aqualung-1.0-r4 is available in my overlay: > https://github.com/stefantalpalaru/gentoo-overlay This is just a workaround! -fnocommon was set default for a reason. So disabling it is not the solution. But you are lucky after some idle time there is again activity upstream and a real fix [1] made it there. They are even talking about making a new release shortly, so I for the moment I don't bother adding this to the current version. [1] https://github.com/jeremyevans/aqualung/commit/7f5d1f266957b3fa73799d3edef6b19ff9716d02 (In reply to Daniel Pielmeier from comment #9) > This is just a workaround! Of course it is, and it's also the pragmatic solution that helps users, as opposed to leaving a package broken with gcc-10 for 6 months. (In reply to Ștefan Talpalaru from comment #10) > (In reply to Daniel Pielmeier from comment #9) > > This is just a workaround! > > Of course it is, and it's also the pragmatic solution that helps users, as > opposed to leaving a package broken with gcc-10 for 6 months. From users running testing gcc I expect them to deal with such issues themselves! Maybe they even can provide a proper patch! And hey it is just a small piece of software. I even thought about dropping it from the tree as upstream seems to be in kind of a hiatus. So feel lucky it is still there and builds and runs fine on a STABLE system! EOD from my side! When bumping the release in the Gentoo tree, could you please also take care of #734928 ? Thanks! I've taken the patch from upstream and updated the ebuild: https://github.com/gentoo/gentoo/pull/16958 The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=27926914b1af08c106fec7bb5cf0bda6dec4caad commit 27926914b1af08c106fec7bb5cf0bda6dec4caad Author: Jannis Achstetter <kripton@kripserver.net> AuthorDate: 2020-08-02 19:05:10 +0000 Commit: Daniel Pielmeier <billie@gentoo.org> CommitDate: 2020-08-04 18:39:34 +0000 media-sound/aqualung: Fix compile with gcc 10 And make USE=jack depend on `virtual/jack` instead of `media-sound/jack-audio-connection-kit`. Adding this as new revision so we have current `-r3` with stable keywords and this with unstable keywords. Closes: https://bugs.gentoo.org/734928 Closes: https://bugs.gentoo.org/706828 Package-Manager: Portage-3.0.1, Repoman-2.3.23 Signed-off-by: Jannis Achstetter <kripton@kripserver.net> Signed-off-by: Daniel Pielmeier <billie@gentoo.org> media-sound/aqualung/aqualung-1.0-r4.ebuild | 101 +++++++++++++++++++++ .../aqualung/files/aqualung-1.0-gcc10.patch | 69 ++++++++++++++ 2 files changed, 170 insertions(+) |
/usr/include/bits/string_fortified.h:106:10: warning: ‘__builtin_strncpy’ output may be truncated copying 1023 bytes from a string of length 1023 [-Wstringop-truncation] 106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ x86_64-pc-linux-gnu-gcc -I/usr/include/libxml2 -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/lib64/libffi/include -I/usr/include/fribidi -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/uuid -I/usr/include/libdrm -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/atk-1.0 -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -pthread -Wall -O2 -pipe -march=native -fno-common -Wl,-O1 -Wl,--as-needed -o aqualung aqualung-about.o aqualung-athread.o aqualung-build_store.o aqualung-core.o aqualung-cover.o aqualung-ext_lua.o aqualung-file_info.o aqualung-gui_main.o aqualung-httpc.o aqualung-metadata.o aqualung-metadata_api.o aqualung-metadata_ape.o aqualung-metadata_id3v1.o aqualung-metadata_id3v2.o aqualung-metadata_ogg.o aqualung-music_browser.o aqualung-options.o aqualung-playlist.o aqualung-rb.o aqualung-search.o aqualung-search_playlist.o aqualung-segv.o aqualung-skin.o aqualung-store_file.o aqualung-transceiver.o aqualung-trashlist.o aqualung-utils.o aqualung-utils_gui.o aqualung-utils_xml.o aqualung-volume.o aqualung-cdda.o aqualung-store_cdda.o aqualung-cd_ripper.o aqualung-metadata_flac.o aqualung-loop_bar.o aqualung-export.o decoder/libdecoder.a encoder/libencoder.a -lxml2 -lgtk-x11-2.0 -lgdk-x11-2.0 -lpangocairo-1.0 -latk-1.0 -lcairo -lgdk_pixbuf-2.0 -lgio-2.0 -lpangoft2-1.0 -lpango-1.0 -lgobject-2.0 -lglib-2.0 -lfontconfig -lfreetype -lgthread-2.0 -pthread -lglib-2.0 -lasound -lFLAC -lmad -lm -lvorbis -lvorbisfile -logg -lvorbisenc -logg -lcdio_paranoia -lcdio_cdda -lcdio -lm -lpthread -lm -lbz2 -lz /usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: aqualung-playlist.o:(.bss+0x40): multiple definition of `command'; aqualung-gui_main.o:(.bss+0x280): first defined here collect2: error: ld returned 1 exit status ------------------------------------------------------------------- This is an unstable amd64 chroot image at a tinderbox (==build bot) name: 17.1_desktop-libressl-20200125-232521 ------------------------------------------------------------------- Please see the tracker bug for details. gcc-config -l: [1] x86_64-pc-linux-gnu-9.2.0 * clang: clang version 9.0.1 Target: x86_64-pc-linux-gnu Thread model: posix InstalledDir: /usr/lib/llvm/9/bin llvm: 9.0.1 Available Python interpreters, in order of preference: [1] python3.8 [2] python3.7 (uninstalled) [3] python3.6 [4] python2.7 (fallback) Available Ruby profiles: [1] ruby24 (with Rubygems) [2] ruby25 (with Rubygems) * Available Rust versions: [1] rust-1.40.0 * java-config: The following VMs are available for generation-2: *) IcedTea JDK 3.14.0 [icedtea-bin-8] Available Java Virtual Machines: [1] icedtea-bin-8 system-vm repository: ==> /var/db/repos/gentoo/metadata/timestamp.chk <== Mon, 27 Jan 2020 23:06:20 +0000 emerge -qpvO media-sound/aqualung [ebuild N ] media-sound/aqualung-1.0-r3 USE="alsa cdda flac mp3 vorbis -cddb -debug -ffmpeg -ifp -jack -ladspa -lame -libav -libsamplerate -lua -mac -modplug -musepack -oss -podcast -pulseaudio -sndfile -speex -systray -wavpack"