Bug 706286

Summary:	=x11-misc/i3lock-2.12-r1 fails to build with -fno-common or gcc-10
Product:	Gentoo Linux	Reporter:	Hans de Graaff <graaff>
Component:	Current packages	Assignee:	Desktop Misc. Team <desktop-misc>
Status:	RESOLVED FIXED
Severity:	normal	CC:	slyfox
Priority:	Normal
Version:	unspecified
Hardware:	All
OS:	Linux
URL:	https://github.com/i3/i3lock/pull/259
See Also:	https://bugs.gentoo.org/show_bug.cgi?id=762610
Whiteboard:
Package list:		Runtime testing required:	---
Bug Depends on:
Bug Blocks:	705764

Description Hans de Graaff gentoo-dev

2020-01-25 09:37:44 UTC

x86_64-pc-linux-gnu-gcc -Wunused-value      -I/usr/include/cairo -I/usr/lib64/libffi-3.3_rc0/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/uuid -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/libpng16  -Wall -O2 -pipe -march=native -Wformat-security -Winvalid-pch -fno-common  -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -o i3lock i3lock-dpi.o i3lock-i3lock.o i3lock-randr.o i3lock-unlock_indicator.o i3lock-xcb.o -lxcb -lxcb-xkb -lxcb-xinerama -lxcb-randr -lxcb-image -lxcb -lxcb-shm -lxcb-util -lxcb -lxcb-xrm -lxcb -lxkbcommon-x11 -lxkbcommon -lcairo  -lpam -lrt -lev -lm 
/usr/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: i3lock-unlock_indicator.o:(.bss+0x8): multiple definition of `input_position'; i3lock-i3lock.o:(.bss+0x2c): first defined here

Comment 1 Larry the Git Cow gentoo-dev

2020-01-25 10:48:13 UTC

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=09411e9512455df329ebd9fee8d1fd1b709d124e

commit 09411e9512455df329ebd9fee8d1fd1b709d124e
Author:     Jeroen Roovers <jer@gentoo.org>
AuthorDate: 2020-01-25 10:35:25 +0000
Commit:     Jeroen Roovers <jer@gentoo.org>
CommitDate: 2020-01-25 10:48:07 +0000

    x11-misc/i3lock: Fix compiling with -fno-common
    
    Package-Manager: Portage-2.3.85, Repoman-2.3.20
    Closes: https://bugs.gentoo.org/706286
    Signed-off-by: Jeroen Roovers <jer@gentoo.org>

 x11-misc/i3lock/files/i3lock-2.12-fno-common.patch | 11 +++++
 x11-misc/i3lock/i3lock-2.12-r2.ebuild              | 47 ++++++++++++++++++++++
 2 files changed, 58 insertions(+)

Comment 2 Sergei Trofimovich (RETIRED) gentoo-dev

2020-01-25 11:32:00 UTC

Proposed fix upstream as: https://github.com/i3/i3lock/pull/259

Comment 3 Jeroen Roovers (RETIRED) gentoo-dev

2020-01-25 11:52:09 UTC

(In reply to Sergei Trofimovich from comment #2)
> Proposed fix upstream as: https://github.com/i3/i3lock/pull/259

You uploaded my patch!

Comment 4 Jeroen Roovers (RETIRED) gentoo-dev

2020-01-25 11:53:23 UTC

(In reply to Jeroen Roovers from comment #3)
> (In reply to Sergei Trofimovich from comment #2)
> > Proposed fix upstream as: https://github.com/i3/i3lock/pull/259
> 
> You uploaded my patch!

Without attribution!

Comment 5 Jeroen Roovers (RETIRED) gentoo-dev

2020-01-25 12:05:59 UTC

(In reply to Jeroen Roovers from comment #4)
> (In reply to Jeroen Roovers from comment #3)
> > (In reply to Sergei Trofimovich from comment #2)
> > > Proposed fix upstream as: https://github.com/i3/i3lock/pull/259
> > 
> > You uploaded my patch!
> 
> Without attribution!

Comment 6 Sergei Trofimovich (RETIRED) gentoo-dev

2020-01-25 12:44:09 UTC

(In reply to Jeroen Roovers from comment #5)
> (In reply to Jeroen Roovers from comment #4)
> > (In reply to Jeroen Roovers from comment #3)
> > > (In reply to Sergei Trofimovich from comment #2)
> > > > Proposed fix upstream as: https://github.com/i3/i3lock/pull/259
> > > 
> > > You uploaded my patch!
> > 
> > Without attribution!

I did not see your patch until after I filed pull request. Many of them are trivial after all.

I've set you as a patch author and force-pushet commit in pull request.