| Summary: | gkrellm-mldonkey-0.9.4.ebuild (New Package) | ||
|---|---|---|---|
| Product: | Gentoo Linux | Reporter: | Red Sonja <gigatony> |
| Component: | New packages | Assignee: | Jon Hood (RETIRED) <squinky86> |
| Status: | RESOLVED UPSTREAM | ||
| Severity: | enhancement | CC: | dabljuh, gigatony, net-p2p |
| Priority: | High | Keywords: | EBUILD |
| Version: | unspecified | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | http://www.tof2k.com/gkremldk/ | ||
| Whiteboard: | |||
| Package list: | Runtime testing required: | --- | |
| Attachments: |
gkremldk-0.9.6.ebuild
x11-plugins/gkremldk-0.9.7.ebuild (Update) |
||
|
Description
Red Sonja
2004-11-09 15:12:30 UTC
Created attachment 63846 [details]
gkremldk-0.9.6.ebuild
This is an ebuild for gkremldk version 0.9.6. Enjoy
Hey Red and Sam; there are a few issues with the attached ebuild that I'd like to walk through before it can be added to portage.
1) Note how you're setting the variable "${S}". In the global scope, we're setting it "${WORKDIR}/${PN}"; however, in the function-scope, it gets set to ${WORKDIR}/${P}. Why not just set S in the global scope to ${WORKDIR}/${P} and then you won't have to keep setting it within the functions, then having to "cd" into that directory?
2) in src_unpack(), look at some other ebuilds for an appropriate example. Let's try to use something along the lines of "unpack ${A}" then "cd ${S}" to keep it uniform with other packages in portage. Also, the "echo" there is kinda unnecessary.
3) Is the "export PATH" really necessary in src_compile()?
Created attachment 87275 [details]
x11-plugins/gkremldk-0.9.7.ebuild (Update)
Update for a new version of gkremldk and a bit cleanup.
Jon it's realy can't be unpack ${A} in the src_unpack() function because the author made expantion .tbz instead of .tar.bz2 for some reasone, so unpack ${A} says that it's couldn't understand file type.
P.S. Sorry for my english if it's bad ;)
Thanks for sticking with this bug, but this plugin does not appear to work with gkrellm-2.2.9. Please reopen when an update is available. /usr/lib64/gkrellm2/plugins/gkremldk.so Error: /usr/lib64/gkrellm2/plugins/gkremldk.so: undefined symbol: gkrellm_chart_enable_visibility /usr/lib64/gkrellm2/plugins/volume.so Error: /usr/lib64/gkrellm2/plugins/volume.so: undefined symbol: gkrellm_locale_dup_string |
